* [PATCH -next] iio: dummy: Fix build error when CONFIG_IIO_TRIGGERED_BUFFER is not set
@ 2021-05-24 14:05 Wei Yongjun
2021-05-26 17:00 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Wei Yongjun @ 2021-05-24 14:05 UTC (permalink / raw)
To: weiyongjun1, Alexandru Ardelean, Jonathan Cameron
Cc: linux-iio, kernel-janitors, Hulk Robot
Gcc reports build error when CONFIG_IIO_TRIGGERED_BUFFER is not set:
riscv64-linux-gnu-ld: drivers/iio/dummy/iio_simple_dummy_buffer.o: in function `iio_simple_dummy_configure_buffer':
iio_simple_dummy_buffer.c:(.text+0x2b0): undefined reference to `iio_triggered_buffer_setup_ext'
riscv64-linux-gnu-ld: drivers/iio/dummy/iio_simple_dummy_buffer.o: in function `.L0 ':
iio_simple_dummy_buffer.c:(.text+0x2fc): undefined reference to `iio_triggered_buffer_cleanup'
Fix it by select IIO_TRIGGERED_BUFFER for config IIO_SIMPLE_DUMMY_BUFFER.
Fixes: 738f6ba11800 ("iio: dummy: iio_simple_dummy_buffer: use triggered buffer core calls")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/iio/dummy/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/dummy/Kconfig b/drivers/iio/dummy/Kconfig
index 5c5c2f8c55f3..1f46cb9e51b7 100644
--- a/drivers/iio/dummy/Kconfig
+++ b/drivers/iio/dummy/Kconfig
@@ -34,6 +34,7 @@ config IIO_SIMPLE_DUMMY_BUFFER
select IIO_BUFFER
select IIO_TRIGGER
select IIO_KFIFO_BUF
+ select IIO_TRIGGERED_BUFFER
help
Add buffered data capture to the simple dummy driver.
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] iio: dummy: Fix build error when CONFIG_IIO_TRIGGERED_BUFFER is not set
2021-05-24 14:05 [PATCH -next] iio: dummy: Fix build error when CONFIG_IIO_TRIGGERED_BUFFER is not set Wei Yongjun
@ 2021-05-26 17:00 ` Jonathan Cameron
2021-06-11 17:31 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Cameron @ 2021-05-26 17:00 UTC (permalink / raw)
To: Wei Yongjun; +Cc: Alexandru Ardelean, linux-iio, kernel-janitors, Hulk Robot
On Mon, 24 May 2021 14:05:36 +0000
Wei Yongjun <weiyongjun1@huawei.com> wrote:
> Gcc reports build error when CONFIG_IIO_TRIGGERED_BUFFER is not set:
>
> riscv64-linux-gnu-ld: drivers/iio/dummy/iio_simple_dummy_buffer.o: in function `iio_simple_dummy_configure_buffer':
> iio_simple_dummy_buffer.c:(.text+0x2b0): undefined reference to `iio_triggered_buffer_setup_ext'
> riscv64-linux-gnu-ld: drivers/iio/dummy/iio_simple_dummy_buffer.o: in function `.L0 ':
> iio_simple_dummy_buffer.c:(.text+0x2fc): undefined reference to `iio_triggered_buffer_cleanup'
>
> Fix it by select IIO_TRIGGERED_BUFFER for config IIO_SIMPLE_DUMMY_BUFFER.
>
> Fixes: 738f6ba11800 ("iio: dummy: iio_simple_dummy_buffer: use triggered buffer core calls")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Thanks,
Applied to the fixes-togreg branch of iio.git.
Jonathan
> ---
> drivers/iio/dummy/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/dummy/Kconfig b/drivers/iio/dummy/Kconfig
> index 5c5c2f8c55f3..1f46cb9e51b7 100644
> --- a/drivers/iio/dummy/Kconfig
> +++ b/drivers/iio/dummy/Kconfig
> @@ -34,6 +34,7 @@ config IIO_SIMPLE_DUMMY_BUFFER
> select IIO_BUFFER
> select IIO_TRIGGER
> select IIO_KFIFO_BUF
> + select IIO_TRIGGERED_BUFFER
> help
> Add buffered data capture to the simple dummy driver.
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] iio: dummy: Fix build error when CONFIG_IIO_TRIGGERED_BUFFER is not set
2021-05-26 17:00 ` Jonathan Cameron
@ 2021-06-11 17:31 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2021-06-11 17:31 UTC (permalink / raw)
To: Wei Yongjun; +Cc: Alexandru Ardelean, linux-iio, kernel-janitors, Hulk Robot
On Wed, 26 May 2021 18:00:18 +0100
Jonathan Cameron <jic23@kernel.org> wrote:
> On Mon, 24 May 2021 14:05:36 +0000
> Wei Yongjun <weiyongjun1@huawei.com> wrote:
>
> > Gcc reports build error when CONFIG_IIO_TRIGGERED_BUFFER is not set:
> >
> > riscv64-linux-gnu-ld: drivers/iio/dummy/iio_simple_dummy_buffer.o: in function `iio_simple_dummy_configure_buffer':
> > iio_simple_dummy_buffer.c:(.text+0x2b0): undefined reference to `iio_triggered_buffer_setup_ext'
> > riscv64-linux-gnu-ld: drivers/iio/dummy/iio_simple_dummy_buffer.o: in function `.L0 ':
> > iio_simple_dummy_buffer.c:(.text+0x2fc): undefined reference to `iio_triggered_buffer_cleanup'
> >
> > Fix it by select IIO_TRIGGERED_BUFFER for config IIO_SIMPLE_DUMMY_BUFFER.
> >
> > Fixes: 738f6ba11800 ("iio: dummy: iio_simple_dummy_buffer: use triggered buffer core calls")
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>
> Thanks,
>
> Applied to the fixes-togreg branch of iio.git.
Change of plan on this one as I haven't yet sent a fixes pull and now we are
late in the cycle. I've moved it over to my togreg branch and will line it
up for the coming merge window.
Sorry for the delay
Jonathan
>
> Jonathan
>
> > ---
> > drivers/iio/dummy/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/iio/dummy/Kconfig b/drivers/iio/dummy/Kconfig
> > index 5c5c2f8c55f3..1f46cb9e51b7 100644
> > --- a/drivers/iio/dummy/Kconfig
> > +++ b/drivers/iio/dummy/Kconfig
> > @@ -34,6 +34,7 @@ config IIO_SIMPLE_DUMMY_BUFFER
> > select IIO_BUFFER
> > select IIO_TRIGGER
> > select IIO_KFIFO_BUF
> > + select IIO_TRIGGERED_BUFFER
> > help
> > Add buffered data capture to the simple dummy driver.
> >
> >
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-11 17:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-24 14:05 [PATCH -next] iio: dummy: Fix build error when CONFIG_IIO_TRIGGERED_BUFFER is not set Wei Yongjun
2021-05-26 17:00 ` Jonathan Cameron
2021-06-11 17:31 ` Jonathan Cameron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.