From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0BDEC47086 for ; Mon, 24 May 2021 15:20:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ACC0D613B0 for ; Mon, 24 May 2021 15:20:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235224AbhEXPUW (ORCPT ); Mon, 24 May 2021 11:20:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:40044 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234601AbhEXPIK (ORCPT ); Mon, 24 May 2021 11:08:10 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 745606191C; Mon, 24 May 2021 14:51:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621867897; bh=hZJelB3zNRFZOwPJ8SOfGMyVUjlCrO4IOxyziMILlIw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=N3jkwjzYasl9NLraNGFlGbl4HPFmIbM+lBd/Vb4BlUMtjzWaMEm5QLUnNQfoZA3tm vTOJVFKHV4h67mBAaDh/8BKlywysy5lOfsZO3ueRIpt9QNUMJmGvKLsnUcXVRftFcx O1wEf19/cSP/ZJ3qPBsbtJqAVdBA2lNBFYxgSFLs5CsP+QRKsEaz/MmHD91Xo1lBF/ YTHErM2qxdPLkAZJVmlLjdnBDu744uk3KCKn3BJb66aWgwBmjtZ0SzJAIkVjoG7Hya 39E1c5TS+X9ir9wf4Tk/kxIsee8hUV6QeQSnKKc655WI9aK3AbIMdNHzbvEEAe+Xpz O3RwM5kQtIogw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Atul Gopinathan , Takashi Iwai , Greg Kroah-Hartman , Sasha Levin , alsa-devel@alsa-project.org Subject: [PATCH AUTOSEL 4.4 05/16] ALSA: sb8: Add a comment note regarding an unused pointer Date: Mon, 24 May 2021 10:51:19 -0400 Message-Id: <20210524145130.2499829-5-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210524145130.2499829-1-sashal@kernel.org> References: <20210524145130.2499829-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Atul Gopinathan [ Upstream commit a28591f61b60fac820c6de59826ffa710e5e314e ] The field "fm_res" of "struct snd_sb8" is never used/dereferenced throughout the sb8.c code. Therefore there is no need for any null value check after the "request_region()". Add a comment note to make developers know about this and prevent any "NULL check" patches on this part of code. Cc: Takashi Iwai Signed-off-by: Atul Gopinathan Link: https://lore.kernel.org/r/20210503115736.2104747-36-gregkh@linuxfoundation.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- sound/isa/sb/sb8.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sound/isa/sb/sb8.c b/sound/isa/sb/sb8.c index 0c7fe1418447..815639c04c52 100644 --- a/sound/isa/sb/sb8.c +++ b/sound/isa/sb/sb8.c @@ -109,7 +109,11 @@ static int snd_sb8_probe(struct device *pdev, unsigned int dev) acard = card->private_data; card->private_free = snd_sb8_free; - /* block the 0x388 port to avoid PnP conflicts */ + /* + * Block the 0x388 port to avoid PnP conflicts. + * No need to check this value after request_region, + * as we never do anything with it. + */ acard->fm_res = request_region(0x388, 4, "SoundBlaster FM"); if (!acard->fm_res) { err = -EBUSY; -- 2.30.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E30A9C2B9F7 for ; Mon, 24 May 2021 14:59:04 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B6C16128B for ; Mon, 24 May 2021 14:59:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B6C16128B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0C4BE16E8; Mon, 24 May 2021 16:58:13 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0C4BE16E8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1621868343; bh=hZJelB3zNRFZOwPJ8SOfGMyVUjlCrO4IOxyziMILlIw=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=cp5fAx/C2iostyIpIjqY5RG7PRyinvAt/eOzzEAuxV8T2aFAga7/62elV+Jycygmq 5FLy1MujqcN1nA8QCqdqbQUQSHN1yhwJfJKJAGDjLxEhs2JgABW6C6PdBl2qsntAAB NKMCsN8IZAjYLGhPRwaGC2pxTTi8tJsju3gqRcZw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 5F111F804CF; Mon, 24 May 2021 16:51:43 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E37A8F804E3; Mon, 24 May 2021 16:51:41 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 89A71F804CF for ; Mon, 24 May 2021 16:51:39 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 89A71F804CF Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="N3jkwjzY" Received: by mail.kernel.org (Postfix) with ESMTPSA id 745606191C; Mon, 24 May 2021 14:51:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621867897; bh=hZJelB3zNRFZOwPJ8SOfGMyVUjlCrO4IOxyziMILlIw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=N3jkwjzYasl9NLraNGFlGbl4HPFmIbM+lBd/Vb4BlUMtjzWaMEm5QLUnNQfoZA3tm vTOJVFKHV4h67mBAaDh/8BKlywysy5lOfsZO3ueRIpt9QNUMJmGvKLsnUcXVRftFcx O1wEf19/cSP/ZJ3qPBsbtJqAVdBA2lNBFYxgSFLs5CsP+QRKsEaz/MmHD91Xo1lBF/ YTHErM2qxdPLkAZJVmlLjdnBDu744uk3KCKn3BJb66aWgwBmjtZ0SzJAIkVjoG7Hya 39E1c5TS+X9ir9wf4Tk/kxIsee8hUV6QeQSnKKc655WI9aK3AbIMdNHzbvEEAe+Xpz O3RwM5kQtIogw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH AUTOSEL 4.4 05/16] ALSA: sb8: Add a comment note regarding an unused pointer Date: Mon, 24 May 2021 10:51:19 -0400 Message-Id: <20210524145130.2499829-5-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210524145130.2499829-1-sashal@kernel.org> References: <20210524145130.2499829-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Cc: Takashi Iwai , Greg Kroah-Hartman , Atul Gopinathan , alsa-devel@alsa-project.org, Sasha Levin X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" From: Atul Gopinathan [ Upstream commit a28591f61b60fac820c6de59826ffa710e5e314e ] The field "fm_res" of "struct snd_sb8" is never used/dereferenced throughout the sb8.c code. Therefore there is no need for any null value check after the "request_region()". Add a comment note to make developers know about this and prevent any "NULL check" patches on this part of code. Cc: Takashi Iwai Signed-off-by: Atul Gopinathan Link: https://lore.kernel.org/r/20210503115736.2104747-36-gregkh@linuxfoundation.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- sound/isa/sb/sb8.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sound/isa/sb/sb8.c b/sound/isa/sb/sb8.c index 0c7fe1418447..815639c04c52 100644 --- a/sound/isa/sb/sb8.c +++ b/sound/isa/sb/sb8.c @@ -109,7 +109,11 @@ static int snd_sb8_probe(struct device *pdev, unsigned int dev) acard = card->private_data; card->private_free = snd_sb8_free; - /* block the 0x388 port to avoid PnP conflicts */ + /* + * Block the 0x388 port to avoid PnP conflicts. + * No need to check this value after request_region, + * as we never do anything with it. + */ acard->fm_res = request_region(0x388, 4, "SoundBlaster FM"); if (!acard->fm_res) { err = -EBUSY; -- 2.30.2