From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBE55C2B9F7 for ; Mon, 24 May 2021 17:44:56 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D0584613EA for ; Mon, 24 May 2021 17:44:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D0584613EA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4009182E9C; Mon, 24 May 2021 19:44:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="X76RJhTA"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F2E9882EAF; Mon, 24 May 2021 19:44:50 +0200 (CEST) Received: from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com [IPv6:2607:f8b0:4864:20::f2a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AF5A682EA5 for ; Mon, 24 May 2021 19:44:43 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2a.google.com with SMTP id c13so13417164qvx.5 for ; Mon, 24 May 2021 10:44:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=SvHd0t5QdrzilgQYVdSMbeyzUYk9nb0eFIMo3DI9LDg=; b=X76RJhTA+a8d/65uVstMQQk47yjbE+PGAW5cuXmko5UA1F+P8rx5UCWe1riS9ua3SC w32SAYFtL2a7OTp1PvtAcCQxxagkkSEEAxkOC4Z/0OXpvfndBcWjFfys9/oiGE0CAoVA JqWgC9CPOcwe5JrbBIS5RmhIT4A46dKX5dXS8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=SvHd0t5QdrzilgQYVdSMbeyzUYk9nb0eFIMo3DI9LDg=; b=i9XrBvbxKgpsC3iONZYrE8Fh2nBWySintj7pWt5DXQfeAeQIcOdBMgwiPZAbm493Ih xkkWHa6+D/SqZ+hAAZfcucaoQn1jU2jc/yNX+TWEg6lTC73r245J44oHkxL79X8yFIwK W0tFfVOgM4HX88odz/3JcC5kH5+IbMgVQCY8vYiBIzKCEKTAX2cG9fYUT0kS4x9k8f4y g7+olKG7rffgqH3qxnX+chn1M+3P9BG9kqKGBsw2gwSnA4zcU/WPbnBKvYiGUcK9/PVo QwduNeDk5HudpiIBM1Wf5Dn2DAIO/xBARV9i/G7zhIu983Dg7YBTurK0tVDg37P9A4aQ FlaA== X-Gm-Message-State: AOAM53124mv0rEVLi7LUldY3dPXy1IvH/FuqFRaE+W4PEVXOZ01z24D0 3VfGH8opH31LBZ915USrAVzQFA== X-Google-Smtp-Source: ABdhPJwyGL7AAO8qDvxM3NC6xqfHJ0vpYCWV7dWBvRpxmZ9AKBoHtJuY4e4iglK2LaVO/rR0MMVU+g== X-Received: by 2002:a0c:bf4b:: with SMTP id b11mr32388502qvj.11.1621878282317; Mon, 24 May 2021 10:44:42 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-5ce8-9acb-4a3a-47a0.res6.spectrum.com. [2603:6081:7b01:cbda:5ce8:9acb:4a3a:47a0]) by smtp.gmail.com with ESMTPSA id m14sm9836667qti.12.2021.05.24.10.44.40 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 24 May 2021 10:44:41 -0700 (PDT) Date: Mon, 24 May 2021 13:44:38 -0400 From: Tom Rini To: Marek Behun Cc: Adam Ford , U-Boot Mailing List , Simon Glass , Heiko Schocher , Patrick Delaunay , Patrice CHOTARD , Miquel Raynal , Pali =?iso-8859-1?Q?Roh=E1r?= , Stefan Roese , Heinrich Schuchardt , Alexander Graf , Marek Vasut , Neil Armstrong , Ryder Lee , Bin Meng , Harald Seiler , Tim Harvey Subject: Re: [PATCH u-boot v4 36/36] ARM: enable LTO for some boards Message-ID: <20210524174438.GD17669@bill-the-cat> References: <20210520112425.25166-1-marek.behun@nic.cz> <20210520112425.25166-37-marek.behun@nic.cz> <20210521141147.GG17669@bill-the-cat> <20210521180031.08b842e0@dellmb> <20210521165641.GK17669@bill-the-cat> <20210524154053.GA17669@bill-the-cat> <20210524175855.2090a751@thinkpad> <20210524170919.GC17669@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="h6lXIlgsgkZ6K0z8" Content-Disposition: inline In-Reply-To: <20210524170919.GC17669@bill-the-cat> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean --h6lXIlgsgkZ6K0z8 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 24, 2021 at 01:09:19PM -0400, Tom Rini wrote: > On Mon, May 24, 2021 at 05:58:55PM +0200, Marek Behun wrote: > > On Mon, 24 May 2021 11:40:53 -0400 > > Tom Rini wrote: > >=20 > > > On Fri, May 21, 2021 at 12:56:41PM -0400, Tom Rini wrote: > > > > On Fri, May 21, 2021 at 06:00:31PM +0200, Marek Beh=FAn wrote: =20 > > > > > On Fri, 21 May 2021 10:11:47 -0400 > > > > > Tom Rini wrote: > > > > > =20 > > > > > > On Thu, May 20, 2021 at 01:56:29PM -0500, Adam Ford wrote: =20 > > > > > > > On Thu, May 20, 2021 at 6:25 AM Marek Beh=FAn > > > > > > > wrote: =20 > > > > > > > > > > > > > > > > Enable LTO for some boards that were tested by people on U-= Boot > > > > > > > > Mailing List. > > > > > > > > > > > > > > > > Signed-off-by: Marek Beh=FAn > > > > > > > > Tested-by: Adam Ford > > > > > > > > Tested-by: Pali Roh=E1r > > > > > > > > Tested-by: Tim Harvey =20 > > > > > > >=20 > > > > > > > Since the imx8mm beacon boards and the imx8mm venice board bo= th show > > > > > > > promise, does it make sense to 'imply' the LTO for anything e= nabling > > > > > > > imx8mm? > > > > > > > Same thing for the various omap3 boards, and potentially the = renesas > > > > > > > RZ/G2 boards. I know Tom went through to remove a bunch of b= oards > > > > > > > that were never converted to DM. Most of the boards remaining > > > > > > > boards have minimal board files and most of code is common to= other > > > > > > > boards in the same platforms. > > > > > > >=20 > > > > > > > I have an l138_lcdk that I can use to test which I expect to = be > > > > > > > similar to the da850evm. =20 > > > > > >=20 > > > > > > As much as I am eager to move everything, quickly, over to LTO = by > > > > > > default, I think the problems that we've seen thus far show it'= s best > > > > > > to really make it an explicit enable per board at least for the= first > > > > > > release or two. Once we've hopefully gotten more boards tested= and > > > > > > enabled we can see what makes sense for defaults, give a releas= e worth > > > > > > of heads up, and then go. =20 > > > > >=20 > > > > > Tom, are there some other issues aside from the one failing CI sc= enario > > > > > (sandbox_clang)? Would you be willing to merge this if I resolved= that > > > > > one fail by disabling LTO for that scenario (until I resolve it)?= It > > > > > would help me not having to maintain all 30+ patches... =20 > > > >=20 > > > > Yeah, CI needs to keep passing, so if we need to disable > > > > sandbox+clang+lto for now, OK. =20 > > >=20 > > > Ah, I see the problem now. I've worked out a fix after looking at the > > > Linux kernel a bit and I'll post something for us and upstream dtc as > > > well. > > >=20 > >=20 > > What do you mean? The problem is in dtc? I see 2 problems: > > - one with DM test > > - one with stack protector test >=20 > I don't have a full answer about the stack protector test just yet, but > it almost seems like it's too simple and maybe something is happening > with it being optimized to not a problem? Yeah, so clang with LTO optimizes away that memset call, and so the test passes. I'll do something to make sure the array is used so it won't be optimized away. --=20 Tom --h6lXIlgsgkZ6K0z8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmCr5gMACgkQFHw5/5Y0 tyw4mAv9GunlqcCsjAMJvVPMua/gMBo6MuWM/ZiX9qjl1VLNDcC6//hrJoqZ3Yq6 755vUOItuFV3clP1s5QCp8Q3GnHF3ahEEdZ2Z6FEnM5QDKlCTptB4vNEIjKI3Oh5 xuPRqPFQ94ApqtqSGGbABtQBgDnGpDUr9vNwtaq+OsmCyDkdXcvTjK1jAO/bblrQ wQKZakx+15vwaNU9qzlqJNGcsZcTw+DovvDo6GqtMcyPhS/sHpq/vSyyt/8JJZLe gwE0DHW8ZZvgG0AoWYRLTseQUXKDPXOb9XEAUcKbdZE3Dr5yVLpdDW4TN5wLLG+u cadey38jBFxLN+HzgzVz3PDuBgSaoKqnT/AM8HCEvtpjY+YI+6WNlj1Q6hGOeD8f /jCn7y0FYqsZcH2zX1c/YyGPB/+SwtwEv/hsXxDogXlkxUT+PRhnXpYJjAYgkzgp 6T2gbBjCkLq/zYbs5htQaYUSi7syznUIH+cmOdax7rR++rYzff+l7qptukyUF+le CMQ/vc6B =b9DW -----END PGP SIGNATURE----- --h6lXIlgsgkZ6K0z8--