From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3848C2B9F8 for ; Mon, 24 May 2021 20:21:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 89386613CC for ; Mon, 24 May 2021 20:21:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233073AbhEXUXH (ORCPT ); Mon, 24 May 2021 16:23:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:48806 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233009AbhEXUXG (ORCPT ); Mon, 24 May 2021 16:23:06 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 51BC7611B0; Mon, 24 May 2021 20:21:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621887698; bh=Ymn11eEpKHcjX1SZqD9F7FTWGqIxUhQLp7UIF/O1094=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uwc2iVTLCnyT6n6HdKA3DnNb0Oyzbg7bsovOWk7vRoYJnde/7zApoz4TcXvLOtxDH ir+o6/Ou0BnEBnNsNHiaXNZvF+t0HjkaDk7sChT4aEorfLk/TYebrA0ldc8dmb6g1i Tb9jHrVMBMUZU0ukEO5+uIJV/+iYqntISmCxtIw73ehiHbVYDxVXQHh0fgeXD9qVNG ePf/21Kvy47yF0MF2u+ACqWvFXgBmP/SsglHGyIWv1pv7FgNChLCxIsXQbgDIMgZ3F cfuZOqnnCCu9mhcJh/KmRfd2XTO8FRU7o5/UUFqKT/xIDtRYY8rzCpjBQZNFThqhH9 Sh5MHAlmLWqWA== Date: Mon, 24 May 2021 21:21:32 +0100 From: Will Deacon To: Qais Yousef Cc: linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Catalin Marinas , Marc Zyngier , Greg Kroah-Hartman , Peter Zijlstra , Morten Rasmussen , Suren Baghdasaryan , Quentin Perret , Tejun Heo , Li Zefan , Johannes Weiner , Ingo Molnar , Juri Lelli , Vincent Guittot , "Rafael J. Wysocki" , kernel-team@android.com Subject: Re: [PATCH v6 07/21] cpuset: Don't use the cpu_possible_mask as a last resort for cgroup v1 Message-ID: <20210524202131.GB15545@willie-the-truck> References: <20210518094725.7701-1-will@kernel.org> <20210518094725.7701-8-will@kernel.org> <20210521173934.pjcv37j63odtsrp6@e107158-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210521173934.pjcv37j63odtsrp6@e107158-lin.cambridge.arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Qais, On Fri, May 21, 2021 at 06:39:34PM +0100, Qais Yousef wrote: > On 05/18/21 10:47, Will Deacon wrote: > > diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c > > index a945504c0ae7..8c799260a4a2 100644 > > --- a/kernel/cgroup/cpuset.c > > +++ b/kernel/cgroup/cpuset.c > > @@ -3322,9 +3322,17 @@ void cpuset_cpus_allowed(struct task_struct *tsk, struct cpumask *pmask) > > > > void cpuset_cpus_allowed_fallback(struct task_struct *tsk) > > { > > + const struct cpumask *cs_mask; > > + const struct cpumask *possible_mask = task_cpu_possible_mask(tsk); > > + > > rcu_read_lock(); > > - do_set_cpus_allowed(tsk, is_in_v2_mode() ? > > - task_cs(tsk)->cpus_allowed : cpu_possible_mask); > > + cs_mask = task_cs(tsk)->cpus_allowed; > > + > > + if (!is_in_v2_mode() || !cpumask_subset(cs_mask, possible_mask)) > > + goto unlock; /* select_fallback_rq will try harder */ > > + > > + do_set_cpus_allowed(tsk, cs_mask); > > Shouldn't we take the intersection with possible_mask like we discussed before? > > https://lore.kernel.org/lkml/20201217145954.GA17881@willie-the-truck/ Yes, and that's what the '!cpumask_subset()' check is doing above. Either we use the valid subset of the cpuset mask (which is the intersection with the possible mask) or we bail if that set is empty. Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B422C2B9F7 for ; Tue, 25 May 2021 02:05:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2DE9E61209 for ; Tue, 25 May 2021 02:05:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2DE9E61209 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qxB9EfO/bBXY6ugxlgDlZeW8EPmOav2E+j2eWgvgggo=; b=ke5yXBnud6GQUS pwtTkYDq3wM4Kw/34zv8ELzRJEWAKKDjFMmoENTdQwaaxXNWY05pd6tAsPnJQ6Y9wzMMnEwLJivWT wBjkXpMFiSKSDm0m7bS+U6hVH/ZDKNd5bzw7RPGevfB0DEIsUHApoFCiLVaJUCCC/aBD5/T499qNv Y8ngXjP8iCG/nLBrxl7IhsXnquAbq0yQ5IOCh6yjiu3AqVGczxH3jLU0FCaUdE+p8ygi66wJNa8Mz M/hyGUjGQG7FGZkZYzc+PJxHOt7NTk86zYuVxZpQWXs7ud6G9VuZF8WFNNFcoYvfWPPK6jy3zV7eX T8g4JWS657UlvK5guNug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1llMOt-002q8h-Q6; Tue, 25 May 2021 02:02:33 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1llH50-001ohm-Uq for linux-arm-kernel@lists.infradead.org; Mon, 24 May 2021 20:21:40 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 51BC7611B0; Mon, 24 May 2021 20:21:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621887698; bh=Ymn11eEpKHcjX1SZqD9F7FTWGqIxUhQLp7UIF/O1094=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uwc2iVTLCnyT6n6HdKA3DnNb0Oyzbg7bsovOWk7vRoYJnde/7zApoz4TcXvLOtxDH ir+o6/Ou0BnEBnNsNHiaXNZvF+t0HjkaDk7sChT4aEorfLk/TYebrA0ldc8dmb6g1i Tb9jHrVMBMUZU0ukEO5+uIJV/+iYqntISmCxtIw73ehiHbVYDxVXQHh0fgeXD9qVNG ePf/21Kvy47yF0MF2u+ACqWvFXgBmP/SsglHGyIWv1pv7FgNChLCxIsXQbgDIMgZ3F cfuZOqnnCCu9mhcJh/KmRfd2XTO8FRU7o5/UUFqKT/xIDtRYY8rzCpjBQZNFThqhH9 Sh5MHAlmLWqWA== Date: Mon, 24 May 2021 21:21:32 +0100 From: Will Deacon To: Qais Yousef Cc: linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Catalin Marinas , Marc Zyngier , Greg Kroah-Hartman , Peter Zijlstra , Morten Rasmussen , Suren Baghdasaryan , Quentin Perret , Tejun Heo , Li Zefan , Johannes Weiner , Ingo Molnar , Juri Lelli , Vincent Guittot , "Rafael J. Wysocki" , kernel-team@android.com Subject: Re: [PATCH v6 07/21] cpuset: Don't use the cpu_possible_mask as a last resort for cgroup v1 Message-ID: <20210524202131.GB15545@willie-the-truck> References: <20210518094725.7701-1-will@kernel.org> <20210518094725.7701-8-will@kernel.org> <20210521173934.pjcv37j63odtsrp6@e107158-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210521173934.pjcv37j63odtsrp6@e107158-lin.cambridge.arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210524_132139_047672_7C2276E2 X-CRM114-Status: GOOD ( 14.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Qais, On Fri, May 21, 2021 at 06:39:34PM +0100, Qais Yousef wrote: > On 05/18/21 10:47, Will Deacon wrote: > > diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c > > index a945504c0ae7..8c799260a4a2 100644 > > --- a/kernel/cgroup/cpuset.c > > +++ b/kernel/cgroup/cpuset.c > > @@ -3322,9 +3322,17 @@ void cpuset_cpus_allowed(struct task_struct *tsk, struct cpumask *pmask) > > > > void cpuset_cpus_allowed_fallback(struct task_struct *tsk) > > { > > + const struct cpumask *cs_mask; > > + const struct cpumask *possible_mask = task_cpu_possible_mask(tsk); > > + > > rcu_read_lock(); > > - do_set_cpus_allowed(tsk, is_in_v2_mode() ? > > - task_cs(tsk)->cpus_allowed : cpu_possible_mask); > > + cs_mask = task_cs(tsk)->cpus_allowed; > > + > > + if (!is_in_v2_mode() || !cpumask_subset(cs_mask, possible_mask)) > > + goto unlock; /* select_fallback_rq will try harder */ > > + > > + do_set_cpus_allowed(tsk, cs_mask); > > Shouldn't we take the intersection with possible_mask like we discussed before? > > https://lore.kernel.org/lkml/20201217145954.GA17881@willie-the-truck/ Yes, and that's what the '!cpumask_subset()' check is doing above. Either we use the valid subset of the cpuset mask (which is the intersection with the possible mask) or we bail if that set is empty. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel