From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 810B2C2B9F7 for ; Mon, 24 May 2021 22:08:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5AF1461429 for ; Mon, 24 May 2021 22:08:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233886AbhEXWK0 (ORCPT ); Mon, 24 May 2021 18:10:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:57314 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232911AbhEXWKZ (ORCPT ); Mon, 24 May 2021 18:10:25 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 36BC261422; Mon, 24 May 2021 22:08:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621894137; bh=Oatt+cQsAj6BlgXkTD8KfGq1ZFBx4jQ6AYSxfbEIcE8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=M9V949fxxagmQMMYs34rBQzn/XL0t61mDZLFrZEZPfWSgOZC2BowxFtw/cc8Hhc+/ +A8bCwwMRtb41y6/k4MmhGJV8rJ4IrrkDnMw3Rpm03yj7hwEeH7bIebB59g2z0idQW cxOhkf3qdyRGzuF5ZLi+n6qOIGVj/qmJECJwhzjpRDhdRfY5hhSI9V6zpqPDwUyFBa sxTDJB8usl4cxZDpa9sMcdazB4B4N6Wb+IonIvZMeW8glmZUT9+2RkfnKcSd4StsR4 w2iXtFgnbFSwbdeZNwB+uK1tKBEOy6ONrCxBuXXAaoX64efh7GlbR6OBUgvJncFeg7 i24S1zqBNHAuA== Date: Mon, 24 May 2021 23:08:51 +0100 From: Will Deacon To: Qais Yousef Cc: linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Catalin Marinas , Marc Zyngier , Greg Kroah-Hartman , Peter Zijlstra , Morten Rasmussen , Suren Baghdasaryan , Quentin Perret , Tejun Heo , Li Zefan , Johannes Weiner , Ingo Molnar , Juri Lelli , Vincent Guittot , "Rafael J. Wysocki" , kernel-team@android.com Subject: Re: [PATCH v6 00/21] Add support for 32-bit tasks on asymmetric AArch32 systems Message-ID: <20210524220850.GJ15545@willie-the-truck> References: <20210518094725.7701-1-will@kernel.org> <20210521174542.2kojxgzrgdl6nqpx@e107158-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210521174542.2kojxgzrgdl6nqpx@e107158-lin.cambridge.arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 21, 2021 at 06:45:42PM +0100, Qais Yousef wrote: > Hi Will > > On 05/18/21 10:47, Will Deacon wrote: > > Hi folks, > > > > This is the long-awaited v6 of these patches which I last posted at the > > end of last year: > > > > v1: https://lore.kernel.org/r/20201027215118.27003-1-will@kernel.org > > v2: https://lore.kernel.org/r/20201109213023.15092-1-will@kernel.org > > v3: https://lore.kernel.org/r/20201113093720.21106-1-will@kernel.org > > v4: https://lore.kernel.org/r/20201124155039.13804-1-will@kernel.org > > v5: https://lore.kernel.org/r/20201208132835.6151-1-will@kernel.org > > > > There was also a nice LWN writeup in case you've forgotten what this is > > about: > > > > https://lwn.net/Articles/838339/ > > > > It's taken me a while to get a v6 of this together, partly due to > > addressing the review feedback on v5, but also because this has now seen > > testing on real hardware which threw up some surprises in suspend/resume, > > SCHED_DEADLINE and compat hwcap reporting. Thanks to Quentin for helping > > me to debug those issues. > > > > The aim of this series is to allow 32-bit ARM applications to run on > > arm64 SoCs where not all of the CPUs support the 32-bit instruction set. > > Unfortunately, such SoCs are real and will continue to be productised > > over the next few years at least. I can assure you that I'm not just > > doing this for fun. > > > > Changes in v6 include: > > > > * Save/restore the affinity mask across execve() to 32-bit and back to > > 64-bit again. > > > > * Allow 32-bit deadline tasks, but skip straight to fallback path when > > determining new affinity mask on execve(). > > > > * Fixed resume-from-suspend path when the resuming CPU is 64-bit-only > > by deferring wake-ups for 32-bit tasks until the secondary CPUs are > > back online. > > > > * Bug fixes (compat hwcaps, memory leak, cpuset fallback path). > > > > * Documentation for arm64. It's in the divisive .rst format, but please > > take a look anyway! > > > > I'm pretty happy with this now and it seems to do the right thing, > > although the new patches in this revision would certainly benefit from > > review. Series based on v5.13-rc1. > > It's late Fri and I'm off next week (I'm starting to sense an omen here, it's > the 2nd or 3rd time the post syncs with my holiday), so a bit of a rushed > review but the series looks good to me. Feel free to stick my Reviewed-by for > the series, except patch 13 where I skipped it, given the few comments I had > are addressed. Thanks, Qais. I'm planning a v7 with quite a few changes, so it's probably best if you offer your Reviewed-by on individual patches when you're happy with them rather than me adding it to code that I'm still tweaking. But thanks for the offer! Have a good week off, Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9ACAC2B9F7 for ; Tue, 25 May 2021 02:31:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 58C4D6141F for ; Tue, 25 May 2021 02:31:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 58C4D6141F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=e08zg9IQaxLmO8+7wIxQSYu+35wAIhb0jSUY0sD8B/o=; b=rkKPswX5tixUYN 9aUvsBKWY+hG4l1eoXtjEvlxDay7pj8e/wjK4ub4NCW6t0cHn2/msvZlCRHpF3e0+HDGTUoOBOqdA fqKjmZj1SdDULvjjVMEjPkgEwcqQglsL2hhUG7w87GC8pHi2SUkMsM2Fy/ZALI+LdKR/vcmaKGptK hLzsDR8cu/kUHLLj1GPFf0Q2NazayzRTFy9y7jeavboIlw9vyB8wZPqueOVgtvIE85lBFFpogTcpV m2+zCeGSvCeNzfwm6jPePbNZoQrUbhwI0rgdURn+oaMmQ+CQt7pA35G7+9QnFZkL/urG52gaG/OfC 5FHBe+c9/jExKCuQ9WFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1llMp1-002vO2-SK; Tue, 25 May 2021 02:29:32 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1llIkr-0023dC-PZ for linux-arm-kernel@lists.infradead.org; Mon, 24 May 2021 22:08:59 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 36BC261422; Mon, 24 May 2021 22:08:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621894137; bh=Oatt+cQsAj6BlgXkTD8KfGq1ZFBx4jQ6AYSxfbEIcE8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=M9V949fxxagmQMMYs34rBQzn/XL0t61mDZLFrZEZPfWSgOZC2BowxFtw/cc8Hhc+/ +A8bCwwMRtb41y6/k4MmhGJV8rJ4IrrkDnMw3Rpm03yj7hwEeH7bIebB59g2z0idQW cxOhkf3qdyRGzuF5ZLi+n6qOIGVj/qmJECJwhzjpRDhdRfY5hhSI9V6zpqPDwUyFBa sxTDJB8usl4cxZDpa9sMcdazB4B4N6Wb+IonIvZMeW8glmZUT9+2RkfnKcSd4StsR4 w2iXtFgnbFSwbdeZNwB+uK1tKBEOy6ONrCxBuXXAaoX64efh7GlbR6OBUgvJncFeg7 i24S1zqBNHAuA== Date: Mon, 24 May 2021 23:08:51 +0100 From: Will Deacon To: Qais Yousef Cc: linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Catalin Marinas , Marc Zyngier , Greg Kroah-Hartman , Peter Zijlstra , Morten Rasmussen , Suren Baghdasaryan , Quentin Perret , Tejun Heo , Li Zefan , Johannes Weiner , Ingo Molnar , Juri Lelli , Vincent Guittot , "Rafael J. Wysocki" , kernel-team@android.com Subject: Re: [PATCH v6 00/21] Add support for 32-bit tasks on asymmetric AArch32 systems Message-ID: <20210524220850.GJ15545@willie-the-truck> References: <20210518094725.7701-1-will@kernel.org> <20210521174542.2kojxgzrgdl6nqpx@e107158-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210521174542.2kojxgzrgdl6nqpx@e107158-lin.cambridge.arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210524_150857_922288_2D1B7CD2 X-CRM114-Status: GOOD ( 32.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 21, 2021 at 06:45:42PM +0100, Qais Yousef wrote: > Hi Will > > On 05/18/21 10:47, Will Deacon wrote: > > Hi folks, > > > > This is the long-awaited v6 of these patches which I last posted at the > > end of last year: > > > > v1: https://lore.kernel.org/r/20201027215118.27003-1-will@kernel.org > > v2: https://lore.kernel.org/r/20201109213023.15092-1-will@kernel.org > > v3: https://lore.kernel.org/r/20201113093720.21106-1-will@kernel.org > > v4: https://lore.kernel.org/r/20201124155039.13804-1-will@kernel.org > > v5: https://lore.kernel.org/r/20201208132835.6151-1-will@kernel.org > > > > There was also a nice LWN writeup in case you've forgotten what this is > > about: > > > > https://lwn.net/Articles/838339/ > > > > It's taken me a while to get a v6 of this together, partly due to > > addressing the review feedback on v5, but also because this has now seen > > testing on real hardware which threw up some surprises in suspend/resume, > > SCHED_DEADLINE and compat hwcap reporting. Thanks to Quentin for helping > > me to debug those issues. > > > > The aim of this series is to allow 32-bit ARM applications to run on > > arm64 SoCs where not all of the CPUs support the 32-bit instruction set. > > Unfortunately, such SoCs are real and will continue to be productised > > over the next few years at least. I can assure you that I'm not just > > doing this for fun. > > > > Changes in v6 include: > > > > * Save/restore the affinity mask across execve() to 32-bit and back to > > 64-bit again. > > > > * Allow 32-bit deadline tasks, but skip straight to fallback path when > > determining new affinity mask on execve(). > > > > * Fixed resume-from-suspend path when the resuming CPU is 64-bit-only > > by deferring wake-ups for 32-bit tasks until the secondary CPUs are > > back online. > > > > * Bug fixes (compat hwcaps, memory leak, cpuset fallback path). > > > > * Documentation for arm64. It's in the divisive .rst format, but please > > take a look anyway! > > > > I'm pretty happy with this now and it seems to do the right thing, > > although the new patches in this revision would certainly benefit from > > review. Series based on v5.13-rc1. > > It's late Fri and I'm off next week (I'm starting to sense an omen here, it's > the 2nd or 3rd time the post syncs with my holiday), so a bit of a rushed > review but the series looks good to me. Feel free to stick my Reviewed-by for > the series, except patch 13 where I skipped it, given the few comments I had > are addressed. Thanks, Qais. I'm planning a v7 with quite a few changes, so it's probably best if you offer your Reviewed-by on individual patches when you're happy with them rather than me adding it to code that I'm still tweaking. But thanks for the offer! Have a good week off, Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel