All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: "Thomas Huth" <thuth@redhat.com>,
	"Daniel P . Berrange" <berrange@redhat.com>,
	"Laszlo Ersek" <lersek@redhat.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Willian Rampazzo" <willianr@redhat.com>,
	"Bin Meng" <bmeng.cn@gmail.com>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH 9/9] gitlab-ci: Use absolute path and simplify firmware jobs
Date: Tue, 25 May 2021 10:25:56 +0200	[thread overview]
Message-ID: <20210525082556.4011380-10-f4bug@amsat.org> (raw)
In-Reply-To: <20210525082556.4011380-1-f4bug@amsat.org>

The GitLab 'add job on file changed' feature doesn't work well
with relative paths: use absolute paths instead.

Change the 'rules:' section by an 'only:' one which is easier
to read.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 .gitlab-ci.d/edk2.yml    | 11 +++++------
 .gitlab-ci.d/opensbi.yml | 11 +++++------
 2 files changed, 10 insertions(+), 12 deletions(-)

diff --git a/.gitlab-ci.d/edk2.yml b/.gitlab-ci.d/edk2.yml
index ba7280605c4..f543a10fbe2 100644
--- a/.gitlab-ci.d/edk2.yml
+++ b/.gitlab-ci.d/edk2.yml
@@ -1,10 +1,9 @@
 docker-edk2:
  stage: containers
- rules: # Only run this job when the Dockerfile is modified
- - changes:
-   - .gitlab-ci.d/edk2.yml
-   - .gitlab-ci.d/edk2/Dockerfile
-   when: always
+ only: # Only run this job when the Dockerfile is modified
+   changes:
+   - /.gitlab-ci.d/edk2.yml
+   - /.gitlab-ci.d/edk2/Dockerfile
  image: docker:19.03.1
  services:
  - docker:19.03.1-dind
@@ -28,7 +27,7 @@ build-edk2:
  needs: ['docker-edk2']
  rules: # Only run this job when ...
  - changes: # ... roms/edk2/ is modified (submodule updated)
-   - roms/edk2/*
+   - /roms/edk2/*
    when: always
  - if: '$CI_COMMIT_REF_NAME =~ /^edk2/' # or the branch/tag starts with 'edk2'
    when: always
diff --git a/.gitlab-ci.d/opensbi.yml b/.gitlab-ci.d/opensbi.yml
index f66cd1d9089..7bc96a29366 100644
--- a/.gitlab-ci.d/opensbi.yml
+++ b/.gitlab-ci.d/opensbi.yml
@@ -1,10 +1,9 @@
 docker-opensbi:
  stage: containers
- rules: # Only run this job when the Dockerfile is modified
- - changes:
-   - .gitlab-ci.d/opensbi.yml
-   - .gitlab-ci.d/opensbi/Dockerfile
-   when: always
+ only: # Only run this job when the Dockerfile is modified
+   changes:
+   - /.gitlab-ci.d/opensbi.yml
+   - /.gitlab-ci.d/opensbi/Dockerfile
  image: docker:19.03.1
  services:
  - docker:19.03.1-dind
@@ -28,7 +27,7 @@ build-opensbi:
  needs: ['docker-opensbi']
  rules: # Only run this job when ...
  - changes: # ... roms/opensbi/ is modified (submodule updated)
-   - roms/opensbi/*
+   - /roms/opensbi/*
    when: always
  - if: '$CI_COMMIT_REF_NAME =~ /^opensbi/' # or the branch/tag starts with 'opensbi'
    when: always
-- 
2.26.3



  parent reply	other threads:[~2021-05-25  8:31 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-25  8:25 [PATCH 0/9] gitlab-ci: Make mainstream CI green again Philippe Mathieu-Daudé
2021-05-25  8:25 ` [PATCH 1/9] gitlab-ci: Extract all default build/test jobs to buildtest.yml Philippe Mathieu-Daudé
2021-05-25 11:05   ` Alex Bennée
2021-05-25  8:25 ` [PATCH 2/9] gitlab-ci: Move current job set to qemu-project.yml Philippe Mathieu-Daudé
2021-05-25 11:05   ` Alex Bennée
2021-05-25  8:25 ` [PATCH 3/9] gitlab-ci: Document how forks can use different set of jobs Philippe Mathieu-Daudé
2021-05-25 11:06   ` Alex Bennée
2021-05-25 14:30   ` Willian Rampazzo
2021-05-25  8:25 ` [PATCH 4/9] gitlab-ci: Extract cross-container jobs to container-cross.yml Philippe Mathieu-Daudé
2021-05-25 11:06   ` Alex Bennée
2021-05-25 14:32   ` Willian Rampazzo
2021-05-25  8:25 ` [PATCH 5/9] gitlab-ci: explicitly reference the upstream registry Philippe Mathieu-Daudé
2021-05-25 11:10   ` Alex Bennée
2021-05-25 11:39     ` Philippe Mathieu-Daudé
2021-05-25  8:25 ` [PATCH 6/9] gitlab-ci: Split gprof-gcov job Philippe Mathieu-Daudé
2021-05-25 10:21   ` Philippe Mathieu-Daudé
2021-05-27  6:03     ` Thomas Huth
2021-05-27 13:04       ` Alex Bennée
2021-05-25 14:34   ` Willian Rampazzo
2021-06-07 11:36   ` Alex Bennée
2021-05-25  8:25 ` [PATCH 7/9] gitlab-ci: Keep Avocado reports during 1 week Philippe Mathieu-Daudé
2021-05-25 11:11   ` Alex Bennée
2021-05-25 14:35   ` Willian Rampazzo
2021-05-25  8:25 ` [PATCH 8/9] gitlab-ci: Run Avocado tests manually (except mainstream CI) Philippe Mathieu-Daudé
2021-05-25 11:25   ` Alex Bennée
2021-05-27  6:08   ` Thomas Huth
2021-05-25  8:25 ` Philippe Mathieu-Daudé [this message]
2021-05-25  8:56   ` [PATCH 9/9] gitlab-ci: Use absolute path and simplify firmware jobs Daniel P. Berrangé
2021-05-25  9:02     ` Philippe Mathieu-Daudé
2021-05-27 16:04 ` [PATCH 0/9] gitlab-ci: Make mainstream CI green again Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210525082556.4011380-10-f4bug@amsat.org \
    --to=f4bug@amsat.org \
    --cc=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=bmeng.cn@gmail.com \
    --cc=lersek@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    --cc=willianr@redhat.com \
    --subject='Re: [PATCH 9/9] gitlab-ci: Use absolute path and simplify firmware jobs' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.