From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B52972FAE for ; Tue, 25 May 2021 12:28:12 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 5CC3068AFE; Tue, 25 May 2021 14:28:09 +0200 (CEST) Date: Tue, 25 May 2021 14:28:09 +0200 From: Christoph Hellwig To: guoren@kernel.org Cc: anup.patel@wdc.com, palmerdabbelt@google.com, arnd@arndb.de, hch@lst.de, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-sunxi@lists.linux.dev, Guo Ren Subject: Re: [PATCH V3 1/2] riscv: Fixup _PAGE_GLOBAL in _PAGE_KERNEL Message-ID: <20210525122809.GA4842@lst.de> References: <1621945447-38820-1-git-send-email-guoren@kernel.org> <1621945447-38820-2-git-send-email-guoren@kernel.org> X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1621945447-38820-2-git-send-email-guoren@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) On Tue, May 25, 2021 at 12:24:06PM +0000, guoren@kernel.org wrote: > From: Guo Ren > > Kernel virtual address translation should avoid care asid or it'll s/care aisd/to use ASIDs/ ? > cause more TLB-miss and TLB-refill. Because the current asid in satp s/asid/ASID/ ? > belongs to the current process, but the target kernel va TLB entry's > asid still belongs to the previous process. > > Signed-off-by: Guo Ren > Reviewed-by: Anup Patel > Cc: Palmer Dabbelt Otherwise looks good, Reviewed-by: Christoph Hellwig From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 545D9C2B9F8 for ; Tue, 25 May 2021 12:28:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C59061409 for ; Tue, 25 May 2021 12:28:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C59061409 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u1qfabNg28QDiyuLoLdxprxxqjfRf+4CWIwgRPe5SLM=; b=V59dtSKpr4rKlH XWnDob491hoF8htlKkWI6d6HTlETXeBuz9t9s8B/1tqoFPu+dk8+25lHmUSjWG0WlGiffLTJKfsP9 xDXnNQ1i6OyNWo0bwCcXK8nOt+IZKlLyTkFj19sFZovP4G634hSqgc0jISUDxyKiwH2CF9X9bADu7 wSQKMOT0O1k0U5MJVclGUdaQWhNZccvdLTYSyM/ksGTbvxGk6NK5uKCLo2FIT/483N1e0JZTgujNp R7/pM9haOwc0qwC+3vWE/Tb881MShVQZWah1jBP8v7z9YbcPd5dGzuHezRssb/KRPwA21RgLMW03m 49t5edj5kmdpHFfYd4Xw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1llWAR-005271-Ku; Tue, 25 May 2021 12:28:15 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1llWAO-00524z-Hc for linux-riscv@lists.infradead.org; Tue, 25 May 2021 12:28:13 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 5CC3068AFE; Tue, 25 May 2021 14:28:09 +0200 (CEST) Date: Tue, 25 May 2021 14:28:09 +0200 From: Christoph Hellwig To: guoren@kernel.org Cc: anup.patel@wdc.com, palmerdabbelt@google.com, arnd@arndb.de, hch@lst.de, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-sunxi@lists.linux.dev, Guo Ren Subject: Re: [PATCH V3 1/2] riscv: Fixup _PAGE_GLOBAL in _PAGE_KERNEL Message-ID: <20210525122809.GA4842@lst.de> References: <1621945447-38820-1-git-send-email-guoren@kernel.org> <1621945447-38820-2-git-send-email-guoren@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1621945447-38820-2-git-send-email-guoren@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210525_052812_775947_F16631F5 X-CRM114-Status: GOOD ( 11.27 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Tue, May 25, 2021 at 12:24:06PM +0000, guoren@kernel.org wrote: > From: Guo Ren > > Kernel virtual address translation should avoid care asid or it'll s/care aisd/to use ASIDs/ ? > cause more TLB-miss and TLB-refill. Because the current asid in satp s/asid/ASID/ ? > belongs to the current process, but the target kernel va TLB entry's > asid still belongs to the previous process. > > Signed-off-by: Guo Ren > Reviewed-by: Anup Patel > Cc: Palmer Dabbelt Otherwise looks good, Reviewed-by: Christoph Hellwig _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv