From: Jason Gunthorpe <jgg@nvidia.com>
To: Zhu Yanjun <yanjun.zhu@intel.com>
Cc: linux-rdma@vger.kernel.org, zyjzyj2000@gmail.com,
dledford@redhat.com, leonro@nvidia.com
Subject: Re: [PATCH 1/1] Update kernel headers
Date: Tue, 25 May 2021 10:18:37 -0300 [thread overview]
Message-ID: <20210525131837.GV1002214@nvidia.com> (raw)
In-Reply-To: <20210525223222.17636-1-yanjun.zhu@intel.com>
On Tue, May 25, 2021 at 06:32:22PM -0400, Zhu Yanjun wrote:
> From: Zhu Yanjun <zyjzyj2000@gmail.com>
>
> After the patches "RDMA/rxe: Implement memory windows", the kernel headers
> are changed. This causes about 17 errors and 1 failure when running
> "run_test.py" with rxe.
> This commit will fix these errors and failures.
>
> Signed-off-by: Zhu Yanjun <zyjzyj2000@gmail.com>
> ---
> kernel-headers/rdma/rdma_user_rxe.h | 11 +++++++++++
> 1 file changed, 11 insertions(+)
Huh? Bob? You can't break the rxe uapi??
> diff --git a/kernel-headers/rdma/rdma_user_rxe.h b/kernel-headers/rdma/rdma_user_rxe.h
> index 068433e2..90ea477f 100644
> --- a/kernel-headers/rdma/rdma_user_rxe.h
> +++ b/kernel-headers/rdma/rdma_user_rxe.h
> @@ -99,7 +99,17 @@ struct rxe_send_wr {
> __u32 remote_qkey;
> __u16 pkey_index;
> } ud;
> + struct {
> + __aligned_u64 addr;
> + __aligned_u64 length;
> + __u32 mr_lkey;
> + __u32 mw_rkey;
> + __u32 rkey;
> + __u32 access;
> + __u32 flags;
> + } mw;
There is room for 4 u64's in 'reg' and this has 5, so it is a no-go
Jason
next prev parent reply other threads:[~2021-05-25 13:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 22:32 [PATCH 1/1] Update kernel headers Zhu Yanjun
2021-05-25 6:20 ` Zhu Yanjun
2021-05-25 13:18 ` Jason Gunthorpe [this message]
2021-05-25 13:56 ` Zhu Yanjun
2021-05-25 14:46 ` Zhu Yanjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210525131837.GV1002214@nvidia.com \
--to=jgg@nvidia.com \
--cc=dledford@redhat.com \
--cc=leonro@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=yanjun.zhu@intel.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.