From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABCC8C2B9F8 for ; Tue, 25 May 2021 14:46:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2EC65613F5 for ; Tue, 25 May 2021 14:46:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2EC65613F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45302 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llYKe-0005GV-7W for qemu-devel@archiver.kernel.org; Tue, 25 May 2021 10:46:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53852) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llYJz-0004V3-Hw for qemu-devel@nongnu.org; Tue, 25 May 2021 10:46:15 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:54438) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llYJv-00022o-Sh for qemu-devel@nongnu.org; Tue, 25 May 2021 10:46:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621953970; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FcikB48rV0t9McZmxrBb7hdCOZ4MSCZjQvCkguBJ5WQ=; b=GoEm/8uCcghvpQ+HRTw4cHmVRdzyy5/fL4uUbmsQ5kQ89IGOKa/t+I5EzfX2u8NU34TkQE vWf64tKjhYSSUcyVfrfe2whdZAwwr7BGpVr3si5WkE6Tk3ceFanX6UQpUI5UWspG2e6v+V da131IDM/uThsSGeioB5SIThOvs50Es= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-309-DdS6kvaENRudCc-grRz3mQ-1; Tue, 25 May 2021 10:46:07 -0400 X-MC-Unique: DdS6kvaENRudCc-grRz3mQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 38253107ACE3; Tue, 25 May 2021 14:46:06 +0000 (UTC) Received: from redhat.com (ovpn-112-191.phx2.redhat.com [10.3.112.191]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DA15F14103; Tue, 25 May 2021 14:46:05 +0000 (UTC) Date: Tue, 25 May 2021 09:46:04 -0500 From: Eric Blake To: Kit Westneat Subject: Re: [PATCH 1/3] block/blkdebug: add blocksize parameter Message-ID: <20210525144604.vcbujj6tlpjp3qr2@redhat.com> Mail-Followup-To: Kit Westneat , qemu-devel@nongnu.org, pbonzini@redhat.com References: <20210525124753.528516-1-kit.westneat@gmail.com> <20210525124753.528516-2-kit.westneat@gmail.com> MIME-Version: 1.0 In-Reply-To: <20210525124753.528516-2-kit.westneat@gmail.com> User-Agent: NeoMutt/20210205 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.371, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, May 25, 2021 at 12:47:51PM +0000, Kit Westneat wrote: > Allow users to specify the block size of the qdev for testing purposes. > > Signed-off-by: Kit Westneat > --- > block/blkdebug.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) Should this also be selectable when using QAPI to create a blkdebug device over QMP? -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org