From: "Krzysztof Wilczyński" <kw@linux.com>
To: Amey Narkhede <ameynarkhede03@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
alex.williamson@redhat.com, raphael.norwitz@nutanix.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v2 2/7] PCI: Add pcie_reset_flr to follow calling convention of other reset methods
Date: Tue, 25 May 2021 17:17:25 +0200 [thread overview]
Message-ID: <20210525151725.GA80163@rocinante.localdomain> (raw)
In-Reply-To: <20210524144814.rqgvbaawdxbdwio4@archlinux>
Hi Amey,
Sorry for late reply!
[...]
> > Similarly to my suggestion in the first patch in the series, perhaps
> > using a boolean here would be an option.
> >
> > Having said that, the following existing functions aren't doing it, so
> > for the sake of keeping things consistent it might not be the best
> > option, as per:
> >
> > static int pci_af_flr(struct pci_dev *dev, int probe)
> > int nvme_disable_and_flr(struct pci_dev *dev, int probe)
> >
> > Krzysztof
>
> All the functions which implement different types of resets including
> quirks have ...reset(struct pci_dev *dev, int probe) signature.
> Should I modify all of them?
Might not be worth it to change anything then, especially if the other
functions there already use an integer argument to enable or disable the
problem or something else. At least no in this series.
Krzysztof
next prev parent reply other threads:[~2021-05-25 15:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 23:54 [PATCH RESEND v2 0/7] Expose and manage PCI device reset Amey Narkhede
2021-05-19 23:54 ` [PATCH RESEND v2 1/7] PCI: merge slot and bus reset implementations Amey Narkhede
2021-05-20 14:54 ` Krzysztof Wilczyński
2021-05-19 23:54 ` [PATCH RESEND v2 2/7] PCI: Add pcie_reset_flr to follow calling convention of other reset methods Amey Narkhede
2021-05-20 15:05 ` Krzysztof Wilczyński
2021-05-24 14:48 ` Amey Narkhede
2021-05-25 15:17 ` Krzysztof Wilczyński [this message]
2021-05-25 16:03 ` Amey Narkhede
2021-05-19 23:54 ` [PATCH RESEND v2 3/7] PCI: Add new array for keeping track of ordering of " Amey Narkhede
2021-05-20 15:26 ` Krzysztof Wilczyński
2021-05-19 23:54 ` [PATCH RESEND v2 4/7] PCI: Remove reset_fn field from pci_dev Amey Narkhede
2021-05-19 23:54 ` [PATCH RESEND v2 5/7] PCI/sysfs: Allow userspace to query and set device reset mechanism Amey Narkhede
2021-05-20 16:37 ` Krzysztof Wilczyński
2021-05-19 23:54 ` [PATCH RESEND v2 6/7] PCI: Add support for a function level reset based on _RST method Amey Narkhede
2021-05-19 23:54 ` [PATCH RESEND v2 7/7] PCI: Enable NO_BUS_RESET quirk for Nvidia GPUs Amey Narkhede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210525151725.GA80163@rocinante.localdomain \
--to=kw@linux.com \
--cc=alex.williamson@redhat.com \
--cc=ameynarkhede03@gmail.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=raphael.norwitz@nutanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.