From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6732CC4707F for ; Tue, 25 May 2021 20:04:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 49B31613CD for ; Tue, 25 May 2021 20:04:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232031AbhEYUGO (ORCPT ); Tue, 25 May 2021 16:06:14 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:38498 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231846AbhEYUGO (ORCPT ); Tue, 25 May 2021 16:06:14 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 7F3941C0B79; Tue, 25 May 2021 22:04:42 +0200 (CEST) Date: Tue, 25 May 2021 22:04:42 +0200 From: Pavel Machek To: Roderick Colenbrander Cc: Benjamin Tissoires , marek.behun@nic.cz, linux-input , linux-leds@vger.kernel.org, "Daniel J. Ogorchock" , =?utf-8?Q?Barnab=C3=A1s_P=C5=91cze?= , Jiri Kosina Subject: Re: Naming of HID LED devices Message-ID: <20210525200442.GA1106@duo.ucw.cz> References: <20210521160455.GA10159@duo.ucw.cz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="gKMricLos+KVdGMg" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org --gKMricLos+KVdGMg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > I suggest you simply select one input device (call it primary, > > probably the one that contains the master joystick) and use its input > > number.... >=20 > It is of course an option. Though I recall in the previous discussion, > technically the LED is registered on the HID device and not on the > input device, so it is not entirely correct. There are also cases I > believe where LEDs are directly created for the HID device itself. > Based on a quick search this includes the 'hid-led' driver. Though its > naming is probably fixed as we may not want to break user space (not > sure if anyone is relying on it). There might be other plain HID > device use cases with LEDs. I'm not that familiar with HID vs. input differences. We already use inputX naming for keyboard LEDs. I'd say lets do that. Pavel --=20 http://www.livejournal.com/~pavelmachek --gKMricLos+KVdGMg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCYK1YWgAKCRAw5/Bqldv6 8n+xAJ9XGP6/9s9rUP1bnZj51+XkVHxBcACgl/TzQ1Ozo8ihtA95jZl42oIfze0= =juqZ -----END PGP SIGNATURE----- --gKMricLos+KVdGMg--