[PATCH 0/3] icecc: Silence warnings

[PATCH 0/3] icecc: Silence warnings

[Douglas]

icecc: Demote "could not get ICECC_CC" warning to note

For many components, it is perfectly correct not to have gcc or g++ in
the PATH, notably when INHIBIT_DEFAULT_DEPS is set.
We were getting a flood of warnings when icecc was enabled, eg:

    WARNING: base-files-3.0.14-r89.tait.8.6 do_configure: Cannot use icecc: could not get ICECC_CC or ICECC_CXX
    WARNING: base-files-3.0.14-r89.tait.8.6 do_compile: Cannot use icecc: could not get ICECC_CC or ICECC_CXX
    WARNING: base-files-3.0.14-r89.tait.8.6 do_install: Cannot use icecc: could not get ICECC_CC or ICECC_CXX
    WARNING: busybox-inittab-1.33.0-r0 do_configure: Cannot use icecc: could not get ICECC_CC or ICECC_CXX
    WARNING: busybox-inittab-1.33.0-r0 do_compile: Cannot use icecc: could not get ICECC_CC or ICECC_CXX
    WARNING: busybox-inittab-1.33.0-r0 do_install: Cannot use icecc: could not get ICECC_CC or ICECC_CXX
    WARNING: linux-libc-headers-3.14-r0 do_configure: Cannot use icecc: could not get ICECC_CC or ICECC_CXX
    WARNING: linux-libc-headers-3.14-r0 do_compile: Cannot use icecc: could not get ICECC_CC or ICECC_CXX
    WARNING: linux-libc-headers-3.14-r0 do_install: Cannot use icecc: could not get ICECC_CC or ICECC_CXX

Demote this message to a "NOTE".
It still appears in log.do_configure and friends:

    NOTE: Cannot use icecc: could not get ICECC_CC or ICECC_CXX

Revert "icecc: Don't use icecc when INHIBIT_DEFAULT_DEPS is set".
Although this silenced the warnings, it also turned off icecc for
gcc-cross and friends, binutils-cross, and importantly, the linux
kernel.

[YOCTO #13863]
    
Douglas Royds (3):
  Revert "icecc: Don't use icecc when INHIBIT_DEFAULT_DEPS is set"
  icecc: Demote "could not get ICECC_CC" warning to note
  icecc-create-env: Silence warning: invalid ICECC_ENV_EXEC

 meta/classes/icecc.bbclass                                  | 6 +-----
 .../icecc-create-env/icecc-create-env_0.1.bb                | 1 +
 2 files changed, 2 insertions(+), 5 deletions(-)

-- 
2.25.1

[PATCH 1/3] Revert "icecc: Don't use icecc when INHIBIT_DEFAULT_DEPS is set"

[Douglas]

Although this silenced the warnings, it also turned off icecc for
gcc-cross and friends, binutils-cross, and importantly, the linux
kernel.

This reverts commit 0315aabeff8e6483b737d0e23d6841f1394ad3c8.

[YOCTO #13863]

Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
---
 meta/classes/icecc.bbclass | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/meta/classes/icecc.bbclass b/meta/classes/icecc.bbclass
index d095305ed8..0dde960e7a 100644
--- a/meta/classes/icecc.bbclass
+++ b/meta/classes/icecc.bbclass
@@ -138,10 +138,6 @@ def use_icecc(bb,d):
     if icecc_is_cross_canadian(bb, d):
         return "no"
 
-    if d.getVar('INHIBIT_DEFAULT_DEPS', False):
-        # We don't have a compiler, so no icecc
-        return "no"
-
     pn = d.getVar('PN')
     bpn = d.getVar('BPN')
 
-- 
2.25.1

[PATCH 2/3] icecc: Demote "could not get ICECC_CC" warning to note

[Douglas]

For many components, it is perfectly correct not to have gcc or g++ in
the PATH, notably when INHIBIT_DEFAULT_DEPS is set.
We were getting a flood of warnings when icecc was enabled, eg:

    WARNING: base-files-3.0.14-r89.tait.8.6 do_configure: Cannot use icecc: could not get ICECC_CC or ICECC_CXX
    WARNING: base-files-3.0.14-r89.tait.8.6 do_compile: Cannot use icecc: could not get ICECC_CC or ICECC_CXX
    WARNING: base-files-3.0.14-r89.tait.8.6 do_install: Cannot use icecc: could not get ICECC_CC or ICECC_CXX
    WARNING: busybox-inittab-1.33.0-r0 do_configure: Cannot use icecc: could not get ICECC_CC or ICECC_CXX
    WARNING: busybox-inittab-1.33.0-r0 do_compile: Cannot use icecc: could not get ICECC_CC or ICECC_CXX
    WARNING: busybox-inittab-1.33.0-r0 do_install: Cannot use icecc: could not get ICECC_CC or ICECC_CXX
    WARNING: linux-libc-headers-3.14-r0 do_configure: Cannot use icecc: could not get ICECC_CC or ICECC_CXX
    WARNING: linux-libc-headers-3.14-r0 do_compile: Cannot use icecc: could not get ICECC_CC or ICECC_CXX
    WARNING: linux-libc-headers-3.14-r0 do_install: Cannot use icecc: could not get ICECC_CC or ICECC_CXX

Demote this message to a "NOTE".
It still appears in log.do_configure and friends:

    NOTE: Cannot use icecc: could not get ICECC_CC or ICECC_CXX

Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
---
 meta/classes/icecc.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/icecc.bbclass b/meta/classes/icecc.bbclass
index 0dde960e7a..80943fcf02 100644
--- a/meta/classes/icecc.bbclass
+++ b/meta/classes/icecc.bbclass
@@ -358,7 +358,7 @@ set_icecc_env() {
     ICECC_WHICH_AS="${@bb.utils.which(os.getenv('PATH'), 'as')}"
     if [ ! -x "${ICECC_CC}" -o ! -x "${ICECC_CXX}" ]
     then
-        bbwarn "Cannot use icecc: could not get ICECC_CC or ICECC_CXX"
+        bbnote "Cannot use icecc: could not get ICECC_CC or ICECC_CXX"
         return
     fi
 
-- 
2.25.1

[PATCH 3/3] icecc-create-env: Silence warning: invalid ICECC_ENV_EXEC

[Douglas]

Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
---
 meta/recipes-devtools/icecc-create-env/icecc-create-env_0.1.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-devtools/icecc-create-env/icecc-create-env_0.1.bb b/meta/recipes-devtools/icecc-create-env/icecc-create-env_0.1.bb
index 231c1c20ec..61b8487c7e 100644
--- a/meta/recipes-devtools/icecc-create-env/icecc-create-env_0.1.bb
+++ b/meta/recipes-devtools/icecc-create-env/icecc-create-env_0.1.bb
@@ -11,6 +11,7 @@ PR = "r2"
 
 DEPENDS = ""
 INHIBIT_DEFAULT_DEPS = "1"
+ICECC_DISABLED = "1"
 
 # This is needed, because otherwise there is dependency loop from quilt-native
 # Dependency loop #1 found:
-- 
2.25.1

Re: [OE-core] [PATCH 1/3] Revert "icecc: Don't use icecc when INHIBIT_DEFAULT_DEPS is set"

[Jose Quaresma]

Hi,

Instead of reverting we can add an exception for the packages you mentioned:
gcc-cross and friends, binutils-cross, and importantly, the linux kernel.

Douglas via lists.openembedded.org
<douglas.royds=taitradio.com@lists.openembedded.org> escreveu no dia
quarta, 26/05/2021 à(s) 01:28:
>
> Although this silenced the warnings, it also turned off icecc for
> gcc-cross and friends, binutils-cross, and importantly, the linux
> kernel.
>
> This reverts commit 0315aabeff8e6483b737d0e23d6841f1394ad3c8.
>
> [YOCTO #13863]
>
> Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
> ---
>  meta/classes/icecc.bbclass | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/meta/classes/icecc.bbclass b/meta/classes/icecc.bbclass
> index d095305ed8..0dde960e7a 100644
> --- a/meta/classes/icecc.bbclass
> +++ b/meta/classes/icecc.bbclass
> @@ -138,10 +138,6 @@ def use_icecc(bb,d):
>      if icecc_is_cross_canadian(bb, d):
>          return "no"
>
> -    if d.getVar('INHIBIT_DEFAULT_DEPS', False):
> -        # We don't have a compiler, so no icecc
> -        return "no"
> -
>      pn = d.getVar('PN')
>      bpn = d.getVar('BPN')
>
> --
> 2.25.1
>
>
> 
>


-- 
Best regards,

José Quaresma

Re: [OE-core] [PATCH 1/3] Revert "icecc: Don't use icecc when INHIBIT_DEFAULT_DEPS is set"

[Douglas]

Yes, we could, but it's quite a long list, and I'm reluctant to start
naming specific packages.

I only did the INHIBIT_DEFAULT_DEPS test (that I'm reverting here) in
the first place to silence the warnings. I think demoting these
warnings to notes is a better solution.

On Wed, 26 May 2021 at 20:52, Jose Quaresma <quaresma.jose@gmail.com> wrote:
>
> Hi,
>
> Instead of reverting we can add an exception for the packages you mentioned:
> gcc-cross and friends, binutils-cross, and importantly, the linux kernel.
>
> Douglas via lists.openembedded.org
> <douglas.royds=taitradio.com@lists.openembedded.org> escreveu no dia
> quarta, 26/05/2021 à(s) 01:28:
> >
> > Although this silenced the warnings, it also turned off icecc for
> > gcc-cross and friends, binutils-cross, and importantly, the linux
> > kernel.
> >
> > This reverts commit 0315aabeff8e6483b737d0e23d6841f1394ad3c8.
> >
> > [YOCTO #13863]
> >
> > Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
> > ---
> >  meta/classes/icecc.bbclass | 4 ----
> >  1 file changed, 4 deletions(-)
> >
> > diff --git a/meta/classes/icecc.bbclass b/meta/classes/icecc.bbclass
> > index d095305ed8..0dde960e7a 100644
> > --- a/meta/classes/icecc.bbclass
> > +++ b/meta/classes/icecc.bbclass
> > @@ -138,10 +138,6 @@ def use_icecc(bb,d):
> >      if icecc_is_cross_canadian(bb, d):
> >          return "no"
> >
> > -    if d.getVar('INHIBIT_DEFAULT_DEPS', False):
> > -        # We don't have a compiler, so no icecc
> > -        return "no"
> > -
> >      pn = d.getVar('PN')
> >      bpn = d.getVar('BPN')
> >
> > --
> > 2.25.1
> >
> >
> > 
> >
>
>
> --
> Best regards,
>
> José Quaresma

-- 
This Communication is Confidential. We only send and receive email on the
basis of the terms set out at www.taitradio.com/email_disclaimer 
<http://www.taitradio.com/email_disclaimer>

Re: [OE-core] [PATCH 1/3] Revert "icecc: Don't use icecc when INHIBIT_DEFAULT_DEPS is set"

[Jose Quaresma]

Douglas Royds <douglas.royds@taitradio.com> escreveu no dia quinta,
27/05/2021 à(s) 00:26:
>
> Yes, we could, but it's quite a long list, and I'm reluctant to start
> naming specific packages.
>
> I only did the INHIBIT_DEFAULT_DEPS test (that I'm reverting here) in
> the first place to silence the warnings. I think demoting these
> warnings to notes is a better solution.

I agree.
Probably it is more problematic to maintain, especially if the list of
packages is long.

>
> On Wed, 26 May 2021 at 20:52, Jose Quaresma <quaresma.jose@gmail.com> wrote:
> >
> > Hi,
> >
> > Instead of reverting we can add an exception for the packages you mentioned:
> > gcc-cross and friends, binutils-cross, and importantly, the linux kernel.
> >
> > Douglas via lists.openembedded.org
> > <douglas.royds=taitradio.com@lists.openembedded.org> escreveu no dia
> > quarta, 26/05/2021 à(s) 01:28:
> > >
> > > Although this silenced the warnings, it also turned off icecc for
> > > gcc-cross and friends, binutils-cross, and importantly, the linux
> > > kernel.
> > >
> > > This reverts commit 0315aabeff8e6483b737d0e23d6841f1394ad3c8.
> > >
> > > [YOCTO #13863]
> > >
> > > Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
> > > ---
> > >  meta/classes/icecc.bbclass | 4 ----
> > >  1 file changed, 4 deletions(-)
> > >
> > > diff --git a/meta/classes/icecc.bbclass b/meta/classes/icecc.bbclass
> > > index d095305ed8..0dde960e7a 100644
> > > --- a/meta/classes/icecc.bbclass
> > > +++ b/meta/classes/icecc.bbclass
> > > @@ -138,10 +138,6 @@ def use_icecc(bb,d):
> > >      if icecc_is_cross_canadian(bb, d):
> > >          return "no"
> > >
> > > -    if d.getVar('INHIBIT_DEFAULT_DEPS', False):
> > > -        # We don't have a compiler, so no icecc
> > > -        return "no"
> > > -
> > >      pn = d.getVar('PN')
> > >      bpn = d.getVar('BPN')
> > >
> > > --
> > > 2.25.1
> > >
> > >
> > > 
> > >
> >
> >
> > --
> > Best regards,
> >
> > José Quaresma
>
> --
> This Communication is Confidential. We only send and receive email on the
> basis of the terms set out at www.taitradio.com/email_disclaimer
> <http://www.taitradio.com/email_disclaimer>



-- 
Best regards,

José Quaresma