[PATCH 00/10] Rid W=1 warnings from Bus

[PATCH 00/10] Rid W=1 warnings from Bus

[Lee Jones]

This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.

Lee Jones (10):
  bus: fsl-mc: mc-io: Supply function names for 'fsl_create_mc_io()' and
    'fsl_destroy_mc_io()'
  bus: fsl-mc: mc-sys: Supply missing function names in kernel-doc
    headers
  bus: fsl-mc: fsl-mc-bus: Demote a bunch of non-conformant kernel-doc
    headers and help others
  bus: fsl-mc: dprc: Fix a couple of misspelling and formatting issues
  bus: fsl-mc: dprc-driver: Fix some missing/incorrect function
    parameter descriptions
  bus: fsl-mc: fsl-mc-allocator: Fix misspelling of 'new_mc_adev' and
    demote non-kernel-doc headers
  bus: qcom-ebi2: Fix incorrect documentation for '{slow,fast}_cfg'
  bus: fsl-mc-msi: Fix a little doc-rot pertaining to 'np' to 'fwnode'
    conversion
  bus: ti-sysc: Correct misdocumentation of 'sysc_ioremap()'
  bus: fsl-mc: mc-io: Correct misdocumentation of 'dpmcp_dev' param

 drivers/bus/fsl-mc/dprc-driver.c      |  8 +++++---
 drivers/bus/fsl-mc/dprc.c             |  4 ++--
 drivers/bus/fsl-mc/fsl-mc-allocator.c | 10 +++++-----
 drivers/bus/fsl-mc/fsl-mc-bus.c       | 19 ++++++++++---------
 drivers/bus/fsl-mc/fsl-mc-msi.c       |  2 +-
 drivers/bus/fsl-mc/mc-io.c            |  6 +++---
 drivers/bus/fsl-mc/mc-sys.c           | 19 ++++++++++---------
 drivers/bus/qcom-ebi2.c               |  4 ++--
 drivers/bus/ti-sysc.c                 |  2 +-
 9 files changed, 39 insertions(+), 35 deletions(-)

Cc: Andy Gross <agross@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: German Rivera <German.Rivera@freescale.com>
Cc: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: linux-omap@vger.kernel.org
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Stuart Yoder <stuyoder@gmail.com>
Cc: Tony Lindgren <tony@atomide.com>
-- 
2.31.1

[PATCH 01/10] bus: fsl-mc: mc-io: Supply function names for 'fsl_create_mc_io()' and 'fsl_destroy_mc_io()'

[Lee Jones]

Fixes the following W=1 kernel build warning(s):

 drivers/bus/fsl-mc/mc-io.c:53: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
 drivers/bus/fsl-mc/mc-io.c:126: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst

Cc: Stuart Yoder <stuyoder@gmail.com>
Cc: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/bus/fsl-mc/mc-io.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/bus/fsl-mc/mc-io.c b/drivers/bus/fsl-mc/mc-io.c
index 305015486b91c..9af6b05b89d6f 100644
--- a/drivers/bus/fsl-mc/mc-io.c
+++ b/drivers/bus/fsl-mc/mc-io.c
@@ -50,7 +50,7 @@ static void fsl_mc_io_unset_dpmcp(struct fsl_mc_io *mc_io)
 }
 
 /**
- * Creates an MC I/O object
+ * fsl_create_mc_io() - Creates an MC I/O object
  *
  * @dev: device to be associated with the MC I/O object
  * @mc_portal_phys_addr: physical address of the MC portal to use
@@ -123,7 +123,7 @@ int __must_check fsl_create_mc_io(struct device *dev,
 }
 
 /**
- * Destroys an MC I/O object
+ * fsl_destroy_mc_io() - Destroys an MC I/O object
  *
  * @mc_io: MC I/O object to destroy
  */
-- 
2.31.1

[PATCH 02/10] bus: fsl-mc: mc-sys: Supply missing function names in kernel-doc headers

[Lee Jones]

Fixes the following W=1 kernel build warning(s):

 drivers/bus/fsl-mc/mc-sys.c:20: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
 drivers/bus/fsl-mc/mc-sys.c:151: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
 drivers/bus/fsl-mc/mc-sys.c:197: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
 drivers/bus/fsl-mc/mc-sys.c:237: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst

Cc: Stuart Yoder <stuyoder@gmail.com>
Cc: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/bus/fsl-mc/mc-sys.c | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/drivers/bus/fsl-mc/mc-sys.c b/drivers/bus/fsl-mc/mc-sys.c
index b291b35e3884b..f2052cd0a0517 100644
--- a/drivers/bus/fsl-mc/mc-sys.c
+++ b/drivers/bus/fsl-mc/mc-sys.c
@@ -16,7 +16,7 @@
 
 #include "fsl-mc-private.h"
 
-/**
+/*
  * Timeout in milliseconds to wait for the completion of an MC command
  */
 #define MC_CMD_COMPLETION_TIMEOUT_MS	500
@@ -148,9 +148,10 @@ static inline enum mc_cmd_status mc_read_response(struct fsl_mc_command __iomem
 }
 
 /**
- * Waits for the completion of an MC command doing preemptible polling.
- * uslepp_range() is called between polling iterations.
- *
+ * mc_polling_wait_preemptible() - Waits for the completion of an MC
+ *                                 command doing preemptible polling.
+ *                                 uslepp_range() is called between
+ *                                 polling iterations.
  * @mc_io: MC I/O object to be used
  * @cmd: command buffer to receive MC response
  * @mc_status: MC command completion status
@@ -194,9 +195,9 @@ static int mc_polling_wait_preemptible(struct fsl_mc_io *mc_io,
 }
 
 /**
- * Waits for the completion of an MC command doing atomic polling.
- * udelay() is called between polling iterations.
- *
+ * mc_polling_wait_atomic() - Waits for the completion of an MC command
+ *                            doing atomic polling. udelay() is called
+ *                            between polling iterations.
  * @mc_io: MC I/O object to be used
  * @cmd: command buffer to receive MC response
  * @mc_status: MC command completion status
@@ -234,8 +235,8 @@ static int mc_polling_wait_atomic(struct fsl_mc_io *mc_io,
 }
 
 /**
- * Sends a command to the MC device using the given MC I/O object
- *
+ * mc_send_command() - Sends a command to the MC device using the given
+ *                     MC I/O object
  * @mc_io: MC I/O object to be used
  * @cmd: command to be sent
  *
-- 
2.31.1

[PATCH 03/10] bus: fsl-mc: fsl-mc-bus: Demote a bunch of non-conformant kernel-doc headers and help others

[Lee Jones]

Fixes the following W=1 kernel build warning(s):

 drivers/bus/fsl-mc/fsl-mc-bus.c:30: warning: expecting prototype for Default DMA mask for devices on a fsl(). Prototype was for FSL_MC_DEFAULT_DMA_MASK() instead
 drivers/bus/fsl-mc/fsl-mc-bus.c:45: warning: Function parameter or member 'fsl_mc_regs' not described in 'fsl_mc'
 drivers/bus/fsl-mc/fsl-mc-bus.c:124: warning: Function parameter or member 'dev' not described in 'fsl_mc_bus_uevent'
 drivers/bus/fsl-mc/fsl-mc-bus.c:124: warning: Function parameter or member 'env' not described in 'fsl_mc_bus_uevent'
 drivers/bus/fsl-mc/fsl-mc-bus.c:480: warning: Function parameter or member 'mc_driver' not described in '__fsl_mc_driver_register'
 drivers/bus/fsl-mc/fsl-mc-bus.c:480: warning: Function parameter or member 'owner' not described in '__fsl_mc_driver_register'
 drivers/bus/fsl-mc/fsl-mc-bus.c:511: warning: Function parameter or member 'mc_driver' not described in 'fsl_mc_driver_unregister'
 drivers/bus/fsl-mc/fsl-mc-bus.c:571: warning: Function parameter or member 'dev' not described in 'fsl_mc_get_root_dprc'
 drivers/bus/fsl-mc/fsl-mc-bus.c:571: warning: Function parameter or member 'root_dprc_dev' not described in 'fsl_mc_get_root_dprc'
 drivers/bus/fsl-mc/fsl-mc-bus.c:739: warning: Function parameter or member 'dev' not described in 'fsl_mc_is_root_dprc'
 drivers/bus/fsl-mc/fsl-mc-bus.c:767: warning: Function parameter or member 'obj_desc' not described in 'fsl_mc_device_add'
 drivers/bus/fsl-mc/fsl-mc-bus.c:767: warning: Function parameter or member 'mc_io' not described in 'fsl_mc_device_add'
 drivers/bus/fsl-mc/fsl-mc-bus.c:767: warning: Function parameter or member 'parent_dev' not described in 'fsl_mc_device_add'
 drivers/bus/fsl-mc/fsl-mc-bus.c:767: warning: Function parameter or member 'new_mc_dev' not described in 'fsl_mc_device_add'
 drivers/bus/fsl-mc/fsl-mc-bus.c:767: warning: expecting prototype for Add a newly discovered fsl(). Prototype was for fsl_mc_device_add() instead
 drivers/bus/fsl-mc/fsl-mc-bus.c:1066: warning: Function parameter or member 'pdev' not described in 'fsl_mc_bus_probe'
 drivers/bus/fsl-mc/fsl-mc-bus.c:1190: warning: Function parameter or member 'pdev' not described in 'fsl_mc_bus_remove'

Cc: Stuart Yoder <stuyoder@gmail.com>
Cc: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Cc: German Rivera <German.Rivera@freescale.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/bus/fsl-mc/fsl-mc-bus.c | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc-bus.c
index 380ad1fdb7456..09c8ab5e0959e 100644
--- a/drivers/bus/fsl-mc/fsl-mc-bus.c
+++ b/drivers/bus/fsl-mc/fsl-mc-bus.c
@@ -24,7 +24,7 @@
 
 #include "fsl-mc-private.h"
 
-/**
+/*
  * Default DMA mask for devices on a fsl-mc bus
  */
 #define FSL_MC_DEFAULT_DMA_MASK	(~0ULL)
@@ -36,6 +36,7 @@ static struct fsl_mc_version mc_version;
  * @root_mc_bus_dev: fsl-mc device representing the root DPRC
  * @num_translation_ranges: number of entries in addr_translation_ranges
  * @translation_ranges: array of bus to system address translation ranges
+ * @fsl_mc_regs: base address of register bank
  */
 struct fsl_mc {
 	struct fsl_mc_device *root_mc_bus_dev;
@@ -117,7 +118,7 @@ static int fsl_mc_bus_match(struct device *dev, struct device_driver *drv)
 	return found;
 }
 
-/**
+/*
  * fsl_mc_bus_uevent - callback invoked when a device is added
  */
 static int fsl_mc_bus_uevent(struct device *dev, struct kobj_uevent_env *env)
@@ -467,7 +468,7 @@ static void fsl_mc_driver_shutdown(struct device *dev)
 	mc_drv->shutdown(mc_dev);
 }
 
-/**
+/*
  * __fsl_mc_driver_register - registers a child device driver with the
  * MC bus
  *
@@ -503,7 +504,7 @@ int __fsl_mc_driver_register(struct fsl_mc_driver *mc_driver,
 }
 EXPORT_SYMBOL_GPL(__fsl_mc_driver_register);
 
-/**
+/*
  * fsl_mc_driver_unregister - unregisters a device driver from the
  * MC bus
  */
@@ -563,7 +564,7 @@ struct fsl_mc_version *fsl_mc_get_version(void)
 }
 EXPORT_SYMBOL_GPL(fsl_mc_get_version);
 
-/**
+/*
  * fsl_mc_get_root_dprc - function to traverse to the root dprc
  */
 void fsl_mc_get_root_dprc(struct device *dev,
@@ -732,7 +733,7 @@ static int fsl_mc_device_get_mmio_regions(struct fsl_mc_device *mc_dev,
 	return error;
 }
 
-/**
+/*
  * fsl_mc_is_root_dprc - function to check if a given device is a root dprc
  */
 bool fsl_mc_is_root_dprc(struct device *dev)
@@ -757,7 +758,7 @@ static void fsl_mc_device_release(struct device *dev)
 		kfree(mc_dev);
 }
 
-/**
+/*
  * Add a newly discovered fsl-mc device to be visible in Linux
  */
 int fsl_mc_device_add(struct fsl_mc_obj_desc *obj_desc,
@@ -1058,7 +1059,7 @@ static int get_mc_addr_translation_ranges(struct device *dev,
 	return 0;
 }
 
-/**
+/*
  * fsl_mc_bus_probe - callback invoked when the root MC bus is being
  * added
  */
@@ -1182,7 +1183,7 @@ static int fsl_mc_bus_probe(struct platform_device *pdev)
 	return error;
 }
 
-/**
+/*
  * fsl_mc_bus_remove - callback invoked when the root MC bus is being
  * removed
  */
-- 
2.31.1

[PATCH 04/10] bus: fsl-mc: dprc: Fix a couple of misspelling and formatting issues

[Lee Jones]

Fixes the following W=1 kernel build warning(s):

 drivers/bus/fsl-mc/dprc.c:345: warning: Function parameter or member 'attr' not described in 'dprc_get_attributes'
 drivers/bus/fsl-mc/dprc.c:521: warning: Function parameter or member 'obj_type' not described in 'dprc_get_obj_region'

Cc: Stuart Yoder <stuyoder@gmail.com>
Cc: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/bus/fsl-mc/dprc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/bus/fsl-mc/dprc.c b/drivers/bus/fsl-mc/dprc.c
index 27b0a01bad9b0..d129338b8bc08 100644
--- a/drivers/bus/fsl-mc/dprc.c
+++ b/drivers/bus/fsl-mc/dprc.c
@@ -334,7 +334,7 @@ int dprc_clear_irq_status(struct fsl_mc_io *mc_io,
  * @mc_io:	Pointer to MC portal's I/O object
  * @cmd_flags:	Command flags; one or more of 'MC_CMD_FLAG_'
  * @token:	Token of DPRC object
- * @attributes	Returned container attributes
+ * @attr:	Returned container attributes
  *
  * Return:     '0' on Success; Error code otherwise.
  */
@@ -504,7 +504,7 @@ EXPORT_SYMBOL_GPL(dprc_set_obj_irq);
  * @mc_io:	Pointer to MC portal's I/O object
  * @cmd_flags:	Command flags; one or more of 'MC_CMD_FLAG_'
  * @token:	Token of DPRC object
- * @obj_type;	Object type as returned in dprc_get_obj()
+ * @obj_type:	Object type as returned in dprc_get_obj()
  * @obj_id:	Unique object instance as returned in dprc_get_obj()
  * @region_index: The specific region to query
  * @region_desc:  Returns the requested region descriptor
-- 
2.31.1

[PATCH 05/10] bus: fsl-mc: dprc-driver: Fix some missing/incorrect function parameter descriptions

[Lee Jones]

Fixes the following W=1 kernel build warning(s):

 drivers/bus/fsl-mc/dprc-driver.c:360: warning: Function parameter or member 'alloc_interrupts' not described in 'dprc_scan_container'
 drivers/bus/fsl-mc/dprc-driver.c:383: warning: Function parameter or member 'irq_num' not described in 'dprc_irq0_handler'
 drivers/bus/fsl-mc/dprc-driver.c:383: warning: Excess function parameter 'irq' description in 'dprc_irq0_handler'
 drivers/bus/fsl-mc/dprc-driver.c:394: warning: Function parameter or member 'irq_num' not described in 'dprc_irq0_handler_thread'
 drivers/bus/fsl-mc/dprc-driver.c:394: warning: Excess function parameter 'irq' description in 'dprc_irq0_handler_thread'

Cc: Stuart Yoder <stuyoder@gmail.com>
Cc: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Cc: German Rivera <German.Rivera@freescale.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/bus/fsl-mc/dprc-driver.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/bus/fsl-mc/dprc-driver.c b/drivers/bus/fsl-mc/dprc-driver.c
index e3e2ae41c22b3..315e830b6ecda 100644
--- a/drivers/bus/fsl-mc/dprc-driver.c
+++ b/drivers/bus/fsl-mc/dprc-driver.c
@@ -350,7 +350,8 @@ int dprc_scan_objects(struct fsl_mc_device *mc_bus_dev,
  * dprc_scan_container - Scans a physical DPRC and synchronizes Linux bus state
  *
  * @mc_bus_dev: pointer to the fsl-mc device that represents a DPRC object
- *
+ * @alloc_interrupts: if true the function allocates the interrupt pool,
+ *                    otherwise the interrupt allocation is delayed
  * Scans the physical DPRC and synchronizes the state of the Linux
  * bus driver with the actual state of the MC by adding and removing
  * devices as appropriate.
@@ -373,10 +374,11 @@ int dprc_scan_container(struct fsl_mc_device *mc_bus_dev,
 	return error;
 }
 EXPORT_SYMBOL_GPL(dprc_scan_container);
+
 /**
  * dprc_irq0_handler - Regular ISR for DPRC interrupt 0
  *
- * @irq: IRQ number of the interrupt being handled
+ * @irq_num: IRQ number of the interrupt being handled
  * @arg: Pointer to device structure
  */
 static irqreturn_t dprc_irq0_handler(int irq_num, void *arg)
@@ -387,7 +389,7 @@ static irqreturn_t dprc_irq0_handler(int irq_num, void *arg)
 /**
  * dprc_irq0_handler_thread - Handler thread function for DPRC interrupt 0
  *
- * @irq: IRQ number of the interrupt being handled
+ * @irq_num: IRQ number of the interrupt being handled
  * @arg: Pointer to device structure
  */
 static irqreturn_t dprc_irq0_handler_thread(int irq_num, void *arg)
-- 
2.31.1

[PATCH 06/10] bus: fsl-mc: fsl-mc-allocator: Fix misspelling of 'new_mc_adev' and demote non-kernel-doc headers

[Lee Jones]

Fixes the following W=1 kernel build warning(s):

 drivers/bus/fsl-mc/fsl-mc-allocator.c:271: warning: Function parameter or member 'new_mc_adev' not described in 'fsl_mc_object_allocate'
 drivers/bus/fsl-mc/fsl-mc-allocator.c:271: warning: Excess function parameter 'new_mc_dev' description in 'fsl_mc_object_allocate'
 drivers/bus/fsl-mc/fsl-mc-allocator.c:417: warning: Function parameter or member 'mc_bus_dev' not described in 'fsl_mc_cleanup_irq_pool'
 drivers/bus/fsl-mc/fsl-mc-allocator.c:417: warning: expecting prototype for Teardown the interrupt pool associated with an fsl(). Prototype was for fsl_mc_cleanup_irq_pool() instead
 drivers/bus/fsl-mc/fsl-mc-allocator.c:443: warning: Function parameter or member 'mc_dev' not described in 'fsl_mc_allocate_irqs'
 drivers/bus/fsl-mc/fsl-mc-allocator.c:443: warning: expecting prototype for Allocate the IRQs required by a given fsl(). Prototype was for fsl_mc_allocate_irqs() instead
 drivers/bus/fsl-mc/fsl-mc-allocator.c:586: warning: Function parameter or member 'mc_dev' not described in 'fsl_mc_allocator_probe'
 drivers/bus/fsl-mc/fsl-mc-allocator.c:618: warning: Function parameter or member 'mc_dev' not described in 'fsl_mc_allocator_remove'

Cc: Stuart Yoder <stuyoder@gmail.com>
Cc: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/bus/fsl-mc/fsl-mc-allocator.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/bus/fsl-mc/fsl-mc-allocator.c b/drivers/bus/fsl-mc/fsl-mc-allocator.c
index 2d7c764bb7dcf..6c513556911e3 100644
--- a/drivers/bus/fsl-mc/fsl-mc-allocator.c
+++ b/drivers/bus/fsl-mc/fsl-mc-allocator.c
@@ -254,7 +254,7 @@ EXPORT_SYMBOL_GPL(fsl_mc_resource_free);
  * @mc_dev: fsl-mc device which is used in conjunction with the
  * allocated object
  * @pool_type: pool type
- * @new_mc_dev: pointer to area where the pointer to the allocated device
+ * @new_mc_adev: pointer to area where the pointer to the allocated device
  * is to be returned
  *
  * Allocatable objects are always used in conjunction with some functional
@@ -409,7 +409,7 @@ int fsl_mc_populate_irq_pool(struct fsl_mc_device *mc_bus_dev,
 }
 EXPORT_SYMBOL_GPL(fsl_mc_populate_irq_pool);
 
-/**
+/*
  * Teardown the interrupt pool associated with an fsl-mc bus.
  * It frees the IRQs that were allocated to the pool, back to the GIC-ITS.
  */
@@ -436,7 +436,7 @@ void fsl_mc_cleanup_irq_pool(struct fsl_mc_device *mc_bus_dev)
 }
 EXPORT_SYMBOL_GPL(fsl_mc_cleanup_irq_pool);
 
-/**
+/*
  * Allocate the IRQs required by a given fsl-mc device.
  */
 int __must_check fsl_mc_allocate_irqs(struct fsl_mc_device *mc_dev)
@@ -578,7 +578,7 @@ void fsl_mc_cleanup_all_resource_pools(struct fsl_mc_device *mc_bus_dev)
 		fsl_mc_cleanup_resource_pool(mc_bus_dev, pool_type);
 }
 
-/**
+/*
  * fsl_mc_allocator_probe - callback invoked when an allocatable device is
  * being added to the system
  */
@@ -610,7 +610,7 @@ static int fsl_mc_allocator_probe(struct fsl_mc_device *mc_dev)
 	return 0;
 }
 
-/**
+/*
  * fsl_mc_allocator_remove - callback invoked when an allocatable device is
  * being removed from the system
  */
-- 
2.31.1

[PATCH 07/10] bus: qcom-ebi2: Fix incorrect documentation for '{slow,fast}_cfg'

[Lee Jones]

Fixes the following W=1 kernel build warning(s):

 drivers/bus/qcom-ebi2.c:112: warning: Function parameter or member 'slow_cfg' not described in 'cs_data'
 drivers/bus/qcom-ebi2.c:112: warning: Function parameter or member 'fast_cfg' not described in 'cs_data'

Cc: Andy Gross <agross@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-msm@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/bus/qcom-ebi2.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/bus/qcom-ebi2.c b/drivers/bus/qcom-ebi2.c
index 0b8f53a688b8a..663c827492223 100644
--- a/drivers/bus/qcom-ebi2.c
+++ b/drivers/bus/qcom-ebi2.c
@@ -102,8 +102,8 @@
 /**
  * struct cs_data - struct with info on a chipselect setting
  * @enable_mask: mask to enable the chipselect in the EBI2 config
- * @slow_cfg0: offset to XMEMC slow CS config
- * @fast_cfg1: offset to XMEMC fast CS config
+ * @slow_cfg: offset to XMEMC slow CS config
+ * @fast_cfg: offset to XMEMC fast CS config
  */
 struct cs_data {
 	u32 enable_mask;
-- 
2.31.1

Re: [PATCH 07/10] bus: qcom-ebi2: Fix incorrect documentation for '{slow,fast}_cfg'

[Linus Walleij]

On Wed, May 26, 2021 at 10:10 AM Lee Jones <lee.jones@linaro.org> wrote:

> Fixes the following W=1 kernel build warning(s):
>
>  drivers/bus/qcom-ebi2.c:112: warning: Function parameter or member 'slow_cfg' not described in 'cs_data'
>  drivers/bus/qcom-ebi2.c:112: warning: Function parameter or member 'fast_cfg' not described in 'cs_data'
>
> Cc: Andy Gross <agross@kernel.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-arm-msm@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org

Thanks Lee!

Yours,
Linus Walleij

Re: [PATCH 07/10] bus: qcom-ebi2: Fix incorrect documentation for '{slow,fast}_cfg'

[Bjorn Andersson]

On Wed 26 May 03:10 CDT 2021, Lee Jones wrote:

> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/bus/qcom-ebi2.c:112: warning: Function parameter or member 'slow_cfg' not described in 'cs_data'
>  drivers/bus/qcom-ebi2.c:112: warning: Function parameter or member 'fast_cfg' not described in 'cs_data'
> 
> Cc: Andy Gross <agross@kernel.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-arm-msm@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Thanks Lee, I've picked this up in the qcom tree.

Regards,
Bjorn

> ---
>  drivers/bus/qcom-ebi2.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/bus/qcom-ebi2.c b/drivers/bus/qcom-ebi2.c
> index 0b8f53a688b8a..663c827492223 100644
> --- a/drivers/bus/qcom-ebi2.c
> +++ b/drivers/bus/qcom-ebi2.c
> @@ -102,8 +102,8 @@
>  /**
>   * struct cs_data - struct with info on a chipselect setting
>   * @enable_mask: mask to enable the chipselect in the EBI2 config
> - * @slow_cfg0: offset to XMEMC slow CS config
> - * @fast_cfg1: offset to XMEMC fast CS config
> + * @slow_cfg: offset to XMEMC slow CS config
> + * @fast_cfg: offset to XMEMC fast CS config
>   */
>  struct cs_data {
>  	u32 enable_mask;
> -- 
> 2.31.1
> 

[PATCH 08/10] bus: fsl-mc-msi: Fix a little doc-rot pertaining to 'np' to 'fwnode' conversion

[Lee Jones]

Fixes the following W=1 kernel build warning(s):

 drivers/bus/fsl-mc/fsl-mc-msi.c:164: warning: Function parameter or member 'fwnode' not described in 'fsl_mc_msi_create_irq_domain'
 drivers/bus/fsl-mc/fsl-mc-msi.c:164: warning: Excess function parameter 'np' description in 'fsl_mc_msi_create_irq_domain'

Cc: Stuart Yoder <stuyoder@gmail.com>
Cc: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Cc: German Rivera <German.Rivera@freescale.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/bus/fsl-mc/fsl-mc-msi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bus/fsl-mc/fsl-mc-msi.c b/drivers/bus/fsl-mc/fsl-mc-msi.c
index 8edadf05cbb76..cf974870ba55d 100644
--- a/drivers/bus/fsl-mc/fsl-mc-msi.c
+++ b/drivers/bus/fsl-mc/fsl-mc-msi.c
@@ -148,7 +148,7 @@ static void fsl_mc_msi_update_chip_ops(struct msi_domain_info *info)
 
 /**
  * fsl_mc_msi_create_irq_domain - Create a fsl-mc MSI interrupt domain
- * @np:		Optional device-tree node of the interrupt controller
+ * @fwnode:	Optional firmware node of the interrupt controller
  * @info:	MSI domain info
  * @parent:	Parent irq domain
  *
-- 
2.31.1

[PATCH 09/10] bus: ti-sysc: Correct misdocumentation of 'sysc_ioremap()'

[Lee Jones]

Fixes the following W=1 kernel build warning(s):

 drivers/bus/ti-sysc.c:867: warning: expecting prototype for syc_ioremap(). Prototype was for sysc_ioremap() instead

Cc: Tony Lindgren <tony@atomide.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-omap@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/bus/ti-sysc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
index 5fae60f8c1355..0d4a1104b44ad 100644
--- a/drivers/bus/ti-sysc.c
+++ b/drivers/bus/ti-sysc.c
@@ -853,7 +853,7 @@ static int sysc_check_registers(struct sysc *ddata)
 }
 
 /**
- * syc_ioremap - ioremap register space for the interconnect target module
+ * sysc_ioremap - ioremap register space for the interconnect target module
  * @ddata: device driver data
  *
  * Note that the interconnect target module registers can be anywhere
-- 
2.31.1

Re: [PATCH 09/10] bus: ti-sysc: Correct misdocumentation of 'sysc_ioremap()'

[Tony Lindgren]

* Lee Jones <lee.jones@linaro.org> [210526 11:11]:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/bus/ti-sysc.c:867: warning: expecting prototype for syc_ioremap(). Prototype was for sysc_ioremap() instead

Picking this patch into omap-for-v5.14/ti-sysc thanks.

Lee and Philipp, if you already have this patch queued elsewhere, please
let me know and I can drop it.

Regards,

Tony

[PATCH 10/10] bus: fsl-mc: mc-io: Correct misdocumentation of 'dpmcp_dev' param

[Lee Jones]

Fixes the following W=1 kernel build warning(s):

 drivers/bus/fsl-mc/mc-io.c:70: warning: Function parameter or member 'dpmcp_dev' not described in 'fsl_create_mc_io'

Cc: Stuart Yoder <stuyoder@gmail.com>
Cc: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/bus/fsl-mc/mc-io.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bus/fsl-mc/mc-io.c b/drivers/bus/fsl-mc/mc-io.c
index 9af6b05b89d6f..95b10a6cf3073 100644
--- a/drivers/bus/fsl-mc/mc-io.c
+++ b/drivers/bus/fsl-mc/mc-io.c
@@ -55,7 +55,7 @@ static void fsl_mc_io_unset_dpmcp(struct fsl_mc_io *mc_io)
  * @dev: device to be associated with the MC I/O object
  * @mc_portal_phys_addr: physical address of the MC portal to use
  * @mc_portal_size: size in bytes of the MC portal
- * @dpmcp-dev: Pointer to the DPMCP object associated with this MC I/O
+ * @dpmcp_dev: Pointer to the DPMCP object associated with this MC I/O
  * object or NULL if none.
  * @flags: flags for the new MC I/O object
  * @new_mc_io: Area to return pointer to newly created MC I/O object
-- 
2.31.1

Re: [PATCH 00/10] Rid W=1 warnings from Bus

[Laurentiu Tudor]

Hi Lee,

On 5/26/2021 11:10 AM, Lee Jones wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
> 
> Lee Jones (10):
>   bus: fsl-mc: mc-io: Supply function names for 'fsl_create_mc_io()' and
>     'fsl_destroy_mc_io()'
>   bus: fsl-mc: mc-sys: Supply missing function names in kernel-doc
>     headers
>   bus: fsl-mc: fsl-mc-bus: Demote a bunch of non-conformant kernel-doc
>     headers and help others
>   bus: fsl-mc: dprc: Fix a couple of misspelling and formatting issues
>   bus: fsl-mc: dprc-driver: Fix some missing/incorrect function
>     parameter descriptions
>   bus: fsl-mc: fsl-mc-allocator: Fix misspelling of 'new_mc_adev' and
>     demote non-kernel-doc headers
>   bus: qcom-ebi2: Fix incorrect documentation for '{slow,fast}_cfg'
>   bus: fsl-mc-msi: Fix a little doc-rot pertaining to 'np' to 'fwnode'
>     conversion
>   bus: ti-sysc: Correct misdocumentation of 'sysc_ioremap()'
>   bus: fsl-mc: mc-io: Correct misdocumentation of 'dpmcp_dev' param
> 
>  drivers/bus/fsl-mc/dprc-driver.c      |  8 +++++---
>  drivers/bus/fsl-mc/dprc.c             |  4 ++--
>  drivers/bus/fsl-mc/fsl-mc-allocator.c | 10 +++++-----
>  drivers/bus/fsl-mc/fsl-mc-bus.c       | 19 ++++++++++---------
>  drivers/bus/fsl-mc/fsl-mc-msi.c       |  2 +-
>  drivers/bus/fsl-mc/mc-io.c            |  6 +++---
>  drivers/bus/fsl-mc/mc-sys.c           | 19 ++++++++++---------

Thanks for this. For drivers/bus/fsl-mc/*:

Reviewed-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>

---
Best Regards, Laurentiu

Re: [PATCH 00/10] Rid W=1 warnings from Bus

[Lee Jones]

On Wed, 26 May 2021, Laurentiu Tudor wrote:

> Hi Lee,
> 
> On 5/26/2021 11:10 AM, Lee Jones wrote:
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> > 
> > Lee Jones (10):
> >   bus: fsl-mc: mc-io: Supply function names for 'fsl_create_mc_io()' and
> >     'fsl_destroy_mc_io()'
> >   bus: fsl-mc: mc-sys: Supply missing function names in kernel-doc
> >     headers
> >   bus: fsl-mc: fsl-mc-bus: Demote a bunch of non-conformant kernel-doc
> >     headers and help others
> >   bus: fsl-mc: dprc: Fix a couple of misspelling and formatting issues
> >   bus: fsl-mc: dprc-driver: Fix some missing/incorrect function
> >     parameter descriptions
> >   bus: fsl-mc: fsl-mc-allocator: Fix misspelling of 'new_mc_adev' and
> >     demote non-kernel-doc headers
> >   bus: qcom-ebi2: Fix incorrect documentation for '{slow,fast}_cfg'
> >   bus: fsl-mc-msi: Fix a little doc-rot pertaining to 'np' to 'fwnode'
> >     conversion
> >   bus: ti-sysc: Correct misdocumentation of 'sysc_ioremap()'
> >   bus: fsl-mc: mc-io: Correct misdocumentation of 'dpmcp_dev' param
> > 
> >  drivers/bus/fsl-mc/dprc-driver.c      |  8 +++++---
> >  drivers/bus/fsl-mc/dprc.c             |  4 ++--
> >  drivers/bus/fsl-mc/fsl-mc-allocator.c | 10 +++++-----
> >  drivers/bus/fsl-mc/fsl-mc-bus.c       | 19 ++++++++++---------
> >  drivers/bus/fsl-mc/fsl-mc-msi.c       |  2 +-
> >  drivers/bus/fsl-mc/mc-io.c            |  6 +++---
> >  drivers/bus/fsl-mc/mc-sys.c           | 19 ++++++++++---------
> 
> Thanks for this. For drivers/bus/fsl-mc/*:
> 
> Reviewed-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>

Any idea who will take the 'fsl-mc' patches please?

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 00/10] Rid W=1 warnings from Bus

[Laurentiu Tudor]

On 6/17/2021 12:49 PM, Lee Jones wrote:
> On Wed, 26 May 2021, Laurentiu Tudor wrote:
> 
>> Hi Lee,
>>
>> On 5/26/2021 11:10 AM, Lee Jones wrote:
>>> This set is part of a larger effort attempting to clean-up W=1
>>> kernel builds, which are currently overwhelmingly riddled with
>>> niggly little warnings.
>>>
>>> Lee Jones (10):
>>>   bus: fsl-mc: mc-io: Supply function names for 'fsl_create_mc_io()' and
>>>     'fsl_destroy_mc_io()'
>>>   bus: fsl-mc: mc-sys: Supply missing function names in kernel-doc
>>>     headers
>>>   bus: fsl-mc: fsl-mc-bus: Demote a bunch of non-conformant kernel-doc
>>>     headers and help others
>>>   bus: fsl-mc: dprc: Fix a couple of misspelling and formatting issues
>>>   bus: fsl-mc: dprc-driver: Fix some missing/incorrect function
>>>     parameter descriptions
>>>   bus: fsl-mc: fsl-mc-allocator: Fix misspelling of 'new_mc_adev' and
>>>     demote non-kernel-doc headers
>>>   bus: qcom-ebi2: Fix incorrect documentation for '{slow,fast}_cfg'
>>>   bus: fsl-mc-msi: Fix a little doc-rot pertaining to 'np' to 'fwnode'
>>>     conversion
>>>   bus: ti-sysc: Correct misdocumentation of 'sysc_ioremap()'
>>>   bus: fsl-mc: mc-io: Correct misdocumentation of 'dpmcp_dev' param
>>>
>>>  drivers/bus/fsl-mc/dprc-driver.c      |  8 +++++---
>>>  drivers/bus/fsl-mc/dprc.c             |  4 ++--
>>>  drivers/bus/fsl-mc/fsl-mc-allocator.c | 10 +++++-----
>>>  drivers/bus/fsl-mc/fsl-mc-bus.c       | 19 ++++++++++---------
>>>  drivers/bus/fsl-mc/fsl-mc-msi.c       |  2 +-
>>>  drivers/bus/fsl-mc/mc-io.c            |  6 +++---
>>>  drivers/bus/fsl-mc/mc-sys.c           | 19 ++++++++++---------
>>
>> Thanks for this. For drivers/bus/fsl-mc/*:
>>
>> Reviewed-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> 
> Any idea who will take the 'fsl-mc' patches please?
> 

Usually GregKH (added in the thread) picks them up through his char-misc
tree.

---
Best Regards, Laurentiu

Re: [PATCH 00/10] Rid W=1 warnings from Bus

[Greg KH]

On Thu, Jun 17, 2021 at 01:11:39PM +0300, Laurentiu Tudor wrote:
> 
> 
> On 6/17/2021 12:49 PM, Lee Jones wrote:
> > On Wed, 26 May 2021, Laurentiu Tudor wrote:
> > 
> >> Hi Lee,
> >>
> >> On 5/26/2021 11:10 AM, Lee Jones wrote:
> >>> This set is part of a larger effort attempting to clean-up W=1
> >>> kernel builds, which are currently overwhelmingly riddled with
> >>> niggly little warnings.
> >>>
> >>> Lee Jones (10):
> >>>   bus: fsl-mc: mc-io: Supply function names for 'fsl_create_mc_io()' and
> >>>     'fsl_destroy_mc_io()'
> >>>   bus: fsl-mc: mc-sys: Supply missing function names in kernel-doc
> >>>     headers
> >>>   bus: fsl-mc: fsl-mc-bus: Demote a bunch of non-conformant kernel-doc
> >>>     headers and help others
> >>>   bus: fsl-mc: dprc: Fix a couple of misspelling and formatting issues
> >>>   bus: fsl-mc: dprc-driver: Fix some missing/incorrect function
> >>>     parameter descriptions
> >>>   bus: fsl-mc: fsl-mc-allocator: Fix misspelling of 'new_mc_adev' and
> >>>     demote non-kernel-doc headers
> >>>   bus: qcom-ebi2: Fix incorrect documentation for '{slow,fast}_cfg'
> >>>   bus: fsl-mc-msi: Fix a little doc-rot pertaining to 'np' to 'fwnode'
> >>>     conversion
> >>>   bus: ti-sysc: Correct misdocumentation of 'sysc_ioremap()'
> >>>   bus: fsl-mc: mc-io: Correct misdocumentation of 'dpmcp_dev' param
> >>>
> >>>  drivers/bus/fsl-mc/dprc-driver.c      |  8 +++++---
> >>>  drivers/bus/fsl-mc/dprc.c             |  4 ++--
> >>>  drivers/bus/fsl-mc/fsl-mc-allocator.c | 10 +++++-----
> >>>  drivers/bus/fsl-mc/fsl-mc-bus.c       | 19 ++++++++++---------
> >>>  drivers/bus/fsl-mc/fsl-mc-msi.c       |  2 +-
> >>>  drivers/bus/fsl-mc/mc-io.c            |  6 +++---
> >>>  drivers/bus/fsl-mc/mc-sys.c           | 19 ++++++++++---------
> >>
> >> Thanks for this. For drivers/bus/fsl-mc/*:
> >>
> >> Reviewed-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> > 
> > Any idea who will take the 'fsl-mc' patches please?
> > 
> 
> Usually GregKH (added in the thread) picks them up through his char-misc
> tree.

If you resend just the fsl-mc patches as a series, I can pick them up
that way.  Otherwise trying to pick out individual ones here is pretty
much impossible...

thanks,

greg k-h