From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04A46C47082 for ; Wed, 26 May 2021 09:03:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D3B75613CD for ; Wed, 26 May 2021 09:03:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233528AbhEZJFN (ORCPT ); Wed, 26 May 2021 05:05:13 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:42663 "EHLO relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233494AbhEZJFB (ORCPT ); Wed, 26 May 2021 05:05:01 -0400 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id A777FC0017; Wed, 26 May 2021 09:03:26 +0000 (UTC) From: Miquel Raynal To: Miquel Raynal , Rob Herring , devicetree@vger.kernel.org Cc: Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , linux-mtd@lists.infradead.org, Naga Sureshkumar Relli , Michal Simek , Thomas Petazzoni Subject: Re: [PATCH v2 4/5] mtd: rawnand: arasan: Ensure proper configuration for the asserted target Date: Wed, 26 May 2021 11:03:26 +0200 Message-Id: <20210526090326.181097-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210510104051.9701-5-miquel.raynal@bootlin.com> References: MIME-Version: 1.0 X-linux-mtd-patch-notification: thanks X-linux-mtd-patch-commit: b'435a225acd6dba2d1d69f0c924412e4e69c95736' Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 2021-05-10 at 10:40:50 UTC, Miquel Raynal wrote: > The controller being always asserting one CS or the other, there is no > need to actually select the right target before doing a page read/write. > However, the anfc_select_target() helper actually also changes the > timing configuration and clock in the case were two different NAND chips > with different timing requirements would be used. In this situation, we > must ensure proper configuration of the controller by calling it. > > As a consequence of this change, the anfc_select_target() helper is > being moved earlier in the driver. > > Fixes: 88ffef1b65cf ("mtd: rawnand: arasan: Support the hardware BCH ECC engine") > Signed-off-by: Miquel Raynal Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next. Miquel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DDE0C2B9F7 for ; Wed, 26 May 2021 09:39:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4D826143C for ; Wed, 26 May 2021 09:39:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4D826143C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dGN+V3zt0Nckc0hmxwAZXD1A1bFlr5Il4B2vWR3H4Y0=; b=4ttWdGBZin6X8v eD5MS2U4YokTf0RISIJwhIBfHp3/+iyUnsruIpmsmJyjZP+oBcLs2wbc97X48diMONL+ycsFK7I/D xDml75KE241K2aMz8AfbjgYfB1AofOKVS3vWCTfoZAi//nPfgTQjvM+5HV7bEMPaTmKmjkwMzc2XD 5LCEnGdiKHetu7U+vvy/Sso39Tpwjg5I8rrYITBE8k0QtOomaqZwlvSo8Or4K2vHJhuoBOaIuajsA zuOvoFBmZHhUjTeF9AP1ire1nQz8jg76ziTy/VJss8YTc5QfF5GnyPpmQy9rTy2iHM2Qo4oLNR/EX zEpzMgLOxIJu/gOxsKXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1llpze-00CwbO-Kq; Wed, 26 May 2021 09:38:26 +0000 Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1llpRp-00Ci6a-5k for linux-mtd@lists.infradead.org; Wed, 26 May 2021 09:03:30 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id A777FC0017; Wed, 26 May 2021 09:03:26 +0000 (UTC) From: Miquel Raynal To: Miquel Raynal , Rob Herring , devicetree@vger.kernel.org Cc: Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , linux-mtd@lists.infradead.org, Naga Sureshkumar Relli , Michal Simek , Thomas Petazzoni Subject: Re: [PATCH v2 4/5] mtd: rawnand: arasan: Ensure proper configuration for the asserted target Date: Wed, 26 May 2021 11:03:26 +0200 Message-Id: <20210526090326.181097-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210510104051.9701-5-miquel.raynal@bootlin.com> References: MIME-Version: 1.0 X-linux-mtd-patch-notification: thanks X-linux-mtd-patch-commit: b'435a225acd6dba2d1d69f0c924412e4e69c95736' X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210526_020329_388508_B1A956BA X-CRM114-Status: GOOD ( 12.59 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Mon, 2021-05-10 at 10:40:50 UTC, Miquel Raynal wrote: > The controller being always asserting one CS or the other, there is no > need to actually select the right target before doing a page read/write. > However, the anfc_select_target() helper actually also changes the > timing configuration and clock in the case were two different NAND chips > with different timing requirements would be used. In this situation, we > must ensure proper configuration of the controller by calling it. > > As a consequence of this change, the anfc_select_target() helper is > being moved earlier in the driver. > > Fixes: 88ffef1b65cf ("mtd: rawnand: arasan: Support the hardware BCH ECC engine") > Signed-off-by: Miquel Raynal Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next. Miquel ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/