From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D77A8C2B9F7 for ; Wed, 26 May 2021 10:08:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B49246124C for ; Wed, 26 May 2021 10:08:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233730AbhEZKK1 (ORCPT ); Wed, 26 May 2021 06:10:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233830AbhEZKKY (ORCPT ); Wed, 26 May 2021 06:10:24 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F9B0C061574 for ; Wed, 26 May 2021 03:08:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=XifbQzEQk6a/Kpk0B7BIp9QvaOtr11rfSpq3pzNWwU4=; b=HCLMzQxXzZdxVKoDmsZIg+DDP laVqE2hLq+I4pJd7Hf+x3RDE/hRJh7Qa0RFsvACyuZM576biypZHX9nmlnVft12uiTNukLsE1xhF0 wNwoi6u50fbbbamkmF8TZTGRHCeEO4pp1R/ik/l4VZEYTbdCD7Z0kgKmoy7NsUDdumxykeaXdOzv/ oZk4cwW3qRWyAmpHcFXAthiMEATZ4Yf12XUQNRHIIt5KzhqtonYRov9oLe5liY2y15GFqdN4teRfi kUiN68iwCvSPoMp9fVgKBU73l6iJuiBlbBC3uTWKIoZvaZwmHepikm1X4ybwDMntPcztMKBDY4dIK clU5RmjNA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44366) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llqT1-0005RN-Fs; Wed, 26 May 2021 11:08:47 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1llqSy-0002iX-3C; Wed, 26 May 2021 11:08:44 +0100 Date: Wed, 26 May 2021 11:08:44 +0100 From: "Russell King (Oracle)" To: Krzysztof =?utf-8?Q?Ha=C5=82asa?= Cc: linux-arm-kernel , lkml Subject: Re: Data corruption on i.MX6 IPU in arm_copy_from_user() Message-ID: <20210526100843.GD30436@shell.armlinux.org.uk> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 26, 2021 at 10:26:50AM +0200, Krzysztof Hałasa wrote: > Hello, > > I've encountered an interesting case of data corruption while accessing > IPU (Image Processing Unit) on i.MX6 (rev1.2, Cortex A9). What I'm doing > here is basically: > > openat(AT_FDCWD, "/dev/mem", O_RDWR|O_SYNC) = 3 > mmap2(NULL, 4096, PROT_READ|PROT_WRITE, MAP_SHARED, 3, 0x2630000) = ptr > write(1, ptr, 32) = 32 > > Normally, the write() should end up with: > 04008A00 02FF03FF 02FF03FF 00000000 00000000 00000000 00000000 00000000 > > However, with current kernels, the first 32 bits (the first IPU > register) are dropped: > 02FF03FF 02FF03FF 00000000 00000000 00000000 00000000 00000000 00000000 > > 0x2630000 is IPU1 CSI0 address (i.e., a register block). The same > happens with other IPU regions. Writes shorter than 8 * 32 bits are not > affected. > > write() uses arm_copy_from_user() and since commit f441882a5229: > ARM: 8812/1: Optimise copy_{from/to}_user for !CPU_USE_DOMAINS > > ARMv6+ processors do not use CONFIG_CPU_USE_DOMAINS and use privileged > ldr/str instructions in copy_{from/to}_user. They are currently > unnecessarily using single ldr/str instructions and can use ldm/stm > instructions instead like memcpy does (but with appropriate fixup > tables). > > apparently uses 8 * 32-bit ldmia instruction to copy data: > .macro ldr8w ptr reg1 reg2 reg3 reg4 reg5 reg6 reg7 reg8 abort > USERL(\abort, ldmia \ptr!, {\reg1, \reg2, \reg3, \reg4, \reg5, \reg6, \reg7, \reg8}) > .endm > > Before this commit it used ldr instruction (single 32-bit value) and the > problem didn't show up (reverting f441882a5229 on v5.11 fixes it as > well). The i.MX6 errata doesn't seem to list this problem. > > I wonder what the theory says about this case. Is it at all valid to > read 8 IPU registers at a time using LDM instruction? If so, should > something be done with this problem, or should it be left as is? Surely someone is not using copy_*_user() to copy data from userspace direct to MMIO space... that would be crazy. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2ED2C47082 for ; Wed, 26 May 2021 12:34:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B7676613BC for ; Wed, 26 May 2021 12:34:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7676613BC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=an1NFuy0KWtKaVuJDLf/ot7chCOf7dXiLJW6zJKUd70=; b=Amz1heMM9gNMgL U/Lr/Ng9OGLk3ozyI3tIV6rr5tBZbFjNs7GBYLHQzjf9P/d5iI/xXxGDmvU/zmpDZ6OPonRGchbR+ 3UfCwve55g5frCk9+zPBzc5TelN76aFOydAFH8yhVTO0WEnejzlnPZFPoadInidB3WamSNrneGjhE nysaVjZ4tKz5n3y6+neSyVeZnhz5ZG3WXySQl+cVxWEbSIDEItXJbjlCMv8jeoymYgE5X1Y/SOTql KopQeLUWj4EZ0KikW8EItKtVq/NwvP1yke7ivZo07OMjidTuT45AatLr0nA7wk3LoBuLJrwVXFS+s Nur8FxJyqLHlVnO9cBlw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1llsiH-00E0Np-5F; Wed, 26 May 2021 12:32:42 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1llqTC-00D69o-FR for linux-arm-kernel@lists.infradead.org; Wed, 26 May 2021 10:09:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=XifbQzEQk6a/Kpk0B7BIp9QvaOtr11rfSpq3pzNWwU4=; b=HCLMzQxXzZdxVKoDmsZIg+DDP laVqE2hLq+I4pJd7Hf+x3RDE/hRJh7Qa0RFsvACyuZM576biypZHX9nmlnVft12uiTNukLsE1xhF0 wNwoi6u50fbbbamkmF8TZTGRHCeEO4pp1R/ik/l4VZEYTbdCD7Z0kgKmoy7NsUDdumxykeaXdOzv/ oZk4cwW3qRWyAmpHcFXAthiMEATZ4Yf12XUQNRHIIt5KzhqtonYRov9oLe5liY2y15GFqdN4teRfi kUiN68iwCvSPoMp9fVgKBU73l6iJuiBlbBC3uTWKIoZvaZwmHepikm1X4ybwDMntPcztMKBDY4dIK clU5RmjNA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44366) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llqT1-0005RN-Fs; Wed, 26 May 2021 11:08:47 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1llqSy-0002iX-3C; Wed, 26 May 2021 11:08:44 +0100 Date: Wed, 26 May 2021 11:08:44 +0100 From: "Russell King (Oracle)" To: Krzysztof =?utf-8?Q?Ha=C5=82asa?= Cc: linux-arm-kernel , lkml Subject: Re: Data corruption on i.MX6 IPU in arm_copy_from_user() Message-ID: <20210526100843.GD30436@shell.armlinux.org.uk> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210526_030858_564538_EA8D8B33 X-CRM114-Status: GOOD ( 18.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBNYXkgMjYsIDIwMjEgYXQgMTA6MjY6NTBBTSArMDIwMCwgS3J6eXN6dG9mIEhhxYJh c2Egd3JvdGU6Cj4gSGVsbG8sCj4gCj4gSSd2ZSBlbmNvdW50ZXJlZCBhbiBpbnRlcmVzdGluZyBj YXNlIG9mIGRhdGEgY29ycnVwdGlvbiB3aGlsZSBhY2Nlc3NpbmcKPiBJUFUgKEltYWdlIFByb2Nl c3NpbmcgVW5pdCkgb24gaS5NWDYgKHJldjEuMiwgQ29ydGV4IEE5KS4gV2hhdCBJJ20gZG9pbmcK PiBoZXJlIGlzIGJhc2ljYWxseToKPiAKPiBvcGVuYXQoQVRfRkRDV0QsICIvZGV2L21lbSIsIE9f UkRXUnxPX1NZTkMpID0gMwo+IG1tYXAyKE5VTEwsIDQwOTYsIFBST1RfUkVBRHxQUk9UX1dSSVRF LCBNQVBfU0hBUkVELCAzLCAweDI2MzAwMDApID0gcHRyCj4gd3JpdGUoMSwgcHRyLCAzMikgICAg ICAgICAgICAgICAgPSAzMgo+IAo+IE5vcm1hbGx5LCB0aGUgd3JpdGUoKSBzaG91bGQgZW5kIHVw IHdpdGg6Cj4gIDA0MDA4QTAwIDAyRkYwM0ZGIDAyRkYwM0ZGIDAwMDAwMDAwIDAwMDAwMDAwIDAw MDAwMDAwIDAwMDAwMDAwIDAwMDAwMDAwCj4gCj4gSG93ZXZlciwgd2l0aCBjdXJyZW50IGtlcm5l bHMsIHRoZSBmaXJzdCAzMiBiaXRzICh0aGUgZmlyc3QgSVBVCj4gIHJlZ2lzdGVyKSBhcmUgZHJv cHBlZDoKPiAgMDJGRjAzRkYgMDJGRjAzRkYgMDAwMDAwMDAgMDAwMDAwMDAgMDAwMDAwMDAgMDAw MDAwMDAgMDAwMDAwMDAgMDAwMDAwMDAKPiAKPiAweDI2MzAwMDAgaXMgSVBVMSBDU0kwIGFkZHJl c3MgKGkuZS4sIGEgcmVnaXN0ZXIgYmxvY2spLiBUaGUgc2FtZQo+IGhhcHBlbnMgd2l0aCBvdGhl ciBJUFUgcmVnaW9ucy4gV3JpdGVzIHNob3J0ZXIgdGhhbiA4ICogMzIgYml0cyBhcmUgbm90Cj4g YWZmZWN0ZWQuCj4gCj4gd3JpdGUoKSB1c2VzIGFybV9jb3B5X2Zyb21fdXNlcigpIGFuZCBzaW5j ZSBjb21taXQgZjQ0MTg4MmE1MjI5Ogo+ICAgICBBUk06IDg4MTIvMTogT3B0aW1pc2UgY29weV97 ZnJvbS90b31fdXNlciBmb3IgIUNQVV9VU0VfRE9NQUlOUwo+IAo+ICAgICBBUk12NisgcHJvY2Vz c29ycyBkbyBub3QgdXNlIENPTkZJR19DUFVfVVNFX0RPTUFJTlMgYW5kIHVzZSBwcml2aWxlZ2Vk Cj4gICAgIGxkci9zdHIgaW5zdHJ1Y3Rpb25zIGluIGNvcHlfe2Zyb20vdG99X3VzZXIuICBUaGV5 IGFyZSBjdXJyZW50bHkKPiAgICAgdW5uZWNlc3NhcmlseSB1c2luZyBzaW5nbGUgbGRyL3N0ciBp bnN0cnVjdGlvbnMgYW5kIGNhbiB1c2UgbGRtL3N0bQo+ICAgICBpbnN0cnVjdGlvbnMgaW5zdGVh ZCBsaWtlIG1lbWNweSBkb2VzIChidXQgd2l0aCBhcHByb3ByaWF0ZSBmaXh1cAo+ICAgICB0YWJs ZXMpLgo+IAo+IGFwcGFyZW50bHkgdXNlcyA4ICogMzItYml0IGxkbWlhIGluc3RydWN0aW9uIHRv IGNvcHkgZGF0YToKPiAgICAgLm1hY3JvIGxkcjh3IHB0ciByZWcxIHJlZzIgcmVnMyByZWc0IHJl ZzUgcmVnNiByZWc3IHJlZzggYWJvcnQKPiAgICAgVVNFUkwoXGFib3J0LCBsZG1pYSBccHRyISwg e1xyZWcxLCBccmVnMiwgXHJlZzMsIFxyZWc0LCBccmVnNSwgXHJlZzYsIFxyZWc3LCBccmVnOH0p Cj4gICAgIC5lbmRtCj4gCj4gQmVmb3JlIHRoaXMgY29tbWl0IGl0IHVzZWQgbGRyIGluc3RydWN0 aW9uIChzaW5nbGUgMzItYml0IHZhbHVlKSBhbmQgdGhlCj4gcHJvYmxlbSBkaWRuJ3Qgc2hvdyB1 cCAocmV2ZXJ0aW5nIGY0NDE4ODJhNTIyOSBvbiB2NS4xMSBmaXhlcyBpdCBhcwo+IHdlbGwpLiBU aGUgaS5NWDYgZXJyYXRhIGRvZXNuJ3Qgc2VlbSB0byBsaXN0IHRoaXMgcHJvYmxlbS4KPiAKPiBJ IHdvbmRlciB3aGF0IHRoZSB0aGVvcnkgc2F5cyBhYm91dCB0aGlzIGNhc2UuIElzIGl0IGF0IGFs bCB2YWxpZCB0bwo+IHJlYWQgOCBJUFUgcmVnaXN0ZXJzIGF0IGEgdGltZSB1c2luZyBMRE0gaW5z dHJ1Y3Rpb24/IElmIHNvLCBzaG91bGQKPiBzb21ldGhpbmcgYmUgZG9uZSB3aXRoIHRoaXMgcHJv YmxlbSwgb3Igc2hvdWxkIGl0IGJlIGxlZnQgYXMgaXM/CgpTdXJlbHkgc29tZW9uZSBpcyBub3Qg dXNpbmcgY29weV8qX3VzZXIoKSB0byBjb3B5IGRhdGEgZnJvbSB1c2Vyc3BhY2UKZGlyZWN0IHRv IE1NSU8gc3BhY2UuLi4gdGhhdCB3b3VsZCBiZSBjcmF6eS4KCi0tIApSTUsncyBQYXRjaCBzeXN0 ZW06IGh0dHBzOi8vd3d3LmFybWxpbnV4Lm9yZy51ay9kZXZlbG9wZXIvcGF0Y2hlcy8KRlRUUCBp cyBoZXJlISA0ME1icHMgZG93biAxME1icHMgdXAuIERlY2VudCBjb25uZWN0aXZpdHkgYXQgbGFz dCEKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4 LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFk Lm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFy bS1rZXJuZWwK