From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84782C4708A for ; Wed, 26 May 2021 13:45:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 61E6C613C9 for ; Wed, 26 May 2021 13:45:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232911AbhEZNqw (ORCPT ); Wed, 26 May 2021 09:46:52 -0400 Received: from mx2.suse.de ([195.135.220.15]:53994 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231911AbhEZNqv (ORCPT ); Wed, 26 May 2021 09:46:51 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1622036718; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=apm9jbJQFRD4udYNHoSzxdprqFqLA7k3RsYAIC55tFw=; b=cnmntof33GWZpibKaFYSeM4Gk6TxfRLz+4s4t8LuFWXfJvqQIlVA1wtA5H2WpPVs2aXVM1 90Ovx5JwBzEDtXH60rKQnNRznZfWICKqqqpBlDuoCFGc+WBiqDSjzlvvoZgCb1wcIen8S4 mznQOxzR6nPyM4QN4jw0ZLesgEvJAVI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1622036718; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=apm9jbJQFRD4udYNHoSzxdprqFqLA7k3RsYAIC55tFw=; b=hkwnkRmSuFFvaSrY4e0OIjbNBgSv/k9RwujrcIU4D0drYeNryY1g/BkIYM5sV632oIA/us 5BEXA3EzHyDAf1CA== Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B9FCDB275; Wed, 26 May 2021 13:45:18 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 4146A1F2CAC; Wed, 26 May 2021 15:45:18 +0200 (CEST) Date: Wed, 26 May 2021 15:45:18 +0200 From: Jan Kara To: Damien Le Moal Cc: Jan Kara , "Darrick J. Wong" , "linux-fsdevel@vger.kernel.org" , "hch@infradead.org" , Dave Chinner , "ceph-devel@vger.kernel.org" , Chao Yu , "Darrick J. Wong" , Jaegeuk Kim , Jeff Layton , Johannes Thumshirn , "linux-cifs@vger.kernel.org" , "linux-ext4@vger.kernel.org" , "linux-f2fs-devel@lists.sourceforge.net" , "linux-mm@kvack.org" , "linux-xfs@vger.kernel.org" , Miklos Szeredi , Steve French , Ted Tso , Matthew Wilcox Subject: Re: [PATCH 04/13] mm: Add functions to lock invalidate_lock for two mappings Message-ID: <20210526134518.GF30369@quack2.suse.cz> References: <20210525125652.20457-1-jack@suse.cz> <20210525135100.11221-4-jack@suse.cz> <20210525204805.GM202121@locust> <20210526100702.GB30369@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org On Wed 26-05-21 12:11:43, Damien Le Moal wrote: > On 2021/05/26 19:07, Jan Kara wrote: > > On Tue 25-05-21 13:48:05, Darrick J. Wong wrote: > >> On Tue, May 25, 2021 at 03:50:41PM +0200, Jan Kara wrote: > >>> Some operations such as reflinking blocks among files will need to lock > >>> invalidate_lock for two mappings. Add helper functions to do that. > >>> > >>> Signed-off-by: Jan Kara > >>> --- > >>> include/linux/fs.h | 6 ++++++ > >>> mm/filemap.c | 38 ++++++++++++++++++++++++++++++++++++++ > >>> 2 files changed, 44 insertions(+) > >>> > >>> diff --git a/include/linux/fs.h b/include/linux/fs.h > >>> index 897238d9f1e0..e6f7447505f5 100644 > >>> --- a/include/linux/fs.h > >>> +++ b/include/linux/fs.h > >>> @@ -822,6 +822,12 @@ static inline void inode_lock_shared_nested(struct inode *inode, unsigned subcla > >>> void lock_two_nondirectories(struct inode *, struct inode*); > >>> void unlock_two_nondirectories(struct inode *, struct inode*); > >>> > >>> +void filemap_invalidate_down_write_two(struct address_space *mapping1, > >>> + struct address_space *mapping2); > >>> +void filemap_invalidate_up_write_two(struct address_space *mapping1, > >> > >> TBH I find myself wishing that the invalidate_lock used the same > >> lock/unlock style wrappers that we use for i_rwsem. > >> > >> filemap_invalidate_lock(inode1->mapping); > >> filemap_invalidate_lock_two(inode1->i_mapping, inode2->i_mapping); > > > > OK, and filemap_invalidate_lock_shared() for down_read()? I guess that > > works for me. > > What about filemap_invalidate_lock_read() and filemap_invalidate_lock_write() ? > That reminds the down_read()/down_write() without the slightly confusing down/up. Well, if we go for lock wrappers as Darrick suggested, I'd mirror naming used for inode_lock(). That is IMO the least confusing option... And that naming has _lock and _lock_shared suffixes. Honza -- Jan Kara SUSE Labs, CR From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14D9BC47089 for ; Wed, 26 May 2021 13:45:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9ECB46023C for ; Wed, 26 May 2021 13:45:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9ECB46023C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2FCD56B0036; Wed, 26 May 2021 09:45:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2ACE46B006E; Wed, 26 May 2021 09:45:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1005D6B0070; Wed, 26 May 2021 09:45:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0022.hostedemail.com [216.40.44.22]) by kanga.kvack.org (Postfix) with ESMTP id D22116B0036 for ; Wed, 26 May 2021 09:45:20 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 6AE918249980 for ; Wed, 26 May 2021 13:45:20 +0000 (UTC) X-FDA: 78183504000.03.F39BDE2 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf08.hostedemail.com (Postfix) with ESMTP id 259648019124 for ; Wed, 26 May 2021 13:45:12 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1622036718; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=apm9jbJQFRD4udYNHoSzxdprqFqLA7k3RsYAIC55tFw=; b=cnmntof33GWZpibKaFYSeM4Gk6TxfRLz+4s4t8LuFWXfJvqQIlVA1wtA5H2WpPVs2aXVM1 90Ovx5JwBzEDtXH60rKQnNRznZfWICKqqqpBlDuoCFGc+WBiqDSjzlvvoZgCb1wcIen8S4 mznQOxzR6nPyM4QN4jw0ZLesgEvJAVI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1622036718; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=apm9jbJQFRD4udYNHoSzxdprqFqLA7k3RsYAIC55tFw=; b=hkwnkRmSuFFvaSrY4e0OIjbNBgSv/k9RwujrcIU4D0drYeNryY1g/BkIYM5sV632oIA/us 5BEXA3EzHyDAf1CA== Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B9FCDB275; Wed, 26 May 2021 13:45:18 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 4146A1F2CAC; Wed, 26 May 2021 15:45:18 +0200 (CEST) Date: Wed, 26 May 2021 15:45:18 +0200 From: Jan Kara To: Damien Le Moal Cc: Jan Kara , "Darrick J. Wong" , "linux-fsdevel@vger.kernel.org" , "hch@infradead.org" , Dave Chinner , "ceph-devel@vger.kernel.org" , Chao Yu , "Darrick J. Wong" , Jaegeuk Kim , Jeff Layton , Johannes Thumshirn , "linux-cifs@vger.kernel.org" , "linux-ext4@vger.kernel.org" , "linux-f2fs-devel@lists.sourceforge.net" , "linux-mm@kvack.org" , "linux-xfs@vger.kernel.org" , Miklos Szeredi , Steve French , Ted Tso , Matthew Wilcox Subject: Re: [PATCH 04/13] mm: Add functions to lock invalidate_lock for two mappings Message-ID: <20210526134518.GF30369@quack2.suse.cz> References: <20210525125652.20457-1-jack@suse.cz> <20210525135100.11221-4-jack@suse.cz> <20210525204805.GM202121@locust> <20210526100702.GB30369@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 259648019124 Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=cnmntof3; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=hkwnkRmS; spf=pass (imf08.hostedemail.com: domain of jack@suse.cz designates 195.135.220.15 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none X-Rspamd-Server: rspam04 X-Stat-Signature: j1ntah3em5gqhabkucdsmbuaqbanr6yh X-HE-Tag: 1622036712-393050 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 26-05-21 12:11:43, Damien Le Moal wrote: > On 2021/05/26 19:07, Jan Kara wrote: > > On Tue 25-05-21 13:48:05, Darrick J. Wong wrote: > >> On Tue, May 25, 2021 at 03:50:41PM +0200, Jan Kara wrote: > >>> Some operations such as reflinking blocks among files will need to lock > >>> invalidate_lock for two mappings. Add helper functions to do that. > >>> > >>> Signed-off-by: Jan Kara > >>> --- > >>> include/linux/fs.h | 6 ++++++ > >>> mm/filemap.c | 38 ++++++++++++++++++++++++++++++++++++++ > >>> 2 files changed, 44 insertions(+) > >>> > >>> diff --git a/include/linux/fs.h b/include/linux/fs.h > >>> index 897238d9f1e0..e6f7447505f5 100644 > >>> --- a/include/linux/fs.h > >>> +++ b/include/linux/fs.h > >>> @@ -822,6 +822,12 @@ static inline void inode_lock_shared_nested(struct inode *inode, unsigned subcla > >>> void lock_two_nondirectories(struct inode *, struct inode*); > >>> void unlock_two_nondirectories(struct inode *, struct inode*); > >>> > >>> +void filemap_invalidate_down_write_two(struct address_space *mapping1, > >>> + struct address_space *mapping2); > >>> +void filemap_invalidate_up_write_two(struct address_space *mapping1, > >> > >> TBH I find myself wishing that the invalidate_lock used the same > >> lock/unlock style wrappers that we use for i_rwsem. > >> > >> filemap_invalidate_lock(inode1->mapping); > >> filemap_invalidate_lock_two(inode1->i_mapping, inode2->i_mapping); > > > > OK, and filemap_invalidate_lock_shared() for down_read()? I guess that > > works for me. > > What about filemap_invalidate_lock_read() and filemap_invalidate_lock_write() ? > That reminds the down_read()/down_write() without the slightly confusing down/up. Well, if we go for lock wrappers as Darrick suggested, I'd mirror naming used for inode_lock(). That is IMO the least confusing option... And that naming has _lock and _lock_shared suffixes. Honza -- Jan Kara SUSE Labs, CR From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ED17C47082 for ; Wed, 26 May 2021 13:45:32 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BA851613C9; Wed, 26 May 2021 13:45:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA851613C9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1lltqk-0002OS-0p; Wed, 26 May 2021 13:45:30 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lltqi-0002OB-Rc for linux-f2fs-devel@lists.sourceforge.net; Wed, 26 May 2021 13:45:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=apm9jbJQFRD4udYNHoSzxdprqFqLA7k3RsYAIC55tFw=; b=W8Ghus4P3nvSPuVZleRWJZKuE0 tbiMZmc+q65RohcLbV8A8cXXO8oK8AQygozlDTOkL9JUXf92j36V9Ajf5ha+c4mBAaSQ+imwOrJDI 05wVuG9mS6sLFsitIxrmGCbCQc/c8UIBHuYHoh7vmpLWFzfmbgTa53gLrzRHhk9ZPwFw=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=apm9jbJQFRD4udYNHoSzxdprqFqLA7k3RsYAIC55tFw=; b=NNduzFVPVVn5OCQWpl1/zrVZ7n fqH8tUpGegl/m1is25uENL6mysA99I4lIEcHCHXbG+ZpEBnAKPrK0oICJAHjEg0xnyXUoUTTx93Yn nyhRsMRuFHtEcW5SB9o3yROuifMxpbKgliRUJ8fK1gR4YldSpnWzggP7STE0wo7lfWOk=; Received: from mx2.suse.de ([195.135.220.15]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92.2) id 1lltqf-006afa-2o for linux-f2fs-devel@lists.sourceforge.net; Wed, 26 May 2021 13:45:29 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1622036718; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=apm9jbJQFRD4udYNHoSzxdprqFqLA7k3RsYAIC55tFw=; b=cnmntof33GWZpibKaFYSeM4Gk6TxfRLz+4s4t8LuFWXfJvqQIlVA1wtA5H2WpPVs2aXVM1 90Ovx5JwBzEDtXH60rKQnNRznZfWICKqqqpBlDuoCFGc+WBiqDSjzlvvoZgCb1wcIen8S4 mznQOxzR6nPyM4QN4jw0ZLesgEvJAVI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1622036718; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=apm9jbJQFRD4udYNHoSzxdprqFqLA7k3RsYAIC55tFw=; b=hkwnkRmSuFFvaSrY4e0OIjbNBgSv/k9RwujrcIU4D0drYeNryY1g/BkIYM5sV632oIA/us 5BEXA3EzHyDAf1CA== Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B9FCDB275; Wed, 26 May 2021 13:45:18 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 4146A1F2CAC; Wed, 26 May 2021 15:45:18 +0200 (CEST) Date: Wed, 26 May 2021 15:45:18 +0200 From: Jan Kara To: Damien Le Moal Message-ID: <20210526134518.GF30369@quack2.suse.cz> References: <20210525125652.20457-1-jack@suse.cz> <20210525135100.11221-4-jack@suse.cz> <20210525204805.GM202121@locust> <20210526100702.GB30369@quack2.suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Headers-End: 1lltqf-006afa-2o Subject: Re: [f2fs-dev] [PATCH 04/13] mm: Add functions to lock invalidate_lock for two mappings X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jeff Layton , "linux-cifs@vger.kernel.org" , "linux-ext4@vger.kernel.org" , Jan Kara , "Darrick J. Wong" , "Darrick J. Wong" , Steve French , Dave Chinner , Matthew Wilcox , "linux-f2fs-devel@lists.sourceforge.net" , "hch@infradead.org" , "linux-mm@kvack.org" , Miklos Szeredi , Ted Tso , "linux-fsdevel@vger.kernel.org" , Jaegeuk Kim , "ceph-devel@vger.kernel.org" , Johannes Thumshirn , "linux-xfs@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Wed 26-05-21 12:11:43, Damien Le Moal wrote: > On 2021/05/26 19:07, Jan Kara wrote: > > On Tue 25-05-21 13:48:05, Darrick J. Wong wrote: > >> On Tue, May 25, 2021 at 03:50:41PM +0200, Jan Kara wrote: > >>> Some operations such as reflinking blocks among files will need to lock > >>> invalidate_lock for two mappings. Add helper functions to do that. > >>> > >>> Signed-off-by: Jan Kara > >>> --- > >>> include/linux/fs.h | 6 ++++++ > >>> mm/filemap.c | 38 ++++++++++++++++++++++++++++++++++++++ > >>> 2 files changed, 44 insertions(+) > >>> > >>> diff --git a/include/linux/fs.h b/include/linux/fs.h > >>> index 897238d9f1e0..e6f7447505f5 100644 > >>> --- a/include/linux/fs.h > >>> +++ b/include/linux/fs.h > >>> @@ -822,6 +822,12 @@ static inline void inode_lock_shared_nested(struct inode *inode, unsigned subcla > >>> void lock_two_nondirectories(struct inode *, struct inode*); > >>> void unlock_two_nondirectories(struct inode *, struct inode*); > >>> > >>> +void filemap_invalidate_down_write_two(struct address_space *mapping1, > >>> + struct address_space *mapping2); > >>> +void filemap_invalidate_up_write_two(struct address_space *mapping1, > >> > >> TBH I find myself wishing that the invalidate_lock used the same > >> lock/unlock style wrappers that we use for i_rwsem. > >> > >> filemap_invalidate_lock(inode1->mapping); > >> filemap_invalidate_lock_two(inode1->i_mapping, inode2->i_mapping); > > > > OK, and filemap_invalidate_lock_shared() for down_read()? I guess that > > works for me. > > What about filemap_invalidate_lock_read() and filemap_invalidate_lock_write() ? > That reminds the down_read()/down_write() without the slightly confusing down/up. Well, if we go for lock wrappers as Darrick suggested, I'd mirror naming used for inode_lock(). That is IMO the least confusing option... And that naming has _lock and _lock_shared suffixes. Honza -- Jan Kara SUSE Labs, CR _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel