From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1lluo5-00007C-Ps for mharc-grub-devel@gnu.org; Wed, 26 May 2021 10:46:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45174) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lluo3-0008SH-Qf for grub-devel@gnu.org; Wed, 26 May 2021 10:46:47 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:58490) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lluo1-0002qA-Hy for grub-devel@gnu.org; Wed, 26 May 2021 10:46:47 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 14QEjNDJ088879; Wed, 26 May 2021 14:46:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2020-01-29; bh=ahQ++84P5UUj8KrjJNu8uhipAz+6HlZ9fYohif/0Kqo=; b=Nfrrc8QuPeNY8o4MiaUw3MJCp8EIPvB7T4Ga1EvN2EXC7HtJsSkR91bskXX/6qY5fplj 5JOQ6arLeGSEN37oU5MtEwZ8TOUehZ6xpFHxRfx8QkK/fKcK8X01LC4kxDRhBcrdiUvM UARnXB3LxqSu237YxlTDsRKs5/HbMiweRgtJhPW2PHMmv5ncMCUfiVLbvl6NF22aTqx0 UpUkYLJdieNvLV7vSgCSI/Yih5GpTa9i8IJjq5rQ2pSlvtJHbq2gT6KjfrCzN6vrjIEx yxGZ/mdojofNg+EiZ/+BmYY3Sx8ikiIoj8WfIU0H23teGgts6L2UsvZgcIjIUJ1ic/2U 3g== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 38rne44t2b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 26 May 2021 14:46:43 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 14QEjN3I167417; Wed, 26 May 2021 14:46:43 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2103.outbound.protection.outlook.com [104.47.55.103]) by userp3030.oracle.com with ESMTP id 38pq2vbds7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 26 May 2021 14:46:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A0q40f1FsxigKiAGP+coVbq/iNMPrjdJ8Od58/uKCiA7T9yAbscX+0eh0yoVJZ+OtS4ayuUCCUq4AE+U+ch0XwD5LegOFRJySAhh84Qekhp65gw6Uzkjge5abBSB0gUOo+IJtaKx83BbsICa8hAHrPn10973P4TfZOw6dRTcq2G208Vq3h/euGnwEM09Rdx2ZxModkiMtRH1T/ltCzgRara4F7KvzNo+nKzcsvnSgJURKxhNK14u+HCK74ujQIaMwgVYAlEhT0g9Eysl+Et6zDGSTcm34pn6A7I5sgl8EVIgHwxxFup0X7sZgyITw9JaXS1Btto4izkGasmJHFmsUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ahQ++84P5UUj8KrjJNu8uhipAz+6HlZ9fYohif/0Kqo=; b=YuJkXrSLjrwT9UUgbqgd/M5o/3spqJqZ5CLjEJ1COmVL0VdMnge3NCMkpOVsKfiwbCWGmy3b/vXPQovxPPXXtks+OBe+PniFspRZ+P7XoSyEmQh5vHT24Ln9RSQoq4POqZ4rdMb9dg1Be/uCww8HFRhHM4Z/423DsJSG25a1o9FLJUp2coBI2jLsakkvgti7XwxzaGJ+dKjmFfPQhuesBD1PeuPSlhK+1H8Ghdd/+MgPk9YCkLMiBn/FVbRGGui4JGvUaPZ7piaRm1+5fzDLEVW8S/DnXbeqauhhYvrEpQHbKVj6S0gnN7Uq4uRT6/kr/DWCN14613dKO0tslZH3vw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ahQ++84P5UUj8KrjJNu8uhipAz+6HlZ9fYohif/0Kqo=; b=RbdSKaANuxQEtWbNgFguGbuvpSlKdG02UblSpxRRtxNFb276qiWN7AVZldms9b5J2LEdCpNC4aQAao+5j5I9OZ5QevTrTFc8oJkOnYO+07MP3iBDu6p+p4mvAooVLuoFPj6ZoeTM1Cv1wf3j16a9p6tHzT6Z+YOEMr97LwOcUt4= Authentication-Results: linux.alibaba.com; dkim=none (message not signed) header.d=none;linux.alibaba.com; dmarc=none action=none header.from=oracle.com; Received: from BN6PR1001MB2228.namprd10.prod.outlook.com (2603:10b6:405:2e::38) by BN8PR10MB3572.namprd10.prod.outlook.com (2603:10b6:408:b0::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.21; Wed, 26 May 2021 14:46:40 +0000 Received: from BN6PR1001MB2228.namprd10.prod.outlook.com ([fe80::ed56:7043:6d81:8547]) by BN6PR1001MB2228.namprd10.prod.outlook.com ([fe80::ed56:7043:6d81:8547%4]) with mapi id 15.20.4150.028; Wed, 26 May 2021 14:46:40 +0000 Date: Wed, 26 May 2021 16:46:33 +0200 From: Daniel Kiper To: Tianjia Zhang Cc: grub-devel@gnu.org Subject: Re: [PATCH] grub-mkpasswd-pbkdf2: Simplify the main function implementation Message-ID: <20210526144633.3ugv4jttos5iqy3z@tomti.i.net-space.pl> References: <20201118065842.32049-1-tianjia.zhang@linux.alibaba.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Originating-IP: [84.10.22.86] X-ClientProxiedBy: BE0P281CA0021.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:14::8) To BN6PR1001MB2228.namprd10.prod.outlook.com (2603:10b6:405:2e::38) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from tomti.i.net-space.pl (84.10.22.86) by BE0P281CA0021.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:14::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.12 via Frontend Transport; Wed, 26 May 2021 14:46:39 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d75e50bf-8971-497e-cbf3-08d920551278 X-MS-TrafficTypeDiagnostic: BN8PR10MB3572: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HO9KhN2bG+Kena9nJVhsw5EOGAy7z4ug2IeNWpqKNwfXxHQjGW+MEu4OUQXOkTwE48bv+e2GECaVE2QNu/o+kr2llH1nZNay5TOKI84humIaKnra0FsVcTaDyDV0yYyr19xwXjRtLIefvubZo/CMD/1tEsnpDqXREbaoAzLLKLyH5yvNpA7IwpDdR/zXbigQt1/qSsK3A9F4NCzGNOBT6lp0MS8kq5BWyQF4u+4/a2lsZzxbPJYA3oimccCDygdEuEdw+TPgwUQArLYLFXkX9O+InBVcldCvC8oVQNbiq5bbvNx80BveRkgJfTfqSXRo9oB1GhuitziaAfnavZqBxSJJJuht9jRItd7BoFIgh/ViHFNkKirzIDzwEN0XHk7WCy40U21ot9ck1lR/4pJptMxESQJjHpRyb3IFZl2oJdfkaYrRQzv2L7NxrTeleH5G+bOIT82ZJVyvmfsKXCtmAuuDnDwl++SfIK4/p3+j0mTykQKJHw5tCV9eWfkIfkr9Ib8sceJ9PA+Rghc8Gxw3THuQAZOzF2DhRqqe2a5PjlIWNoLpzC9UjZPJeXIhIIQtWnxKRMD0SK7NsZlnyxygZevR+ryq2Le08xMI8Q9aOH11bwRV1ALkjoTUGEJY+etE2EXHQ4tJuTOwxbwUOgs67dQhe3udqdB3+FXjPYWiq/Y= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR1001MB2228.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(346002)(39860400002)(366004)(396003)(376002)(9686003)(478600001)(956004)(44832011)(558084003)(316002)(26005)(16526019)(2906002)(5660300002)(38100700002)(38350700002)(52116002)(7696005)(8936002)(1076003)(86362001)(6666004)(4326008)(6916009)(66476007)(55016002)(66556008)(66946007)(8676002)(186003)(6506007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?i8Ap8QIVvclFZsu9JJ55BAh/YlcN/fx2WpJvXEoFAsSdyQePgWugywR+y/q2?= =?us-ascii?Q?er4D5PIZdzBWcjLJWhfOVN9IwvX7OjeivGxL/LVfOIdauVaZXQePYGHmD6FZ?= =?us-ascii?Q?RmXGmukJ+vqxOxmlBx4hpjUgVVgJp+NUo18kGFYKQMys3yJdYeH7oXi3p00Z?= =?us-ascii?Q?p7mp8ukmhUVlYLazr9NZLRusTWbLofw3g9kg7sLruHcokGByO3WXnalRJ0zk?= =?us-ascii?Q?3ZDgJTnDcRlQ6Fp30+S2F/ZxXwqg4m4g/dc3WjxtCeZ1JzoLWa8qJ20butDb?= =?us-ascii?Q?6ksarSYczYvoCS7Lx85uEb6K3QlF+GmMMOYSL1Mj5iilXhv3lqjBI8NlEDXX?= =?us-ascii?Q?IEm+PEs/zIOoDzhPcUIoGm6MzSvLzy25lccG10xTN87IWYl6aRzUdsiGkCT1?= =?us-ascii?Q?VnNtFdD4C50NdZ1um27KuUMH97PD+LFLoeZ+nuikS0ULJqtnaPEO2gT9ZCD5?= =?us-ascii?Q?Q/owDYQHTtKDiSU2dd+oar2sAn18DdCdB2zCVvg9QIkDBk/Y165OlWoV5n2B?= =?us-ascii?Q?e6grI5greYl45FcP+oX2UR/4VTHSyMNcbDRO1vaAzslkb7WInlU1NNI0aCac?= =?us-ascii?Q?8w7xQvyFMiGCakBEpSuvERVg4NkOoAhNtOQv9B5wEOI6mRuh+fNQFvloks0P?= =?us-ascii?Q?WFq7YrzBawES6f0V1TVeRdDCiMXXo/TppgXEoSO2K4sRwOlm0pKaxD/A+Zv7?= =?us-ascii?Q?dnqWAvGdiOlw5OnKXblCAb+MPyWrQiRpMj45Bje0HgqWJm+SBAIsaj8ito/E?= =?us-ascii?Q?PKBIogybQ/AK2YDZeFoUABohK448kB1a0YVEg86Z8QDleboqD1vD+ZUEs1cF?= =?us-ascii?Q?tXUT+0HUMIo5ioA1XcRpgkUZOqyordMioxHwsO4g91Xnq690UtPoWVV6NRPb?= =?us-ascii?Q?9Ef0z914GvXiBFkw8B2Q5VuL8ME5gsBNM84FH5R/9y3TEebxace0TQqVMA+5?= =?us-ascii?Q?oGX1nWy99zfsy4mXOgPFrsadOQIVhuh/OUQ6MkreQ2O2hTPSL/w/NUN1HKtJ?= =?us-ascii?Q?7QgpLhZ/bgXssnlM1cjF+6zXMgZU41zG48wbjVZO+TNBOLph6+LYO5qKV5X8?= =?us-ascii?Q?kUETEY0ovvsBv2XS6sMEx9ajO3fqZ+6FyBLYtIqih8907lYphGCefD2CNO57?= =?us-ascii?Q?q25DUmIkiC6oQeyAlJ2JqES4EnjK2H1EXeVsp60cugkH95+IskAnxNMAQ3du?= =?us-ascii?Q?yEeyofV8baX2j9QmU7Mw8kgh0PWPOy+ysReeLAt9Y/q60OWAhtHBIcpA/2ii?= =?us-ascii?Q?8ijiC6oX/QSgX4R/sbQHwG1flpd7htfTXaWZgI5nMUKoY/5ZO+1GFIwEjFp9?= =?us-ascii?Q?DVEAWbaqsNpFqGqDCrwDVl1u?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: d75e50bf-8971-497e-cbf3-08d920551278 X-MS-Exchange-CrossTenant-AuthSource: BN6PR1001MB2228.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2021 14:46:40.7029 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mh7jRSWc3ltaBBo+R1qSkRZZYkkchq/3tT0/jYH6G7kvwMhTe25cwlClOvg5sa6ql4FUHaC+r2max8VxdM2nuw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR10MB3572 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9996 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 spamscore=0 adultscore=0 bulkscore=0 mlxlogscore=869 suspectscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2105260099 X-Proofpoint-ORIG-GUID: fKv1xrV4YtwcqmzfTaS8KuZkz2YIRmli X-Proofpoint-GUID: fKv1xrV4YtwcqmzfTaS8KuZkz2YIRmli X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9996 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 bulkscore=0 phishscore=0 mlxlogscore=999 spamscore=0 mlxscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 adultscore=0 clxscore=1015 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2105260099 Received-SPF: pass client-ip=141.146.126.78; envelope-from=daniel.kiper@oracle.com; helo=aserp2120.oracle.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 May 2021 14:46:48 -0000 Hi Tianjia, On Wed, May 26, 2021 at 04:38:33PM +0800, Tianjia Zhang wrote: > Hi Daniel, > > Please take the time to look at this patch. Thank you for the patch. I do not consider it as release material. So, I will take a look at this patch after release. Daniel