On 26.05.2021 17:07:05, Marc Kleine-Budde wrote:
> On 26.05.2021 13:47:44, Torin Cooper-Bennun wrote:
> > +	if (!ir) {
> > +		/* Handle device-specific interrupts */
> > +		if (cdev->ops->handle_dev_interrupts)
> > +			irq_ret = cdev->ops->handle_dev_interrupts(cdev, false);
> > +		return irq_ret;
> > +	}
> > +
> > +	/* ACK M_CAN interrupts */
> > +	m_can_write(cdev, M_CAN_IR, ir);
> >  
> > +	/* ACK device-specific interrupts */
> >  	if (cdev->ops->handle_dev_interrupts)
> >  		cdev->ops->handle_dev_interrupts(cdev, true);
> 
> Why do you call a 2nd time the handle_dev_interrupts() callback?

I see, clear and no clear. Why are these two separate operations?

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |