Re: [PATCH V2 INTERNAL 0/4] Broadcom's user library update

[Jason Gunthorpe <jgg@ziepe.ca>]

On Wed, May 26, 2021 at 08:52:49PM +0530, Devesh Sharma wrote:
> On Wed, May 26, 2021 at 6:56 PM Jason Gunthorpe <jgg@ziepe.ca> wrote:
> >
> > On Wed, May 26, 2021 at 11:03:09AM +0530, Devesh Sharma wrote:
> > > On Mon, May 24, 2021 at 6:32 PM Devesh Sharma
> > > <devesh.sharma@broadcom.com> wrote:
> > > >
> > > > On Wed, May 19, 2021 at 9:05 PM Leon Romanovsky <leon@kernel.org> wrote:
> > > > >
> > > > > On Wed, May 19, 2021 at 08:45:20PM +0530, Devesh Sharma wrote:
> > > > > > On Mon, May 17, 2021 at 7:08 PM Devesh Sharma
> > > > > > <devesh.sharma@broadcom.com> wrote:
> > > > > > >
> > > > > > > On Mon, May 17, 2021 at 7:05 PM Devesh Sharma
> > > > > > > <devesh.sharma@broadcom.com> wrote:
> > > > > > > >
> > > > > > > > The main focus of this patch series is to move SQ and RQ
> > > > > > > > wqe posting indices from 128B fixed stride to 16B aligned stride.
> > > > > > > > This allows more flexibility in choosing wqe size.
> > > > > > > >
> > > > > > > >
> > > > > > > > Devesh Sharma (4):
> > > > > > > >   bnxt_re/lib: Read wqe mode from the driver
> > > > > > > >   bnxt_re/lib: add a function to initialize software queue
> > > > > > > >   bnxt_re/lib: Use separate indices for shadow queue
> > > > > > > >   bnxt_re/lib: Move hardware queue to 16B aligned indices
> > > > > > > >
> > > > > > > >  kernel-headers/rdma/bnxt_re-abi.h |   5 +-
> > > > > > > >  providers/bnxt_re/bnxt_re-abi.h   |   5 +
> > > > > > > >  providers/bnxt_re/db.c            |  10 +-
> > > > > > > >  providers/bnxt_re/main.c          |   4 +
> > > > > > > >  providers/bnxt_re/main.h          |  26 ++
> > > > > > > >  providers/bnxt_re/memory.h        |  37 ++-
> > > > > > > >  providers/bnxt_re/verbs.c         | 522 ++++++++++++++++++++----------
> > > > > > > >  7 files changed, 431 insertions(+), 178 deletions(-)
> > > > > > > >
> > > > > > > >
> > > > > > > Please ignore the "Internal" keyword in the subject line.
> > > > > > >
> > > > > > Hi Leon,
> > > > > >
> > > > > > Do you have any comments on this series. For the subject line I can
> > > > > > resend the series.
> > > > >
> > > > > Yes, the change in kernel-headers/rdma/bnxt_re-abi.h should be separate
> > > > > commit created with kernel-headers/update script.
> > > > Leon, I need to have my abi changes in the upstream kernel before I
> > > > change user ABI in rdmacore? The script is popping out some errors.
> > > Leon Ping!
> >
> > You have to point the script at your private tree and then recreate
> > the commit when it is eventually merged
> >
> Meaning kernel has to be updated first as I understand it.

First? 

People are supposed to provide their kernel patches and matching
rdma-core patches together for review.

The rdma-core patche should be pushed to github with a temporary
"update kernel headers" commit

That PR gets tagged with the "needs-kernel-patch" label

When the kernel side is done then the base headers update commit is to be replaced
with the final commit using the actual kernel header.

During all of this the github PR should be forced pushed with any
updates and changes.

Jason