From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CBDBC47082 for ; Wed, 26 May 2021 17:17:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 434B4611B0 for ; Wed, 26 May 2021 17:17:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 434B4611B0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bD+OMFL2rRnoyg7vgIDeA98ujpkiCXTZAqanfJijXrk=; b=v4o4UgYGV66WwN Cjkaip73x416/gArNmJpxjDiR1aHVROHEX7DtH2UHfVpc7sjqGSVUYmK/1zgkWC2tPMtQBzaLU/4C CO8kLxi7xAVDqwW165LwnVEldlWys5BvPIj9xDTrxvZiuhcBp4gItzSv0+VMBiAelilp5fAkxfPtL +d7IEYWozzM24Sje4+zgjMDeRV1onQWQ682TwM3W0SGbt4SwK42rj7VIueHfT3Hi6QJ4QJDXrkrbO 1w/HKkPYc25aezxtQUFjEnsFVuQlbdCs+rO/JSZpopUB0PwPMxBY1lWVyEV3uqYHYqcpM8A59OYPZ j7kL0wVtUU/Ys8a4BCAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1llx7N-00G1fo-Ln; Wed, 26 May 2021 17:14:54 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1llw4H-00Fbtp-FF for linux-arm-kernel@lists.infradead.org; Wed, 26 May 2021 16:07:38 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1CDC7613D3; Wed, 26 May 2021 16:07:34 +0000 (UTC) Date: Wed, 26 May 2021 17:07:32 +0100 From: Catalin Marinas To: Shaokun Zhang Cc: linux-arm-kernel@lists.infradead.org, Will Deacon , Mark Rutland , Suzuki K Poulose Subject: Re: [PATCH 1/2] arm64: Change the cpuinfo_arm64 member type for some sysregs to u64 Message-ID: <20210526160732.GF19992@arm.com> References: <20210511182322.3830-1-catalin.marinas@arm.com> <20210511182322.3830-2-catalin.marinas@arm.com> <99c5660c-fe45-144b-ce23-66ed644d10b3@hisilicon.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <99c5660c-fe45-144b-ce23-66ed644d10b3@hisilicon.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210526_090737_572785_C1F35960 X-CRM114-Status: GOOD ( 15.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 24, 2021 at 09:31:24AM +0800, Shaokun Zhang wrote: > On 2021/5/12 2:23, Catalin Marinas wrote: > > diff --git a/arch/arm64/include/asm/cpu.h b/arch/arm64/include/asm/cpu.h > > index 7faae6ff3ab4..fe5a8499ddc2 100644 > > --- a/arch/arm64/include/asm/cpu.h > > +++ b/arch/arm64/include/asm/cpu.h > > @@ -15,11 +15,11 @@ > > struct cpuinfo_arm64 { > > struct cpu cpu; > > struct kobject kobj; > > - u32 reg_ctr; > > - u32 reg_cntfrq; > > - u32 reg_dczid; > > - u32 reg_midr; > > - u32 reg_revidr; > > + u64 reg_ctr; > > + u64 reg_cntfrq; > > One more question: is it ok to change the function prototype to u64 also? > For CNTFRQ_EL0, if the Arm ARM expand the clock to more than 4GHz and it > will also work this change (arch_timer and watchdog shall change at the > the same time). I think I'll keep cntfrq as u32. It matches the function prototype and the arm32 code which shares the same driver. Also, from ARMv8.6, there's a requirement that CNTFRQ_EL0 is standardised at 1GHz. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel