All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: wangyunjian <wangyunjian@huawei.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>, <mst@redhat.com>,
	<jasowang@redhat.com>,
	<virtualization@lists.linux-foundation.org>,
	<dingxiaoxiong@huawei.com>
Subject: Re: [PATCH net-next] virtio_net: set link state down when virtqueue is broken
Date: Wed, 26 May 2021 17:28:08 -0700	[thread overview]
Message-ID: <20210526172808.485ff268@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <79907bf6c835572b4af92f16d9a3ff2822b1c7ea.1622028946.git.wangyunjian@huawei.com>

On Wed, 26 May 2021 19:39:51 +0800 wangyunjian wrote:
> +	for (i = 0; i < vi->max_queue_pairs; i++) {
> +		if (virtqueue_is_broken(vi->rq[i].vq) || virtqueue_is_broken(vi->sq[i].vq)) {
> +			netif_carrier_off(netdev);
> +			netif_tx_stop_all_queues(netdev);
> +			vi->broken = true;

Can't comment on the virtio specifics but the lack of locking between
this and the code in virtnet_config_changed_work() seems surprising.

  reply	other threads:[~2021-05-27  0:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-26 11:39 [PATCH net-next] virtio_net: set link state down when virtqueue is broken wangyunjian
2021-05-27  0:28 ` Jakub Kicinski [this message]
2021-05-27  3:06   ` wangyunjian
2021-05-27  4:22 ` Jason Wang
2021-05-27  4:22   ` Jason Wang
2021-05-28 10:58   ` wangyunjian
2021-05-31  3:28     ` Jason Wang
2021-05-31  3:28       ` Jason Wang
2021-06-03 11:34       ` wangyunjian
2021-06-04  2:37         ` Jason Wang
2021-06-04  2:37           ` Jason Wang
2021-06-05  7:10           ` wangyunjian
2021-06-07  2:28             ` Jason Wang
2021-06-07  2:28               ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210526172808.485ff268@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=dingxiaoxiong@huawei.com \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=wangyunjian@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.