All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Guillaume Champagne" <champagne.guillaume.c@gmail.com>
To: openembedded-core@lists.openembedded.org, fntoth@gmail.com
Cc: Guillaume Champagne <champagne.guillaume.c@gmail.com>
Subject: [RFC PATCH 0/1] image-live: order bootimg after rootfs
Date: Wed, 26 May 2021 14:32:49 -0400	[thread overview]
Message-ID: <20210526183250.27433-1-champagne.guillaume.c@gmail.com> (raw)

Hi,

Following 96f47c39f1d17f073243913d524bde84add41d8f (image-live.bbclass:
optional depends when ROOTFS empty), Ferry noticed that the patch doesn't work
correctly if the image's work directory is empty since IMGDEPLOYDIR may not
exist when do_bootimg runs.

The following patch fixes this by ordering do_bootimg after do_rootfs, since
IMGDEPLOYDIR is created and cleaned before do_rootfs runs (vardeps cleandir).
This shouldn't change the build order for recipes that use a ROOTFS, since
do_bootimg would already be ordered after do_rootfs via the dependency on
do_image_{FS_TYPE}.

I'm sending this as an RFC to get the confirmation that this patch is a right
way to approach the issue. Furthermore, I feel like if there was a way to
entierly skip do_rootfs, that could be great since it doesn't even have to run
if the final image doesn't include that rootfs.

Thanks,
Guillaume

Guillaume Champagne (1):
  image-live.bbclass: order do_bootimg after do_rootfs

 meta/classes/image-live.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.20.1


             reply	other threads:[~2021-05-26 18:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-26 18:32 Guillaume Champagne [this message]
2021-05-26 18:32 ` [RFC PATCH 1/1] image-live.bbclass: order do_bootimg after do_rootfs Guillaume Champagne
2021-06-01 20:12   ` Ferry Toth
     [not found]   ` <16848E63E6244007.7311@lists.openembedded.org>
2021-06-05 12:59     ` [OE-core] " Ferry Toth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210526183250.27433-1-champagne.guillaume.c@gmail.com \
    --to=champagne.guillaume.c@gmail.com \
    --cc=fntoth@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.