From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42BBAC47088 for ; Wed, 26 May 2021 21:48:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2375B613B5 for ; Wed, 26 May 2021 21:48:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233839AbhEZVtw (ORCPT ); Wed, 26 May 2021 17:49:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:56896 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232976AbhEZVtw (ORCPT ); Wed, 26 May 2021 17:49:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 84A3F613C5; Wed, 26 May 2021 21:48:18 +0000 (UTC) Date: Wed, 26 May 2021 22:48:16 +0100 From: Catalin Marinas To: Jon Hunter Cc: linux-arm-kernel@lists.infradead.org, Will Deacon , Mark Rutland , Suzuki K Poulose , linux-tegra Subject: Re: [PATCH 2/2] arm64: Check if GMID_EL1.BS is the same on all CPUs Message-ID: <20210526214815.GA5083@arm.com> References: <20210511182322.3830-1-catalin.marinas@arm.com> <20210511182322.3830-3-catalin.marinas@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Wed, May 26, 2021 at 08:47:16PM +0100, Jon Hunter wrote: > On 11/05/2021 19:23, Catalin Marinas wrote: > > The GMID_EL1.BS field determines the number of tags accessed by the > > LDGM/STGM instructions (EL1 and up), used by the kernel for copying or > > zeroing page tags. > > > > Taint the kernel if GMID_EL1.BS differs between CPUs. > > > > Signed-off-by: Catalin Marinas > > Cc: Will Deacon > > Cc: Mark Rutland > > Cc: Suzuki K Poulose [...] > I am seeing the following undefined instruction crash on all our > ARM64 Tegra devices on today's -next and bisect is pointing to > this patch. Reverting this patch on top of -next does fix the > problem. Let me know if you have any thoughts. Yeah, sorry about that. Posted a new version here, better tested: https://lore.kernel.org/r/20210526193621.21559-1-catalin.marinas@arm.com Will should have dropped the old one from linux-next but it takes a few hours before Stephen re-creates the tree. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72ED0C47088 for ; Wed, 26 May 2021 21:50:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 364CA613B5 for ; Wed, 26 May 2021 21:50:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 364CA613B5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2XTanN1HXtSFbepjKQVasYlfjWzpDYaPwoC7vU8UM/E=; b=2tqbcdblp+yAoJ Q7BHAskAs1Y2Vy5zvpgr1v/5CuVZehDXk5TOYqubaLFuihfA0ACznOsg9a8QMuMH3s4nzqHd+QkqX j3VDldRMO6dhRQortctr+4DAzYdJZMqT6321fwIG8wF69POzkQAtNNRGPbzFI94bzyH5ihvPeLoP6 it+LrvhLDSh1Ui71MNlkGQtRAVafkDfBCATKvBogBymKpoXPmOwOPVP+pN0cYRylW+RKTD2KGUCbt JU84CfaWNnO97uNcptpwkN6k5meVxKWBYGwmlCa3LBO7N2TEF9tO2vhhctVZaTy0JXNsFOuk6MAzf zhBWwzPF7EY9WFJrW6eg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lm1O3-000F1V-4b; Wed, 26 May 2021 21:48:23 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lm1O0-000F0f-0j for linux-arm-kernel@lists.infradead.org; Wed, 26 May 2021 21:48:21 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 84A3F613C5; Wed, 26 May 2021 21:48:18 +0000 (UTC) Date: Wed, 26 May 2021 22:48:16 +0100 From: Catalin Marinas To: Jon Hunter Cc: linux-arm-kernel@lists.infradead.org, Will Deacon , Mark Rutland , Suzuki K Poulose , linux-tegra Subject: Re: [PATCH 2/2] arm64: Check if GMID_EL1.BS is the same on all CPUs Message-ID: <20210526214815.GA5083@arm.com> References: <20210511182322.3830-1-catalin.marinas@arm.com> <20210511182322.3830-3-catalin.marinas@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210526_144820_104236_67314FF2 X-CRM114-Status: GOOD ( 14.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 26, 2021 at 08:47:16PM +0100, Jon Hunter wrote: > On 11/05/2021 19:23, Catalin Marinas wrote: > > The GMID_EL1.BS field determines the number of tags accessed by the > > LDGM/STGM instructions (EL1 and up), used by the kernel for copying or > > zeroing page tags. > > > > Taint the kernel if GMID_EL1.BS differs between CPUs. > > > > Signed-off-by: Catalin Marinas > > Cc: Will Deacon > > Cc: Mark Rutland > > Cc: Suzuki K Poulose [...] > I am seeing the following undefined instruction crash on all our > ARM64 Tegra devices on today's -next and bisect is pointing to > this patch. Reverting this patch on top of -next does fix the > problem. Let me know if you have any thoughts. Yeah, sorry about that. Posted a new version here, better tested: https://lore.kernel.org/r/20210526193621.21559-1-catalin.marinas@arm.com Will should have dropped the old one from linux-next but it takes a few hours before Stephen re-creates the tree. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel