From: Lee Jones <lee.jones@linaro.org>
To: Min Li <min.li.xe@renesas.com>
Cc: "sameo@linux.intel.com" <sameo@linux.intel.com>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH mfd v1] mfd: Add Renesas Synchronization Management Unit (SMU) support
Date: Thu, 27 May 2021 09:43:53 +0100 [thread overview]
Message-ID: <20210527084353.GJ543307@dell> (raw)
In-Reply-To: <OS3PR01MB659398F1C336CA2A03A0A7EABA249@OS3PR01MB6593.jpnprd01.prod.outlook.com>
On Wed, 26 May 2021, Min Li wrote:
> >
> > > + ret = rsmu_dev_init(rsmu);
> > > + mutex_unlock(&rsmu->lock);
> > > +
> > > + if (ret == 0)
> > > + dev_info(rsmu->dev, "Probe %s successful\n",
> > > + rsmu_name(rsmu->type));
> >
> > No thank you. Please remove this.
> >
> Hi Lee
>
> What is the rule for adding informational log in the driver probe function?
The rule generally is 'don't'.
Especially if it doesn't provide any actual information.
Strings are expensive with regards to binary size.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-05-27 8:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 19:44 [PATCH mfd v1] mfd: Add Renesas Synchronization Management Unit (SMU) support min.li.xe
2021-05-05 14:11 ` Min Li
2021-05-05 15:10 ` Lee Jones
2021-05-19 8:08 ` Lee Jones
2021-05-21 14:36 ` Min Li
2021-05-21 15:02 ` Lee Jones
2021-05-21 20:04 ` Min Li
2021-05-25 15:20 ` Min Li
2021-05-25 18:23 ` Lee Jones
2021-05-25 19:35 ` Min Li
2021-05-26 8:01 ` Lee Jones
2021-05-26 18:26 ` Min Li
2021-05-27 8:43 ` Lee Jones [this message]
2021-06-03 19:31 ` Min Li
-- strict thread matches above, loose matches on Subject: below --
2021-03-20 15:43 min.li.xe
2021-03-22 15:03 ` Lee Jones
2021-03-22 15:22 ` Min Li
2021-03-23 8:44 ` Lee Jones
2021-03-23 15:01 ` Min Li
2021-03-17 21:53 min.li.xe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210527084353.GJ543307@dell \
--to=lee.jones@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=min.li.xe@renesas.com \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.