All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, linux-can@vger.kernel.org,
	kernel@pengutronix.de, Patrick Menschel <menschel.p@posteo.de>,
	Marc Kleine-Budde <mkl@pengutronix.de>
Subject: [net-next 06/21] can: isotp: change error format from decimal to symbolic error names
Date: Thu, 27 May 2021 10:45:17 +0200	[thread overview]
Message-ID: <20210527084532.1384031-7-mkl@pengutronix.de> (raw)
In-Reply-To: <20210527084532.1384031-1-mkl@pengutronix.de>

From: Patrick Menschel <menschel.p@posteo.de>

This patch changes the format string for errors from decimal %d to
symbolic error names %pe to achieve more comprehensive log messages.

Link: https://lore.kernel.org/r/20210427052150.2308-2-menschel.p@posteo.de
Signed-off-by: Patrick Menschel <menschel.p@posteo.de>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
 net/can/isotp.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/net/can/isotp.c b/net/can/isotp.c
index 9f94ad3caee9..2c4f84fac70a 100644
--- a/net/can/isotp.c
+++ b/net/can/isotp.c
@@ -221,8 +221,8 @@ static int isotp_send_fc(struct sock *sk, int ae, u8 flowstatus)
 
 	can_send_ret = can_send(nskb, 1);
 	if (can_send_ret)
-		pr_notice_once("can-isotp: %s: can_send_ret %d\n",
-			       __func__, can_send_ret);
+		pr_notice_once("can-isotp: %s: can_send_ret %pe\n",
+			       __func__, ERR_PTR(can_send_ret));
 
 	dev_put(dev);
 
@@ -798,8 +798,8 @@ static enum hrtimer_restart isotp_tx_timer_handler(struct hrtimer *hrtimer)
 
 		can_send_ret = can_send(skb, 1);
 		if (can_send_ret)
-			pr_notice_once("can-isotp: %s: can_send_ret %d\n",
-				       __func__, can_send_ret);
+			pr_notice_once("can-isotp: %s: can_send_ret %pe\n",
+				       __func__, ERR_PTR(can_send_ret));
 
 		if (so->tx.idx >= so->tx.len) {
 			/* we are done */
@@ -946,8 +946,8 @@ static int isotp_sendmsg(struct socket *sock, struct msghdr *msg, size_t size)
 	err = can_send(skb, 1);
 	dev_put(dev);
 	if (err) {
-		pr_notice_once("can-isotp: %s: can_send_ret %d\n",
-			       __func__, err);
+		pr_notice_once("can-isotp: %s: can_send_ret %pe\n",
+			       __func__, ERR_PTR(err));
 		return err;
 	}
 
-- 
2.30.2



  parent reply	other threads:[~2021-05-27  8:48 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-27  8:45 pull-request: can-next 2021-05-27 Marc Kleine-Budde
2021-05-27  8:45 ` [net-next 01/21] dt-bindings: can: rcar_can: Convert to json-schema Marc Kleine-Budde
2021-05-27  8:45 ` [net-next 02/21] dt-bindings: can: rcar_canfd: " Marc Kleine-Budde
2021-05-27  8:45 ` [net-next 03/21] can: uapi: update CAN-FD frame description Marc Kleine-Budde
2021-05-27  8:45 ` [net-next 04/21] can: uapi: introduce CANFD_FDF flag for mixed content in struct canfd_frame Marc Kleine-Budde
2021-05-27  8:45 ` [net-next 05/21] can: proc: remove unnecessary variables Marc Kleine-Budde
2021-05-27  8:45 ` Marc Kleine-Budde [this message]
2021-05-27  8:45 ` [net-next 07/21] can: isotp: add symbolic error message to isotp_module_init() Marc Kleine-Budde
2021-05-27  8:45 ` [net-next 08/21] can: isotp: Add error message if txqueuelen is too small Marc Kleine-Budde
2021-05-27  8:45 ` [net-next 09/21] can: softing: Remove redundant variable ptr Marc Kleine-Budde
2021-05-27  8:45 ` [net-next 10/21] can: hi311x: hi3110_can_probe(): silence clang warning Marc Kleine-Budde
2021-05-27  8:45 ` [net-next 11/21] can: mcp251x: mcp251x_can_probe(): " Marc Kleine-Budde
2021-05-27  8:45 ` [net-next 12/21] can: mcp251xfd: " Marc Kleine-Budde
2021-05-27  8:45 ` [net-next 13/21] can: at91_can: " Marc Kleine-Budde
2021-05-27  8:45 ` [net-next 14/21] can: kvaser_usb: Rename define USB_HYBRID_{,PRO_}CANLIN_PRODUCT_ID Marc Kleine-Budde
2021-05-27  8:45 ` [net-next 15/21] can: kvaser_usb: Add new Kvaser hydra devices Marc Kleine-Budde
2021-05-27  8:45 ` [net-next 16/21] can: c_can: remove unused variable struct c_can_priv::rxmasked Marc Kleine-Budde
2021-05-27  8:45 ` [net-next 17/21] can: c_can: add ethtool support Marc Kleine-Budde
2021-05-27  8:45 ` [net-next 18/21] can: m_can: use bits.h macros for all regmasks Marc Kleine-Budde
2021-05-27  8:45 ` [net-next 19/21] can: m_can: clean up CCCR reg defs, order by revs Marc Kleine-Budde
2021-05-27  8:45 ` [net-next 20/21] can: m_can: make TXESC, RXESC config more explicit Marc Kleine-Budde
2021-05-27  8:45 ` [net-next 21/21] can: m_can: fix whitespace in a few comments Marc Kleine-Budde
2021-05-27 21:50 ` pull-request: can-next 2021-05-27 patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210527084532.1384031-7-mkl@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=davem@davemloft.net \
    --cc=kernel@pengutronix.de \
    --cc=kuba@kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=menschel.p@posteo.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.