From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DB9EC47089 for ; Thu, 27 May 2021 10:49:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E08766100B for ; Thu, 27 May 2021 10:49:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236240AbhE0Kuy (ORCPT ); Thu, 27 May 2021 06:50:54 -0400 Received: from foss.arm.com ([217.140.110.172]:55630 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236217AbhE0Kuy (ORCPT ); Thu, 27 May 2021 06:50:54 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A43ED13A1; Thu, 27 May 2021 03:49:21 -0700 (PDT) Received: from bogus (unknown [10.57.70.210]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1C3A53F73D; Thu, 27 May 2021 03:49:19 -0700 (PDT) Date: Thu, 27 May 2021 11:49:06 +0100 From: Sudeep Holla To: Cristian Marussi Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rob Herring , Florian Fainelli , Jim Quinlan , Etienne Carriere , Peter Hilber Subject: Re: [PATCH 8/8] dt-bindings: firmware: arm,scmi: Convert to json schema Message-ID: <20210527104845.xof6ngrfsj2ybsmb@bogus> References: <20210526182807.548118-1-sudeep.holla@arm.com> <20210526182807.548118-9-sudeep.holla@arm.com> <20210527103323.GS28060@e120937-lin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210527103323.GS28060@e120937-lin> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, May 27, 2021 at 11:33:23AM +0100, Cristian Marussi wrote: > Hi Sudeep, > > Some feedback down below. > > On Wed, May 26, 2021 at 07:28:07PM +0100, Sudeep Holla wrote: [...] > > +patternProperties: > > + '^protocol@[0-9a-f]+$': > > + type: object > > + description: | > > + Each sub-node represents a protocol supported. If the platform > > + supports dedicated communication channel for a particular protocol, > > + then corresponding transport properties must be present. > > + > > Not sure if it's needed, but maybe a reference or an example to which > are the transport properties could be useful in this description. > Good point, I will try to add that example. > > + properties: > > + reg: > > + maxItems: 1 > > + > > Shouldn't be expressed that reg is required for these protocol > patternProperties ? (no sure how though...:D) > Hmm, right again need to explore on that. > > + '#clock-cells': > > + const: 1 > > + > > + '#reset-cells': > > + const: 1 > > + > > + '#power-domain-cells': > > + const: 1 > > + > > + '#thermal-sensor-cells': > > + const: 1 > > + > > Maybe it does not matter, but all the info present in the old .txt binding > about references to external std bindings like: > > > -This binding for the SCMI power domain providers uses the generic > > power > > -domain binding[2]. > > is no more reported in yaml. Is it fine ? > I think we can add it as $ref if there is yaml schema, I really don't think old .txt based reference adds anything. > > +required: > > + - compatible > > + - shmem > > Indeed shmem is required by chance all the transports defined in this > binding, but it is not really something generally required, in fact > virtio transport won't require it. > > But I'm not sure if it's better to move it now down under some kind of > if: arm,scmi|arm,scmi-smc or just do it later when virtio transport binding > will be defined/introduced. > Yes I was aware of that fact while I wrote this and expect it to be part of virtio update. -- Regards, Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59D65C47089 for ; Thu, 27 May 2021 10:51:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E5BF6100B for ; Thu, 27 May 2021 10:51:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E5BF6100B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7yztMmWn4LDWjrDOcwgKS3QcCAMR82ZIVEFyhWrCvEA=; b=x9xi3OflBGDFuA jjNW48C6jhqM7O5yhlxD0ng5dltpF7wIkcY8ZVyIF89yeykpe5HQ0D0XZ0kt+qAQqqHq2JKgL6p+j l0kRV+KvF99RtVecwVZ9Yy2O1phRDphHeTt5Xg4dIuSVpkgprJ+fVt9LxP2FgUwN18tvWSw00YmGF 555V9ehUj5oOW+vDZfX3AE2YBSZbesi49Q3/+5GrLu98jBKVndb5KgzPiOA7WS7QPD6+QRUVUB2r5 FUnGEfrQ2dwtFv2M/fGcLQkMLQk38lSSzWQRQdHh17iu/aB9rUCeU8c+jwQzUeUZcJ20EahX12Xq5 De9PqU+EA+2RnFYMYuAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmDZz-004xYy-8t; Thu, 27 May 2021 10:49:31 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmDZt-004xWI-NA for linux-arm-kernel@lists.infradead.org; Thu, 27 May 2021 10:49:27 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A43ED13A1; Thu, 27 May 2021 03:49:21 -0700 (PDT) Received: from bogus (unknown [10.57.70.210]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1C3A53F73D; Thu, 27 May 2021 03:49:19 -0700 (PDT) Date: Thu, 27 May 2021 11:49:06 +0100 From: Sudeep Holla To: Cristian Marussi Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rob Herring , Florian Fainelli , Jim Quinlan , Etienne Carriere , Peter Hilber Subject: Re: [PATCH 8/8] dt-bindings: firmware: arm,scmi: Convert to json schema Message-ID: <20210527104845.xof6ngrfsj2ybsmb@bogus> References: <20210526182807.548118-1-sudeep.holla@arm.com> <20210526182807.548118-9-sudeep.holla@arm.com> <20210527103323.GS28060@e120937-lin> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210527103323.GS28060@e120937-lin> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210527_034925_832569_2F41CE15 X-CRM114-Status: GOOD ( 23.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 27, 2021 at 11:33:23AM +0100, Cristian Marussi wrote: > Hi Sudeep, > > Some feedback down below. > > On Wed, May 26, 2021 at 07:28:07PM +0100, Sudeep Holla wrote: [...] > > +patternProperties: > > + '^protocol@[0-9a-f]+$': > > + type: object > > + description: | > > + Each sub-node represents a protocol supported. If the platform > > + supports dedicated communication channel for a particular protocol, > > + then corresponding transport properties must be present. > > + > > Not sure if it's needed, but maybe a reference or an example to which > are the transport properties could be useful in this description. > Good point, I will try to add that example. > > + properties: > > + reg: > > + maxItems: 1 > > + > > Shouldn't be expressed that reg is required for these protocol > patternProperties ? (no sure how though...:D) > Hmm, right again need to explore on that. > > + '#clock-cells': > > + const: 1 > > + > > + '#reset-cells': > > + const: 1 > > + > > + '#power-domain-cells': > > + const: 1 > > + > > + '#thermal-sensor-cells': > > + const: 1 > > + > > Maybe it does not matter, but all the info present in the old .txt binding > about references to external std bindings like: > > > -This binding for the SCMI power domain providers uses the generic > > power > > -domain binding[2]. > > is no more reported in yaml. Is it fine ? > I think we can add it as $ref if there is yaml schema, I really don't think old .txt based reference adds anything. > > +required: > > + - compatible > > + - shmem > > Indeed shmem is required by chance all the transports defined in this > binding, but it is not really something generally required, in fact > virtio transport won't require it. > > But I'm not sure if it's better to move it now down under some kind of > if: arm,scmi|arm,scmi-smc or just do it later when virtio transport binding > will be defined/introduced. > Yes I was aware of that fact while I wrote this and expect it to be part of virtio update. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel