From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CD3BC47089 for ; Thu, 27 May 2021 11:42:10 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 320C761090 for ; Thu, 27 May 2021 11:42:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 320C761090 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A2F8782E54; Thu, 27 May 2021 13:42:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="E3utnsIn"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C675582E40; Thu, 27 May 2021 13:42:03 +0200 (CEST) Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7139782E40 for ; Thu, 27 May 2021 13:42:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x730.google.com with SMTP id 76so225152qkn.13 for ; Thu, 27 May 2021 04:42:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=bVYVV0V9rrxjJHLaSfCM45rLpcVWPoMS7Ao6bpjaWS4=; b=E3utnsInkLgkfIKTqC2mektn4u+gROnhNCqYKJCTOTVEgGnN1gZ1HfqZ02GqPgCIOX g4RQopKfjsZJM4z/fkmow/HxgOi07NO6yWb573ylV3+ERzP7rRg5I4EDvFtCl5qeHCvf H2K/vJ4zY4/OJrPFD8OX2vNudf79XRb0hD4i8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=bVYVV0V9rrxjJHLaSfCM45rLpcVWPoMS7Ao6bpjaWS4=; b=Tebk5hT4C72iILvYSqMweh+ZGgr59I6dxWTKmOs64vD5FN68nAW0PBRhfSjt4MDOS7 W8N4NLmFYMVFLdOgOTtBQVkqQOwL4emugh8wJmxnTT1aj+mHqR4ZjG7SeclsOrsHHbhj WtFwz75GsXlvX5b9u3h3DKWEKcQUlH8Gzqh2GkcB1WXJzLFcNHqgV1YPe90Rpl1LworA 273BvWwqbBwrrECPfNNg/Uz1teqGQer1TprcbzXDchpzdOYDhjE2hFm4h7C5HGk/8rMX nwsKexRXpn7oJso+6ueeXS9jdBd6KYEQiWysfLJUt6ED4Xa2ulKqfR5H/B5Mmb5DZcmN WCeA== X-Gm-Message-State: AOAM531IZT1ZZ0s2JQGUL4u/gvjERElJqTXXwbgFGIXC30d0fFtzQT5l cyxdPuSvgOoHCn31qL2TW4c/lQ== X-Google-Smtp-Source: ABdhPJz8mcjH74HtwPvq2YqiU9krm1H+MvszBI8qZeacJriBv/SJsSmGQ/9XeiCObR+jdI2ySy81SA== X-Received: by 2002:ae9:e883:: with SMTP id a125mr2912725qkg.149.1622115718144; Thu, 27 May 2021 04:41:58 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2083-4b51-adf2-e538.res6.spectrum.com. [2603:6081:7b01:cbda:2083:4b51:adf2:e538]) by smtp.gmail.com with ESMTPSA id j1sm1113459qtn.83.2021.05.27.04.41.56 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 27 May 2021 04:41:56 -0700 (PDT) Date: Thu, 27 May 2021 07:41:54 -0400 From: Tom Rini To: Vignesh Raghavendra Cc: Lokesh Vutla , Dario Binacchi , u-boot@lists.denx.de Subject: Re: [PATCH] pinctrl: single: Fix probe failure getting register area size Message-ID: <20210527114154.GQ17669@bill-the-cat> References: <20210507091034.8496-1-vigneshr@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6jxgklhIH/6I0iIs" Content-Disposition: inline In-Reply-To: <20210507091034.8496-1-vigneshr@ti.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean --6jxgklhIH/6I0iIs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 07, 2021 at 02:40:34PM +0530, Vignesh Raghavendra wrote: > If reg property of pinctrl-single node requires address translation then > probe fails with following message: >=20 > single-pinctrl pinctrl@4301c000: failed to get base register size >=20 > This is because driver uses dev_read_addr_size() to get size which also > tries to fetch untranslated addr and fails. > Fix this by using dev_read_addr_size_index() which takes care of address > translation and also makes following dev_read_addr() call redundant. >=20 > This fixes Ethernet failures on TI's AM654 based EVMs due to lack of > pinmux configuration. >=20 > Fixes: 9fd8a430f3 ("pinctrl: single: get register area size by device API= ") > Signed-off-by: Vignesh Raghavendra Applied to u-boot/master, thanks! --=20 Tom --6jxgklhIH/6I0iIs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmCvhXsACgkQFHw5/5Y0 tyy30AwAgkGpFScOXzwU9RXoGK9Ki87rg1HpYc88s2dXZQKYXtd9AeyFEZI0KTyV YlYeXspJr5EZXG1akyk53csaZ50gLyVZBqsgLLTLqILDFWs+e02HNVyWBlWmVLyp HNo+UWF0jKvqFl/k8S1ckI5jZilU+OfV3RNAzLwPFAbhaF9MpjXGlZEyViVlI/kB qmkNAzq5+hOu2AtOptc6q8TXA7e1Wp7aOBMdxXs0eo5XwGsimoHgoo1FHQ4TZ6fh bXBRdrd4lOzAXcL5+xMzeNjMlN0lzlcbg2uZZF/he1clnRCNgMB51KdFnwGhHaJu g8LyhDkUCjg4TLNoyLsanF8P21OQKnxQV47zZ5AoFGt0sC70sAjJf5V4Zj2wMzCH HdbaWvu1MZAFRoB4eGAnJ5e7ukDcd7oG1W+orKD9HtGp0mMoEnv/U7IV8eaFNTzD +azRVzcY5CiAekg/kPuqC+oaOtzlbfT438VesjncRewhTa6fyxYzsI+a6mEcIzzq wYGrEZnl =Z6z9 -----END PGP SIGNATURE----- --6jxgklhIH/6I0iIs--