From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28BEDC47089 for ; Thu, 27 May 2021 11:55:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0394E6103E for ; Thu, 27 May 2021 11:55:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234361AbhE0L5M (ORCPT ); Thu, 27 May 2021 07:57:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:49754 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233683AbhE0L5J (ORCPT ); Thu, 27 May 2021 07:57:09 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4E6AD6103E; Thu, 27 May 2021 11:55:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622116536; bh=pHiGUksg5cPGxFG52DohbH7Ek7e5+uWKvRCAt78JGuk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l+QbYfvAoCsAgbrebJg9SYxXHOdc8rxHRTVP325dkWl2AsEgjAKWDTDLkJkpwW1F6 a2zW/EZ1oYLp+z6XTTtH+oiFNIGL3HSRDvRes24O6klHUIeFUGk//BqZvVOO8lRs+p w+KXjBpIubYEtVdQIZP//s2yg7SoGuGHuoJY4xPWR5/C0vqKXl16C+5k7snFn3wwZV mGl36KkoX894qY51Go560soaXldvQ1NV7tk4UP+15/ooNArfMZjaFpqEONTJQ6gA9z DZe5Gy9DSBl9QkeWkL013nEO30BkTlaDHXoUZgPaDRB0VRuz3IyGdHOwQbR6Pjf+Rh nXEvY5tq7HaeQ== Date: Thu, 27 May 2021 12:55:30 +0100 From: Will Deacon To: Xin Hao Cc: fweisbec@gmail.com, john.stultz@linaro.org, kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, lorenzo@google.com, maz@kernel.org, mika.penttila@nextfour.com, sboyd@kernel.org, tglx@linutronix.de Subject: Re: [PATCH v2 2/5] tick/broadcast: Split __tick_broadcast_oneshot_control() into a helper Message-ID: <20210527115530.GC22019@willie-the-truck> References: <20210524221818.15850-3-will@kernel.org> <20210527082219.GA21311@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 27, 2021 at 07:35:03PM +0800, Xin Hao wrote: > > 在 2021/5/27 下午4:22, Will Deacon 写道: > > On Thu, May 27, 2021 at 03:23:06PM +0800, Xin Hao wrote: > > >      I  had backport you  tick/broadcast: Prefer per-cpu relatives patches, > > > > > > but i did not get the true result,  the Wakeup Devices are all null, why? > > Probably because you don't have any suitable per-cpu timers to act as a > > wakeup. Do you have a per-cpu timer registered with CLOCK_EVT_FEAT_PERCPU > > Yes, you are right, but i want to know why the timer do not support  > CLOCK_EVT_FEAT_PERCPU. I suspect there may be drivers with the feature missing simply because it wasn't really used for much until now (I think it just prevented use for broadcast). However, before adding that to a timer, you do need to make sure that it really is banked per-cpu (or at least handles racing accesses) as well as having the per-cpu irq. Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5834BC4707F for ; Thu, 27 May 2021 11:57:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1EA9960FDC for ; Thu, 27 May 2021 11:57:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1EA9960FDC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eOoRP3DVW22+Grah1aNf4SfsV7zpYX82LGypVTAPh1s=; b=hNrWsOYNZns0Lv ySxswwEeXqsTe0VoB9BgKGASqYw8THNHLGbgkZz2IUN3Ywt07sa3zcFC/a0VLpa3wDKhg4nVk0kS1 fVyqPlPk7cGDSNSTE1yk7EySwwdtL38/5U4sQIJhA2ubKmbN8c0RxIr4V5IGSC0OaKcJoCqDmYUzi mQb58FKYZwgNnEYJrfeqiXdCOfWJE99JaM6gRL9msHzt6DJB4bCpW6AQ9S7x+n9VmuUzGSErnx6s/ 6Cn7qB8qlmRsJlFQ9uvRkgjf9fNek3+X6Gh31fRj/rXq9MSyVW921SUsJAlfeaiNLxSCMEXl30QMS a+70YRpmzZ3sEMcyBaLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmEc1-005VmJ-VP; Thu, 27 May 2021 11:55:42 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmEbw-005Vjs-J1 for linux-arm-kernel@lists.infradead.org; Thu, 27 May 2021 11:55:37 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4E6AD6103E; Thu, 27 May 2021 11:55:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622116536; bh=pHiGUksg5cPGxFG52DohbH7Ek7e5+uWKvRCAt78JGuk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l+QbYfvAoCsAgbrebJg9SYxXHOdc8rxHRTVP325dkWl2AsEgjAKWDTDLkJkpwW1F6 a2zW/EZ1oYLp+z6XTTtH+oiFNIGL3HSRDvRes24O6klHUIeFUGk//BqZvVOO8lRs+p w+KXjBpIubYEtVdQIZP//s2yg7SoGuGHuoJY4xPWR5/C0vqKXl16C+5k7snFn3wwZV mGl36KkoX894qY51Go560soaXldvQ1NV7tk4UP+15/ooNArfMZjaFpqEONTJQ6gA9z DZe5Gy9DSBl9QkeWkL013nEO30BkTlaDHXoUZgPaDRB0VRuz3IyGdHOwQbR6Pjf+Rh nXEvY5tq7HaeQ== Date: Thu, 27 May 2021 12:55:30 +0100 From: Will Deacon To: Xin Hao Cc: fweisbec@gmail.com, john.stultz@linaro.org, kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, lorenzo@google.com, maz@kernel.org, mika.penttila@nextfour.com, sboyd@kernel.org, tglx@linutronix.de Subject: Re: [PATCH v2 2/5] tick/broadcast: Split __tick_broadcast_oneshot_control() into a helper Message-ID: <20210527115530.GC22019@willie-the-truck> References: <20210524221818.15850-3-will@kernel.org> <20210527082219.GA21311@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210527_045536_680099_3A2A92C6 X-CRM114-Status: GOOD ( 12.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBNYXkgMjcsIDIwMjEgYXQgMDc6MzU6MDNQTSArMDgwMCwgWGluIEhhbyB3cm90ZToK PiAKPiDlnKggMjAyMS81LzI3IOS4i+WNiDQ6MjIsIFdpbGwgRGVhY29uIOWGmemBkzoKPiA+IE9u IFRodSwgTWF5IDI3LCAyMDIxIGF0IDAzOjIzOjA2UE0gKzA4MDAsIFhpbiBIYW8gd3JvdGU6Cj4g PiA+ICDCoMKgwqDCoCBJwqAgaGFkIGJhY2twb3J0IHlvdcKgIHRpY2svYnJvYWRjYXN0OiBQcmVm ZXIgcGVyLWNwdSByZWxhdGl2ZXMgcGF0Y2hlcywKPiA+ID4gCj4gPiA+IGJ1dCBpIGRpZCBub3Qg Z2V0IHRoZSB0cnVlIHJlc3VsdCzCoCB0aGUgV2FrZXVwIERldmljZXMgYXJlIGFsbCBudWxsLCB3 aHk/Cj4gPiBQcm9iYWJseSBiZWNhdXNlIHlvdSBkb24ndCBoYXZlIGFueSBzdWl0YWJsZSBwZXIt Y3B1IHRpbWVycyB0byBhY3QgYXMgYQo+ID4gd2FrZXVwLiBEbyB5b3UgaGF2ZSBhIHBlci1jcHUg dGltZXIgcmVnaXN0ZXJlZCB3aXRoIENMT0NLX0VWVF9GRUFUX1BFUkNQVQo+IAo+IFllcywgeW91 IGFyZSByaWdodCwgYnV0IGkgd2FudCB0byBrbm93IHdoeSB0aGUgdGltZXIgZG8gbm90IHN1cHBv cnTCoAo+IENMT0NLX0VWVF9GRUFUX1BFUkNQVS4KCkkgc3VzcGVjdCB0aGVyZSBtYXkgYmUgZHJp dmVycyB3aXRoIHRoZSBmZWF0dXJlIG1pc3Npbmcgc2ltcGx5IGJlY2F1c2UgaXQKd2Fzbid0IHJl YWxseSB1c2VkIGZvciBtdWNoIHVudGlsIG5vdyAoSSB0aGluayBpdCBqdXN0IHByZXZlbnRlZCB1 c2UgZm9yCmJyb2FkY2FzdCkuIEhvd2V2ZXIsIGJlZm9yZSBhZGRpbmcgdGhhdCB0byBhIHRpbWVy LCB5b3UgZG8gbmVlZCB0byBtYWtlCnN1cmUgdGhhdCBpdCByZWFsbHkgaXMgYmFua2VkIHBlci1j cHUgKG9yIGF0IGxlYXN0IGhhbmRsZXMgcmFjaW5nIGFjY2Vzc2VzKQphcyB3ZWxsIGFzIGhhdmlu ZyB0aGUgcGVyLWNwdSBpcnEuCgpXaWxsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0t a2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==