From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05A05C4707F for ; Thu, 27 May 2021 14:41:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BAFDC60249 for ; Thu, 27 May 2021 14:41:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BAFDC60249 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 68D5C6E8CE; Thu, 27 May 2021 14:41:11 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 000C56E8CE; Thu, 27 May 2021 14:41:09 +0000 (UTC) IronPort-SDR: JKsBIv87Re3rpTK/V83IKUvyyBdN+7i6g0NZa/so/U9uGA/NLdZbJvxZPxfmFUV0UIBUPk3sUB IiMgwz4H88XA== X-IronPort-AV: E=McAfee;i="6200,9189,9996"; a="183084317" X-IronPort-AV: E=Sophos;i="5.82,334,1613462400"; d="scan'208";a="183084317" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 May 2021 07:41:09 -0700 IronPort-SDR: F0jsq9PJTQ3vXJ7KbvtmLaNCLw2Dn2EEEEtHnJAFNiisKnMYkq4UQWmN5h2yU0rGKL4OOJRrwC K1c4FlXpSyHA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,334,1613462400"; d="scan'208";a="615403543" Received: from vsrini4-xps-8920.iind.intel.com (HELO localhost.localdomain) ([10.223.163.28]) by orsmga005.jf.intel.com with ESMTP; 27 May 2021 07:41:07 -0700 From: Vidya Srinivas To: intel-gfx@lists.freedesktop.org, igt-dev@lists.freedesktop.org Date: Thu, 27 May 2021 20:02:14 +0530 Message-Id: <20210527143214.25486-1-vidya.srinivas@intel.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH 1/4] [RFC] tests/drm_read: Fix subtest invalid-buffer X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: markyacoub@chromium.org, charlton.lin@intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Using (void *)-1 directly in read is aborting on chrome systems. Following message is seen. Starting subtest: invalid-buffer *** buffer overflow detected ***: terminated Received signal SIGABRT. Stack trace: Aborted (core dumped) Patch just adds a pointer variable and uses it in read. Signed-off-by: Vidya Srinivas Change-Id: I97f129e586bf9212eb0a63a4cd4c91e0327dd550 --- tests/drm_read.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/drm_read.c b/tests/drm_read.c index ccf9d822fd8d..2fdec5be4078 100644 --- a/tests/drm_read.c +++ b/tests/drm_read.c @@ -103,10 +103,11 @@ static void teardown(int fd) static void test_invalid_buffer(int in) { int fd = setup(in, 0); + void *add = (void *)-1; alarm(1); - igt_assert_eq(read(fd, (void *)-1, 4096), -1); + igt_assert_eq(read(fd, add, 4096), -1); igt_assert_eq(errno, EFAULT); teardown(fd); -- 2.26.2 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx