From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74611C4708A for ; Thu, 27 May 2021 14:45:50 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3133F6101B for ; Thu, 27 May 2021 14:45:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3133F6101B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 850A26E542; Thu, 27 May 2021 14:45:49 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id C17646E542; Thu, 27 May 2021 14:45:48 +0000 (UTC) IronPort-SDR: vAPU058+/jvIYMyYyT+z49kYUIv7h+BM+BzjOyWU923FhhxZKqdNFzhifhGz3rLpMHDdQRKIqw ZtZoWlcUDVRQ== X-IronPort-AV: E=McAfee;i="6200,9189,9996"; a="199710145" X-IronPort-AV: E=Sophos;i="5.82,334,1613462400"; d="scan'208";a="199710145" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 May 2021 07:45:48 -0700 IronPort-SDR: iZuDrtuYtTT9HqZ03EroxzCgscUgC8lzvBLhpfVIdSPmeTJjFz2AFrq9lGQgC8dL1na1By2+hi KATzJCQTsScA== X-IronPort-AV: E=Sophos;i="5.82,334,1613462400"; d="scan'208";a="414936142" Received: from unknown (HELO sdutt-i7) ([10.165.21.147]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 May 2021 07:45:47 -0700 Date: Thu, 27 May 2021 07:38:42 -0700 From: Matthew Brost To: Tvrtko Ursulin Subject: Re: [Intel-gfx] [RFC PATCH 53/97] drm/i915/guc: Disable semaphores when using GuC scheduling Message-ID: <20210527143842.GB25313@sdutt-i7> References: <20210506191451.77768-1-matthew.brost@intel.com> <20210506191451.77768-54-matthew.brost@intel.com> <295c0e48-5091-504a-5a81-10a60fa900f4@linux.intel.com> <20210525170131.GA14724@sdutt-i7> <20210526181501.GA4268@sdutt-i7> <44a8a634-e50c-62fc-585a-c9786b70cc11@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44a8a634-e50c-62fc-585a-c9786b70cc11@linux.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jason.ekstrand@intel.com, daniel.vetter@intel.com, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, May 27, 2021 at 09:41:46AM +0100, Tvrtko Ursulin wrote: > > On 26/05/2021 19:15, Matthew Brost wrote: > > On Wed, May 26, 2021 at 10:25:13AM +0100, Tvrtko Ursulin wrote: > > > > > > On 25/05/2021 18:01, Matthew Brost wrote: > > > > On Tue, May 25, 2021 at 10:52:01AM +0100, Tvrtko Ursulin wrote: > > > > > > > > > > On 06/05/2021 20:14, Matthew Brost wrote: > > > > > > Disable semaphores when using GuC scheduling as semaphores are broken in > > > > > > the current GuC firmware. > > > > > > > > > > What is "current"? Given that the patch itself is like year and a half old. > > > > > > > > > > > > > Stale comment. Semaphore work with the firmware we just haven't enabled > > > > them in the i915 with GuC submission as this an optimization and not > > > > required for functionality. > > > > > > How will the updated commit message look in terms of remaining reasons why > > > semaphores won't/can't be enabled? > > > > > > > Semaphores are an optimization and not required for basic GuC submission > > to work properly. Disable until we have time to do the implementation to > > enable semaphores and tune them for performance. > > > > > They were a nice performance win on some media workloads although granted a > > > lot of tweaking was required to find a good balance on when to use them and > > > when not to. > > > > > > > The same tweaking would have to be done for with GuC submission. Let's > > get basic submission then tweak for performance. > > I don't have fundamental complaints as longs as commit message is improved > and it is understood the absence of semaphores is extremely likely to > regress transcode performance tests. Latter probably doesn't matter (for > some definition of it) unless either there will be a platform where both GuC > and execlists can be supported, or there will be two separate platforms > similar in hw performance in theory, both relevant to transcode customers, > one using execlists and one using GuC. > Sounds good. Already have this commit message updated in my branch and will be included in the next post. Matt > Regards, > > Tvrtko > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71FDAC4707F for ; Thu, 27 May 2021 14:45:50 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1547561181 for ; Thu, 27 May 2021 14:45:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1547561181 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9D1E36E88B; Thu, 27 May 2021 14:45:49 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id C17646E542; Thu, 27 May 2021 14:45:48 +0000 (UTC) IronPort-SDR: vAPU058+/jvIYMyYyT+z49kYUIv7h+BM+BzjOyWU923FhhxZKqdNFzhifhGz3rLpMHDdQRKIqw ZtZoWlcUDVRQ== X-IronPort-AV: E=McAfee;i="6200,9189,9996"; a="199710145" X-IronPort-AV: E=Sophos;i="5.82,334,1613462400"; d="scan'208";a="199710145" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 May 2021 07:45:48 -0700 IronPort-SDR: iZuDrtuYtTT9HqZ03EroxzCgscUgC8lzvBLhpfVIdSPmeTJjFz2AFrq9lGQgC8dL1na1By2+hi KATzJCQTsScA== X-IronPort-AV: E=Sophos;i="5.82,334,1613462400"; d="scan'208";a="414936142" Received: from unknown (HELO sdutt-i7) ([10.165.21.147]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 May 2021 07:45:47 -0700 Date: Thu, 27 May 2021 07:38:42 -0700 From: Matthew Brost To: Tvrtko Ursulin Message-ID: <20210527143842.GB25313@sdutt-i7> References: <20210506191451.77768-1-matthew.brost@intel.com> <20210506191451.77768-54-matthew.brost@intel.com> <295c0e48-5091-504a-5a81-10a60fa900f4@linux.intel.com> <20210525170131.GA14724@sdutt-i7> <20210526181501.GA4268@sdutt-i7> <44a8a634-e50c-62fc-585a-c9786b70cc11@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <44a8a634-e50c-62fc-585a-c9786b70cc11@linux.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [Intel-gfx] [RFC PATCH 53/97] drm/i915/guc: Disable semaphores when using GuC scheduling X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jason.ekstrand@intel.com, daniel.vetter@intel.com, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, May 27, 2021 at 09:41:46AM +0100, Tvrtko Ursulin wrote: > > On 26/05/2021 19:15, Matthew Brost wrote: > > On Wed, May 26, 2021 at 10:25:13AM +0100, Tvrtko Ursulin wrote: > > > > > > On 25/05/2021 18:01, Matthew Brost wrote: > > > > On Tue, May 25, 2021 at 10:52:01AM +0100, Tvrtko Ursulin wrote: > > > > > > > > > > On 06/05/2021 20:14, Matthew Brost wrote: > > > > > > Disable semaphores when using GuC scheduling as semaphores are broken in > > > > > > the current GuC firmware. > > > > > > > > > > What is "current"? Given that the patch itself is like year and a half old. > > > > > > > > > > > > > Stale comment. Semaphore work with the firmware we just haven't enabled > > > > them in the i915 with GuC submission as this an optimization and not > > > > required for functionality. > > > > > > How will the updated commit message look in terms of remaining reasons why > > > semaphores won't/can't be enabled? > > > > > > > Semaphores are an optimization and not required for basic GuC submission > > to work properly. Disable until we have time to do the implementation to > > enable semaphores and tune them for performance. > > > > > They were a nice performance win on some media workloads although granted a > > > lot of tweaking was required to find a good balance on when to use them and > > > when not to. > > > > > > > The same tweaking would have to be done for with GuC submission. Let's > > get basic submission then tweak for performance. > > I don't have fundamental complaints as longs as commit message is improved > and it is understood the absence of semaphores is extremely likely to > regress transcode performance tests. Latter probably doesn't matter (for > some definition of it) unless either there will be a platform where both GuC > and execlists can be supported, or there will be two separate platforms > similar in hw performance in theory, both relevant to transcode customers, > one using execlists and one using GuC. > Sounds good. Already have this commit message updated in my branch and will be included in the next post. Matt > Regards, > > Tvrtko > > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx