From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1lmHTL-0005zf-Ih for mharc-grub-devel@gnu.org; Thu, 27 May 2021 10:58:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43852) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmHTJ-0005tT-F1 for grub-devel@gnu.org; Thu, 27 May 2021 10:58:53 -0400 Received: from dibed.net-space.pl ([84.10.22.86]:56415) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_3DES_EDE_CBC_SHA1:192) (Exim 4.90_1) (envelope-from ) id 1lmHTH-0008KA-SD for grub-devel@gnu.org; Thu, 27 May 2021 10:58:53 -0400 Received: from router-fw.i.net-space.pl ([192.168.52.1]:38312 "EHLO tomti.i.net-space.pl") by router-fw-old.i.net-space.pl with ESMTP id S2101088AbhE0O6j (ORCPT ); Thu, 27 May 2021 16:58:39 +0200 X-Comment: RFC 2476 MSA function at dibed.net-space.pl logged sender identity as: dkiper Date: Thu, 27 May 2021 16:58:37 +0200 From: Daniel Kiper To: jacob berkman Cc: grub-devel@gnu.org Subject: Re: [PATCH 0/3] A few small OpenBSD-ish fixes Message-ID: <20210527145837.d6hjgf7ukd4xezdc@tomti.i.net-space.pl> References: <20210519051415.847-1-jacob@87k.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210519051415.847-1-jacob@87k.net> User-Agent: NeoMutt/20170113 (1.7.2) Received-SPF: pass client-ip=84.10.22.86; envelope-from=dkiper@net-space.pl; helo=dibed.net-space.pl X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 May 2021 14:58:53 -0000 Hi Jacob, On Tue, May 18, 2021 at 10:14:12PM -0700, jacob berkman wrote: > Hello, > > I built GRUB on OpenBSD 6.9 over the weekend, and ran into a few > issues. The minor ones attached were easy enough to > fix. Unfortunately, once installed, it merely prints "Grub Loading" > (or something similar) and reboots. In trying to recover from this, I > wiped out the MBR and that's when I gave up and figured maybe I should > do this in a VM instead. The patches look more or less good to me. Though I would like to ask you to add to all of them your SOB line like: Signed-off-by: jacob berkman Additionally, please do not put whole description of the issue into the subject. The subject should contain only a hint what a given patch does. > One other issue I ran into was that setjmp.mod would fail to build > because it didn't export any symbols. No other modules seemed to > depend on it. I just removed it from Makefile, but I'm not familiar > enough with GRUB to know whether that's a reasonable enough solution, > or if that's related to the inability to boot. Could you provide more details how to reproduce the issue? Daniel