From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCD25C4707F for ; Thu, 27 May 2021 17:07:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD44F6124C for ; Thu, 27 May 2021 17:07:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236910AbhE0RJQ (ORCPT ); Thu, 27 May 2021 13:09:16 -0400 Received: from foss.arm.com ([217.140.110.172]:60702 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235279AbhE0RJN (ORCPT ); Thu, 27 May 2021 13:09:13 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0C01B11D4; Thu, 27 May 2021 10:07:40 -0700 (PDT) Received: from e120325.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 852233F719; Thu, 27 May 2021 10:07:38 -0700 (PDT) Date: Thu, 27 May 2021 18:07:30 +0100 From: Beata Michalska To: Dietmar Eggemann Cc: Valentin Schneider , linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, corbet@lwn.net, rdunlap@infradead.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v5 2/3] sched/topology: Rework CPU capacity asymmetry detection Message-ID: <20210527170729.GA20994@e120325.cambridge.arm.com> References: <87fsyc6mfz.mognet@arm.com> <20210524225508.GA14880@e120325.cambridge.arm.com> <87a6oj6sxo.mognet@arm.com> <20210525102945.GA24210@e120325.cambridge.arm.com> <98ad8837-b9b8-ff50-5a91-8d5951ee757c@arm.com> <20210526121546.GA13262@e120325.cambridge.arm.com> <20210526125133.GB13262@e120325.cambridge.arm.com> <20210526214004.GA1712@e120325.cambridge.arm.com> <14593ba7-eed9-f035-724c-5cadbb859adc@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <14593ba7-eed9-f035-724c-5cadbb859adc@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 27, 2021 at 05:08:42PM +0200, Dietmar Eggemann wrote: > On 26/05/2021 23:40, Beata Michalska wrote: > > On Wed, May 26, 2021 at 08:17:41PM +0200, Dietmar Eggemann wrote: > >> On 26/05/2021 14:51, Beata Michalska wrote: > >>> On Wed, May 26, 2021 at 01:15:46PM +0100, Beata Michalska wrote: > >>>> On Wed, May 26, 2021 at 11:52:25AM +0200, Dietmar Eggemann wrote: > >>>>> On 25/05/2021 12:29, Beata Michalska wrote: > >>>>>> On Tue, May 25, 2021 at 10:53:07AM +0100, Valentin Schneider wrote: > >>>>>>> On 24/05/21 23:55, Beata Michalska wrote: > >>>>>>>> On Mon, May 24, 2021 at 07:01:04PM +0100, Valentin Schneider wrote: > >>>>>>>>> On 24/05/21 11:16, Beata Michalska wrote: > > [...] > > >> cpu-map { > >> cluster0 { > >> core0 { > >> thread0 { > >> cpu = <&A53_0>; > >> }; > >> thread1 { > >> cpu = <&A53_1>; > >> }; > >> }; > >> core1 { > >> thread0 { > >> cpu = <&A53_2>; > >> }; > >> thread1 { > >> cpu = <&A53_3>; > >> }; > >> }; > >> core2 { > >> thread0 { > >> cpu = <&A53_4>; > >> }; > >> thread1 { > >> cpu = <&A53_5>; > >> }; > >> }; > >> }; > >> > >> cluster1 { > >> core0 { > >> thread0 { > >> cpu = <&A53_6>; > >> }; > >> thread1 { > >> cpu = <&A53_7>; > >> }; > >> }; > >> }; > >> }; > >> > >> A53_0: cpu@0 { > >> capacity-dmips-mhz = <446>; > >> A53_1: cpu@1 { > >> capacity-dmips-mhz = <1024>; > >> A53_2: cpu@2 { > >> capacity-dmips-mhz = <871>; > >> A53_3: cpu@3 { > >> capacity-dmips-mhz = <1024>; > >> A53_4: cpu@4 { > >> capacity-dmips-mhz = <446>; > >> A53_5: cpu@5 { > >> capacity-dmips-mhz = <871>; > >> A53_6: cpu@6 { > >> capacity-dmips-mhz = <1024>; > >> A53_7: cpu@7 { > >> capacity-dmips-mhz = <1024>; > >> > >> Here I guess SD_ASYM_CPUCAPACITY will be attached to SMT[0-5]. So this > >> 'capacity-dmips-mhz' config error won't be detected. > >> > >> In case all CPUs (i.e. hw threads would have the correct > >> capacity-dmips-mhz = <1024> or not being set (default 1024)) > >> asym_cap_list would corrcetly only have 1 entry. > > We could possibly add a warning (like in EAS) if the asymmetry is detected > > for SMT which would give some indication that there is smth ... wrong ? > > Maybe, in case you find an easy way to detect this. > > But the issue already exists today. Not with the topology mentioned > above but in case we slightly change it to: > > cpus = { ([446 1024] [871 1024] [446 1024] ) ([1024 1024]) } > ^^^^ > so that we have a 1024 CPU in the lowest sd for each CPU, we would get > SD_ASYM_CPUCAPACITY on SMT. The asymmetry capacity flags are being set on a sched domain level, so we could use the SD_SHARE_CPUCAPACITY|SD_SHARE_PKG_RESOURCES (cpu_smt_flags) flags to determine if having asymmetry is valid or not ? If this is enough this could be handled by the classify function? --- BR B.