From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 12/12] drm/i915/gem: Manage all set-domain waits explicitly
Date: Thu, 27 May 2021 21:33:00 +0800 [thread overview]
Message-ID: <202105272137.h8r1q1gI-lkp@intel.com> (raw)
In-Reply-To: <20210526141456.2334192-13-tvrtko.ursulin@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 5988 bytes --]
Hi Tvrtko,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-tip/drm-tip]
[cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next drm/drm-next v5.13-rc3 next-20210527]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Tvrtko-Ursulin/Catchup-with-a-few-dropped-patches/20210526-221712
base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: x86_64-rhel-8.3-kbuiltin (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/6ec1bb3d9c72c92dca67e5dc0246034a83e7b0db
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Tvrtko-Ursulin/Catchup-with-a-few-dropped-patches/20210526-221712
git checkout 6ec1bb3d9c72c92dca67e5dc0246034a83e7b0db
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/gpu/drm/i915/gvt/cmd_parser.c: In function 'shadow_indirect_ctx':
>> drivers/gpu/drm/i915/gvt/cmd_parser.c:3019:6: error: void value not ignored as it ought to be
3019 | ret = i915_gem_object_set_to_cpu_domain(obj, false);
| ^
vim +3019 drivers/gpu/drm/i915/gvt/cmd_parser.c
be1da7070aeaee Zhi Wang 2016-05-03 2991
be1da7070aeaee Zhi Wang 2016-05-03 2992 static int shadow_indirect_ctx(struct intel_shadow_wa_ctx *wa_ctx)
be1da7070aeaee Zhi Wang 2016-05-03 2993 {
be1da7070aeaee Zhi Wang 2016-05-03 2994 int ctx_size = wa_ctx->indirect_ctx.size;
be1da7070aeaee Zhi Wang 2016-05-03 2995 unsigned long guest_gma = wa_ctx->indirect_ctx.guest_gma;
c10c12558c8bb3 Tina Zhang 2017-03-17 2996 struct intel_vgpu_workload *workload = container_of(wa_ctx,
c10c12558c8bb3 Tina Zhang 2017-03-17 2997 struct intel_vgpu_workload,
c10c12558c8bb3 Tina Zhang 2017-03-17 2998 wa_ctx);
c10c12558c8bb3 Tina Zhang 2017-03-17 2999 struct intel_vgpu *vgpu = workload->vgpu;
894cf7d1563469 Chris Wilson 2016-10-19 3000 struct drm_i915_gem_object *obj;
be1da7070aeaee Zhi Wang 2016-05-03 3001 int ret = 0;
bcd0aeded478f1 Chris Wilson 2016-10-19 3002 void *map;
be1da7070aeaee Zhi Wang 2016-05-03 3003
8fde41076f6df5 Chris Wilson 2020-03-04 3004 obj = i915_gem_object_create_shmem(workload->engine->i915,
894cf7d1563469 Chris Wilson 2016-10-19 3005 roundup(ctx_size + CACHELINE_BYTES,
894cf7d1563469 Chris Wilson 2016-10-19 3006 PAGE_SIZE));
894cf7d1563469 Chris Wilson 2016-10-19 3007 if (IS_ERR(obj))
894cf7d1563469 Chris Wilson 2016-10-19 3008 return PTR_ERR(obj);
be1da7070aeaee Zhi Wang 2016-05-03 3009
be1da7070aeaee Zhi Wang 2016-05-03 3010 /* get the va of the shadow batch buffer */
bcd0aeded478f1 Chris Wilson 2016-10-19 3011 map = i915_gem_object_pin_map(obj, I915_MAP_WB);
bcd0aeded478f1 Chris Wilson 2016-10-19 3012 if (IS_ERR(map)) {
695fbc08d80f93 Tina Zhang 2017-03-10 3013 gvt_vgpu_err("failed to vmap shadow indirect ctx\n");
bcd0aeded478f1 Chris Wilson 2016-10-19 3014 ret = PTR_ERR(map);
bcd0aeded478f1 Chris Wilson 2016-10-19 3015 goto put_obj;
be1da7070aeaee Zhi Wang 2016-05-03 3016 }
be1da7070aeaee Zhi Wang 2016-05-03 3017
80f0b679d6f068 Maarten Lankhorst 2020-08-19 3018 i915_gem_object_lock(obj, NULL);
894cf7d1563469 Chris Wilson 2016-10-19 @3019 ret = i915_gem_object_set_to_cpu_domain(obj, false);
6951e5893b4821 Chris Wilson 2019-05-28 3020 i915_gem_object_unlock(obj);
be1da7070aeaee Zhi Wang 2016-05-03 3021 if (ret) {
695fbc08d80f93 Tina Zhang 2017-03-10 3022 gvt_vgpu_err("failed to set shadow indirect ctx to CPU\n");
be1da7070aeaee Zhi Wang 2016-05-03 3023 goto unmap_src;
be1da7070aeaee Zhi Wang 2016-05-03 3024 }
be1da7070aeaee Zhi Wang 2016-05-03 3025
c10c12558c8bb3 Tina Zhang 2017-03-17 3026 ret = copy_gma_to_hva(workload->vgpu,
c10c12558c8bb3 Tina Zhang 2017-03-17 3027 workload->vgpu->gtt.ggtt_mm,
bcd0aeded478f1 Chris Wilson 2016-10-19 3028 guest_gma, guest_gma + ctx_size,
bcd0aeded478f1 Chris Wilson 2016-10-19 3029 map);
8bcad07a45637f Zhenyu Wang 2017-03-29 3030 if (ret < 0) {
695fbc08d80f93 Tina Zhang 2017-03-10 3031 gvt_vgpu_err("fail to copy guest indirect ctx\n");
894cf7d1563469 Chris Wilson 2016-10-19 3032 goto unmap_src;
be1da7070aeaee Zhi Wang 2016-05-03 3033 }
be1da7070aeaee Zhi Wang 2016-05-03 3034
894cf7d1563469 Chris Wilson 2016-10-19 3035 wa_ctx->indirect_ctx.obj = obj;
bcd0aeded478f1 Chris Wilson 2016-10-19 3036 wa_ctx->indirect_ctx.shadow_va = map;
be1da7070aeaee Zhi Wang 2016-05-03 3037 return 0;
be1da7070aeaee Zhi Wang 2016-05-03 3038
be1da7070aeaee Zhi Wang 2016-05-03 3039 unmap_src:
bcd0aeded478f1 Chris Wilson 2016-10-19 3040 i915_gem_object_unpin_map(obj);
894cf7d1563469 Chris Wilson 2016-10-19 3041 put_obj:
ffeaf9aaf97b4b fred gao 2017-08-16 3042 i915_gem_object_put(obj);
be1da7070aeaee Zhi Wang 2016-05-03 3043 return ret;
be1da7070aeaee Zhi Wang 2016-05-03 3044 }
be1da7070aeaee Zhi Wang 2016-05-03 3045
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 40830 bytes --]
next prev parent reply other threads:[~2021-05-27 13:33 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 14:14 [PATCH 00/12] Catchup with a few dropped patches Tvrtko Ursulin
2021-05-26 14:14 ` [Intel-gfx] " Tvrtko Ursulin
2021-05-26 14:14 ` [PATCH 01/12] drm/i915: Take rcu_read_lock for querying fence's driver/timeline names Tvrtko Ursulin
2021-05-26 14:14 ` [Intel-gfx] " Tvrtko Ursulin
2021-05-27 10:46 ` Daniel Vetter
2021-05-27 10:46 ` Daniel Vetter
2021-05-26 14:14 ` [PATCH 02/12] drm/i915: Remove notion of GEM from i915_gem_shrinker_taints_mutex Tvrtko Ursulin
2021-05-26 14:14 ` [Intel-gfx] " Tvrtko Ursulin
2021-05-26 14:14 ` [PATCH 03/12] drm/i915: Lift marking a lock as used to utils Tvrtko Ursulin
2021-05-26 14:14 ` [Intel-gfx] " Tvrtko Ursulin
2021-05-26 14:14 ` [PATCH 04/12] drm/i915: Wrap cmpxchg64 with try_cmpxchg64() helper Tvrtko Ursulin
2021-05-26 14:14 ` [Intel-gfx] " Tvrtko Ursulin
2021-05-26 14:14 ` [PATCH 05/12] drm/i915/selftests: Set cache status for huge_gem_object Tvrtko Ursulin
2021-05-26 14:14 ` [Intel-gfx] " Tvrtko Ursulin
2021-05-26 14:14 ` [PATCH 06/12] drm/i915/selftests: Use a coherent map to setup scratch batch buffers Tvrtko Ursulin
2021-05-26 14:14 ` [Intel-gfx] " Tvrtko Ursulin
2021-05-26 14:14 ` [PATCH 07/12] drm/i915/selftests: Replace the unbounded set-domain with an explicit wait Tvrtko Ursulin
2021-05-26 14:14 ` [Intel-gfx] " Tvrtko Ursulin
2021-05-26 14:14 ` [PATCH 08/12] drm/i915/selftests: Remove redundant set-to-gtt-domain Tvrtko Ursulin
2021-05-26 14:14 ` [Intel-gfx] " Tvrtko Ursulin
2021-05-26 14:14 ` [PATCH 09/12] drm/i915/selftests: Replace unbound set-domain waits with explicit timeouts Tvrtko Ursulin
2021-05-26 14:14 ` [Intel-gfx] " Tvrtko Ursulin
2021-05-26 14:14 ` [PATCH 10/12] drm/i915/selftests: Replace an unbounded set-domain wait with a timeout Tvrtko Ursulin
2021-05-26 14:14 ` [Intel-gfx] " Tvrtko Ursulin
2021-05-26 14:14 ` [PATCH 11/12] drm/i915/selftests: Remove redundant set-to-gtt-domain before batch submission Tvrtko Ursulin
2021-05-26 14:14 ` [Intel-gfx] " Tvrtko Ursulin
2021-05-26 14:14 ` [PATCH 12/12] drm/i915/gem: Manage all set-domain waits explicitly Tvrtko Ursulin
2021-05-26 14:14 ` [Intel-gfx] " Tvrtko Ursulin
2021-05-26 14:30 ` Matthew Auld
2021-05-26 14:30 ` [Intel-gfx] " Matthew Auld
2021-05-26 14:37 ` [PATCH v2 " Tvrtko Ursulin
2021-05-26 14:37 ` [Intel-gfx] " Tvrtko Ursulin
2021-05-27 10:44 ` [PATCH " Daniel Vetter
2021-05-27 10:44 ` [Intel-gfx] " Daniel Vetter
2021-05-27 13:33 ` kernel test robot [this message]
2021-05-26 20:19 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Catchup with a few dropped patches (rev2) Patchwork
2021-05-26 20:21 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-05-26 21:00 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202105272137.h8r1q1gI-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.