From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A2CAC4708C for ; Fri, 28 May 2021 09:15:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E1B496128D for ; Fri, 28 May 2021 09:15:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235889AbhE1JRa (ORCPT ); Fri, 28 May 2021 05:17:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235842AbhE1JR3 (ORCPT ); Fri, 28 May 2021 05:17:29 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06CF3C061574 for ; Fri, 28 May 2021 02:15:55 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1lmYat-0008AL-6K; Fri, 28 May 2021 11:15:51 +0200 Date: Fri, 28 May 2021 11:15:51 +0200 From: Florian Westphal To: Ali Abdallah Cc: netfilter-devel@vger.kernel.org Subject: Re: [PATCH] netfilter: conntrack: add new sysctl to disable RST check Message-ID: <20210528091551.GA30879@breakpoint.cc> References: <20210526092444.lca726ghsrli5fpx@Fryzen495> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210526092444.lca726ghsrli5fpx@Fryzen495> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Ali Abdallah wrote: > This patch adds a new sysctl tcp_ignore_invalid_rst to disable marking > out of segments RSTs as INVALID. Just for archives: I am not sure this is still needed after the recent change, but I can see why its desirable to keep NAT working even when RST is invalid. I think that the more fundamental problem is the inability to permit setting a conntrack as INVALID while allowing NAT to work, i.e. move drop decision to ruleset. However, I see that this isn't easy to change. Therefore, Reviewed-by: Florian Westphal