All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Amireddy Mallikarjuna reddy"
	<mallikarjunax.reddy@linux.intel.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Marek Behún" <marek.behun@nic.cz>,
	"Abanoub Sameh" <abanoubsameh8@gmail.com>,
	"Dan Murphy" <dmurphy@ti.com>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 00/28] leds: cleanups and fwnode refcounting bug fixes
Date: Fri, 28 May 2021 12:02:54 +0200	[thread overview]
Message-ID: <20210528100254.GC2209@amd> (raw)
In-Reply-To: <YKIbgBd3q8c+Tgz0@smile.fi.intel.com>

[-- Attachment #1: Type: text/plain, Size: 2124 bytes --]

On Mon 2021-05-17 10:30:08, Andy Shevchenko wrote:
> On Mon, May 10, 2021 at 12:50:17PM +0300, Andy Shevchenko wrote:
> > When analyzing the current state of affairs with fwnode reference counting
> > I found that a lot of core doesn't take it right. Here is a bunch of
> > corresponding fixes against LED drivers.
> > 
> > The series includes some cleanups and a few other fixes grouped by a driver.
> > 
> > First two patches are taking care of -ENOTSUPP error code too  prevent its
> > appearance in the user space.
> 
> Pavel, any comments on this bug fix series?

I took these:

95138e01275e1af3f1fc2780fe1d9c6138b29c7a leds: pwm: Make error
handling more robust
d33e98a1f3ee76f38668304f9ffce49af07da77a leds: lt3593: Make use of
device properties
f1e1d532da7e6ef355528a22fb97d9a8fbf76c4e leds: lp50xx: Put fwnode in
error case during ->probe()
807553f8bf4afa673750e52905e0f9488179112f leds: lm3697: Don't spam logs
when probe is deferred
f55db1c7fadc2a29c9fa4ff3aec98dbb111f2206 leds: lm3692x: Put fwnode in
any case during ->probe()
e2e8e4e8187509a77cb6328d876d9c09c07c2e82 leds: lm36274: Correct
headers (of*.h -> mod_devicetable.h)
3c5f655c44bb65cb7e3c219d08c130ce5fa45d7f leds: lm36274: Put fwnode in
error case during ->probe()
2f39f68cec0a19c0371c1e7cb149159810e87f64 leds: lm3532: Make error
handling more robust
99be74f61cb0292b518f5e6d7e5c6611555c2ec7 leds: lm3532: select regmap
I2C API
f3e2b3825ffb034b001fbe283d7a32a56e41aca7 leds: lgm-sso: Drop duplicate
NULL check for GPIO operations
2cbbe9c50d13b6417e0baf8e8475ed73d4d12c2d leds: lgm-sso: Remove
unneeded of_match_ptr()
fba8a6f2263bc54683cf3fd75df4dbd5d041c195 leds: lgm-sso: Fix clock
handling
a43a4e588e72bafc81924d61bf1167cd6810ecbb leds: el15203000: Introduce
to_el15203000_led() helper
0ac40af86077982a5346dbc9655172d2775d6b08 leds: class: The -ENOTSUPP
should never be seen by user space

For the "remove depends on OF"... I'd preffer not to take those. We
don't need to ask the user for configurations that never happen.

Best regards,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  parent reply	other threads:[~2021-05-28 10:03 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-10  9:50 [PATCH v1 00/28] leds: cleanups and fwnode refcounting bug fixes Andy Shevchenko
2021-05-10  9:50 ` [PATCH v1 01/28] leds: class: The -ENOTSUPP should never be seen by user space Andy Shevchenko
2021-05-10  9:50 ` [PATCH v1 02/28] leds: core: " Andy Shevchenko
2021-05-28 10:03   ` Pavel Machek
2021-05-28 10:43     ` Andy Shevchenko
2021-05-29  9:42       ` Andy Shevchenko
2021-05-10  9:50 ` [PATCH v1 03/28] leds: el15203000: Give better margin for usleep_range() Andy Shevchenko
2021-05-28 10:04   ` Pavel Machek
2021-05-28 10:45     ` Andy Shevchenko
2021-05-29  9:41       ` Andy Shevchenko
2021-05-10  9:50 ` [PATCH v1 04/28] leds: el15203000: Make error handling more robust Andy Shevchenko
2021-05-28 20:59   ` Oleh Kravchenko
2021-05-10  9:50 ` [PATCH v1 05/28] leds: el15203000: Correct headers (of*.h -> mod_devicetable.h) Andy Shevchenko
2021-05-28 21:00   ` Oleh Kravchenko
2021-05-29  9:45     ` Andy Shevchenko
2021-05-10  9:50 ` [PATCH v1 06/28] leds: el15203000: Introduce to_el15203000_led() helper Andy Shevchenko
2021-05-28 21:01   ` Oleh Kravchenko
2021-05-10  9:50 ` [PATCH v1 07/28] leds: lgm-sso: Fix clock handling Andy Shevchenko
2021-05-10  9:50 ` [PATCH v1 08/28] leds: lgm-sso: Put fwnode in any case during ->probe() Andy Shevchenko
2021-05-28 10:08   ` Pavel Machek
2021-05-28 10:46     ` Andy Shevchenko
2021-05-29  9:28     ` Andy Shevchenko
2021-05-29 10:46       ` Andy Shevchenko
2021-05-10  9:50 ` [PATCH v1 09/28] leds: lgm-sso: Don't spam logs when probe is deferred Andy Shevchenko
2021-05-28 10:11   ` Pavel Machek
2021-05-28 10:47     ` Andy Shevchenko
2021-05-29  9:54       ` Andy Shevchenko
2021-05-10  9:50 ` [PATCH v1 10/28] leds: lgm-sso: Remove unneeded of_match_ptr() Andy Shevchenko
2021-05-10  9:50 ` [PATCH v1 11/28] leds: lgm-sso: Remove explicit managed resource cleanups Andy Shevchenko
2021-05-28 10:09   ` Pavel Machek
2021-05-28 10:49     ` Andy Shevchenko
2021-05-29  9:46       ` Andy Shevchenko
2021-05-10  9:50 ` [PATCH v1 12/28] leds: lgm-sso: Drop duplicate NULL check for GPIO operations Andy Shevchenko
2021-05-10  9:50 ` [PATCH v1 13/28] leds: lgm-sso: Convert to use list_for_each_entry*() API Andy Shevchenko
2021-05-10  9:50 ` [PATCH v1 14/28] leds: lm3532: select regmap I2C API Andy Shevchenko
2021-05-10  9:50 ` [PATCH v1 15/28] leds: lm3532: Make error handling more robust Andy Shevchenko
2021-05-10  9:50 ` [PATCH v1 16/28] leds: lm36274: Put fwnode in error case during ->probe() Andy Shevchenko
2021-05-10  9:50 ` [PATCH v1 17/28] leds: lm36274: Correct headers (of*.h -> mod_devicetable.h) Andy Shevchenko
2021-05-10  9:50 ` [PATCH v1 18/28] leds: lm3692x: Put fwnode in any case during ->probe() Andy Shevchenko
2021-05-10  9:50 ` [PATCH v1 19/28] leds: lm3692x: Correct headers (of*.h -> mod_devicetable.h) Andy Shevchenko
2021-05-10  9:50 ` [PATCH v1 20/28] leds: lm3697: Update header block to reflect reality Andy Shevchenko
2021-05-10  9:50 ` [PATCH v1 21/28] leds: lm3697: Make error handling more robust Andy Shevchenko
2021-05-28 10:10   ` Pavel Machek
2021-05-28 10:50     ` Andy Shevchenko
2021-05-29  9:50       ` Andy Shevchenko
2021-05-10  9:50 ` [PATCH v1 22/28] leds: lm3697: Don't spam logs when probe is deferred Andy Shevchenko
2021-05-10  9:50 ` [PATCH v1 23/28] leds: lp50xx: Put fwnode in error case during ->probe() Andy Shevchenko
2021-05-10  9:50 ` [PATCH v1 24/28] leds: lt3593: Put fwnode in any " Andy Shevchenko
2021-05-10  9:50 ` [PATCH v1 25/28] leds: lt3593: Make use of device properties Andy Shevchenko
2021-05-10  9:50 ` [PATCH v1 26/28] leds: pwm: Make error handling more robust Andy Shevchenko
2021-05-10  9:50 ` [PATCH v1 27/28] leds: rt8515: Put fwnode in any case during ->probe() Andy Shevchenko
2021-05-10  9:50 ` [PATCH v1 28/28] leds: sgm3140: " Andy Shevchenko
2021-05-28 10:14   ` Pavel Machek
2021-05-28 10:59     ` Andy Shevchenko
2021-05-29  9:58       ` Andy Shevchenko
2021-05-17  7:30 ` [PATCH v1 00/28] leds: cleanups and fwnode refcounting bug fixes Andy Shevchenko
2021-05-24 14:56   ` Andy Shevchenko
2021-05-24 17:49     ` Pavel Machek
2021-05-24 18:39       ` Andy Shevchenko
2021-05-28 10:02   ` Pavel Machek [this message]
2021-05-28 11:05     ` Andy Shevchenko
2021-05-28 20:34       ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210528100254.GC2209@amd \
    --to=pavel@ucw.cz \
    --cc=abanoubsameh8@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=dmurphy@ti.com \
    --cc=krzk@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=mallikarjunax.reddy@linux.intel.com \
    --cc=marek.behun@nic.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.