Re: [PATCH RFC bpf-next 3/7] net: sched: add bpf_link API for bpf classifier

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 7143 bytes --]

Hi Kumar,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on bpf-next/master]

url:    https://github.com/0day-ci/linux/commits/Kumar-Kartikeya-Dwivedi/Add-bpf_link-based-TC-BPF-API/20210529-040147
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: i386-randconfig-s002-20210528 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-341-g8af24329-dirty
        # https://github.com/0day-ci/linux/commit/7f3d2ad7de9869028e50b1749a8144ccb75a76b8
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Kumar-Kartikeya-Dwivedi/Add-bpf_link-based-TC-BPF-API/20210529-040147
        git checkout 7f3d2ad7de9869028e50b1749a8144ccb75a76b8
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
   net/sched/cls_api.c:270:22: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __be16 [usertype] protocol @@     got unsigned int [usertype] protocol @@
   net/sched/cls_api.c:270:22: sparse:     expected restricted __be16 [usertype] protocol
   net/sched/cls_api.c:270:22: sparse:     got unsigned int [usertype] protocol
   net/sched/cls_api.c:1675:16: sparse: sparse: incompatible types in comparison expression (different address spaces):
   net/sched/cls_api.c:1675:16: sparse:    struct tcf_proto *
   net/sched/cls_api.c:1675:16: sparse:    struct tcf_proto [noderef] __rcu *
   net/sched/cls_api.c:1776:20: sparse: sparse: incompatible types in comparison expression (different address spaces):
   net/sched/cls_api.c:1776:20: sparse:    struct tcf_proto [noderef] __rcu *
   net/sched/cls_api.c:1776:20: sparse:    struct tcf_proto *
   net/sched/cls_api.c:1737:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
   net/sched/cls_api.c:1737:25: sparse:    struct tcf_proto [noderef] __rcu *
   net/sched/cls_api.c:1737:25: sparse:    struct tcf_proto *
   net/sched/cls_api.c:1757:16: sparse: sparse: incompatible types in comparison expression (different address spaces):
   net/sched/cls_api.c:1757:16: sparse:    struct tcf_proto *
   net/sched/cls_api.c:1757:16: sparse:    struct tcf_proto [noderef] __rcu *
   net/sched/cls_api.c:1823:25: sparse: sparse: restricted __be16 degrades to integer
   net/sched/cls_api.c:2497:50: sparse: sparse: restricted __be16 degrades to integer
>> net/sched/cls_api.c:3950:18: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned int [usertype] protocol @@     got restricted __be16 [usertype] @@
   net/sched/cls_api.c:3950:18: sparse:     expected unsigned int [usertype] protocol
   net/sched/cls_api.c:3950:18: sparse:     got restricted __be16 [usertype]

vim +3950 net/sched/cls_api.c

  3924	
  3925	int bpf_tc_link_attach(union bpf_attr *attr, struct bpf_prog *prog)
  3926	{
  3927		struct net *net = current->nsproxy->net_ns;
  3928		u32 chain_index, prio, protocol, parent;
  3929		struct tcf_chain_info chain_info;
  3930		struct tcf_block *block;
  3931		struct tcf_chain *chain;
  3932		struct tcf_proto *tp;
  3933		int err, tp_created;
  3934		unsigned long cl;
  3935		struct Qdisc *q;
  3936		void *fh;
  3937	
  3938		/* Caller already checks bpf_capable */
  3939		if (!ns_capable(current->nsproxy->net_ns->user_ns, CAP_NET_ADMIN))
  3940			return -EPERM;
  3941	
  3942		if (attr->link_create.flags ||
  3943		    !attr->link_create.target_ifindex ||
  3944		    !tc_flags_valid(attr->link_create.tc.gen_flags))
  3945			return -EINVAL;
  3946	
  3947	replay:
  3948		parent = attr->link_create.tc.parent;
  3949		prio = attr->link_create.tc.priority;
> 3950		protocol = htons(ETH_P_ALL);
  3951		chain_index = 0;
  3952		tp_created = 0;
  3953		prio <<= 16;
  3954		cl = 0;
  3955	
  3956		/* Address this when cls_bpf switches to RTNL_FLAG_DOIT_UNLOCKED */
  3957		rtnl_lock();
  3958	
  3959		block = tcf_block_find(net, &q, &parent, &cl,
  3960				       attr->link_create.target_ifindex, parent, NULL);
  3961		if (IS_ERR(block)) {
  3962			err = PTR_ERR(block);
  3963			goto out_unlock;
  3964		}
  3965		block->classid = parent;
  3966	
  3967		chain = tcf_chain_get(block, chain_index, true);
  3968		if (!chain) {
  3969			err = -ENOMEM;
  3970			goto out_block;
  3971		}
  3972	
  3973		mutex_lock(&chain->filter_chain_lock);
  3974	
  3975		tp = tcf_chain_tp_find(chain, &chain_info, protocol,
  3976				       prio ?: TC_H_MAKE(0x80000000U, 0U),
  3977				       !prio);
  3978		if (IS_ERR(tp)) {
  3979			err = PTR_ERR(tp);
  3980			goto out_chain_unlock;
  3981		}
  3982	
  3983		if (!tp) {
  3984			struct tcf_proto *tp_new = NULL;
  3985	
  3986			if (chain->flushing) {
  3987				err = -EAGAIN;
  3988				goto out_chain_unlock;
  3989			}
  3990	
  3991			if (!prio)
  3992				prio = tcf_auto_prio(tcf_chain_tp_prev(chain,
  3993								       &chain_info));
  3994	
  3995			mutex_unlock(&chain->filter_chain_lock);
  3996	
  3997			tp_new = tcf_proto_create("bpf", protocol, prio, chain, true,
  3998						  NULL);
  3999			if (IS_ERR(tp_new)) {
  4000				err = PTR_ERR(tp_new);
  4001				goto out_chain;
  4002			}
  4003	
  4004			tp_created = 1;
  4005			tp = tcf_chain_tp_insert_unique(chain, tp_new, protocol, prio,
  4006							true);
  4007			if (IS_ERR(tp)) {
  4008				err = PTR_ERR(tp);
  4009				goto out_chain;
  4010			}
  4011		} else {
  4012			mutex_unlock(&chain->filter_chain_lock);
  4013		}
  4014	
  4015		fh = tp->ops->get(tp, attr->link_create.tc.handle);
  4016	
  4017		if (!tp->ops->bpf_link_change)
  4018			err = -EDEADLK;
  4019		else
  4020			err = tp->ops->bpf_link_change(net, tp, prog, &fh,
  4021						       attr->link_create.tc.handle,
  4022						       attr->link_create.tc.gen_flags);
  4023		if (err >= 0 && q)
  4024			q->flags &= ~TCQ_F_CAN_BYPASS;
  4025	
  4026	out:
  4027		if (err < 0 && tp_created)
  4028			tcf_chain_tp_delete_empty(chain, tp, true, NULL);
  4029	out_chain:
  4030		if (chain) {
  4031			if (!IS_ERR_OR_NULL(tp))
  4032				tcf_proto_put(tp, true, NULL);
  4033			/* Chain reference only kept for tp creation
  4034			 * to pair with tcf_chain_put from tcf_proto_destroy
  4035			 */
  4036			if (!tp_created)
  4037				tcf_chain_put(chain);
  4038		}
  4039	out_block:
  4040		tcf_block_release(q, block, true);
  4041	out_unlock:
  4042		rtnl_unlock();
  4043		if (err == -EAGAIN)
  4044			goto replay;
  4045		return err;
  4046	out_chain_unlock:
  4047		mutex_unlock(&chain->filter_chain_lock);
  4048		goto out;
  4049	}
  4050	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 37302 bytes --]