From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1516AC4708F for ; Mon, 31 May 2021 07:40:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC53560C3F for ; Mon, 31 May 2021 07:40:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230428AbhEaHls (ORCPT ); Mon, 31 May 2021 03:41:48 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:60636 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230366AbhEaHlE (ORCPT ); Mon, 31 May 2021 03:41:04 -0400 Received: from mail-wr1-f70.google.com ([209.85.221.70]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lncWA-00039R-Ue for linux-kernel@vger.kernel.org; Mon, 31 May 2021 07:39:22 +0000 Received: by mail-wr1-f70.google.com with SMTP id s8-20020adff8080000b0290114e1eeb8c6so1547615wrp.23 for ; Mon, 31 May 2021 00:39:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4J89KlzzqThKgmZLnM37DvaB3SqI47fv9hR1FCtpA64=; b=XtvRcBHyd+OsOJ4HlG74Lz7RQbQ28tzIdyaPn/pbTDXoB22VSi2iYAGmV+vZhw8Ffl 7VFyUlVsF2wge1/fd0dTM6oTgiMiZ4c/dTEMbXkwA/KyjgV2JUdHmZ/Kifwxz1/iwIvi epsOzdHM9GXOrq4v+qgSrz5aB6Bte+8f68RcKPcU1TwqITUc6MyZ3o0Ms6YfN8spNjar EfBfwdlaHsKPGf77TbQAEXUs8tAqW2mAzTIpjc399jWYgRi01Hpeh6TxAwVhjjZHUp4f WE+R439amMuWpyrZMjaf/KUS/LwJg6CuYRT1ZO5efBXXHhumWqC5m0vCHlfwAOWoSBpP JmGQ== X-Gm-Message-State: AOAM530es5mv+C7rCjqw1JhwOI3NMnkONuGP3JMgCzn5Mpt4pxcl3coY ssi6ltzBqKksErZVTi5JSMyQeno4lR0FSPa4kfaEiMbRE/5VEyQod9nFdj9uHI6PftH1Hu8bjJ6 rRPa2TewXOaeVsSpzvSmjhp7B8akIaRzcYi+RHwYpmA== X-Received: by 2002:a05:600c:2948:: with SMTP id n8mr24706747wmd.95.1622446762291; Mon, 31 May 2021 00:39:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxoc0eYdm0Gad3jKfILWO0BlkrBHmb4+ihv28lP2KSvG+Az7qWFv7kizSOlAt+HwZQaPXWCeQ== X-Received: by 2002:a05:600c:2948:: with SMTP id n8mr24706734wmd.95.1622446762165; Mon, 31 May 2021 00:39:22 -0700 (PDT) Received: from localhost.localdomain (xdsl-188-155-185-9.adslplus.ch. [188.155.185.9]) by smtp.gmail.com with ESMTPSA id a1sm9168911wrg.92.2021.05.31.00.39.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 May 2021 00:39:21 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , "David S. Miller" , Jakub Kicinski , linux-nfc@lists.01.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RESEND PATCH 09/11] nfc: st21nfca: drop ftrace-like debugging messages Date: Mon, 31 May 2021 09:39:00 +0200 Message-Id: <20210531073902.7111-5-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210531073522.6720-1-krzysztof.kozlowski@canonical.com> References: <20210531073522.6720-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Now that the kernel has ftrace, any debugging calls that just do "made it to this function!" and "leaving this function!" can be removed. Better to use standard debugging tools. Signed-off-by: Krzysztof Kozlowski --- drivers/nfc/st21nfca/i2c.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/nfc/st21nfca/i2c.c b/drivers/nfc/st21nfca/i2c.c index cebc6c06a1b6..7a9f4d71707e 100644 --- a/drivers/nfc/st21nfca/i2c.c +++ b/drivers/nfc/st21nfca/i2c.c @@ -502,9 +502,6 @@ static int st21nfca_hci_i2c_probe(struct i2c_client *client, struct st21nfca_i2c_phy *phy; int r; - dev_dbg(&client->dev, "%s\n", __func__); - dev_dbg(&client->dev, "IRQ: %d\n", client->irq); - if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) { nfc_err(&client->dev, "Need I2C_FUNC_I2C\n"); return -ENODEV; @@ -568,8 +565,6 @@ static int st21nfca_hci_i2c_remove(struct i2c_client *client) { struct st21nfca_i2c_phy *phy = i2c_get_clientdata(client); - dev_dbg(&client->dev, "%s\n", __func__); - st21nfca_hci_remove(phy->hdev); if (phy->powered) -- 2.27.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CD36C4708F for ; Mon, 31 May 2021 07:39:27 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5B55C61220 for ; Mon, 31 May 2021 07:39:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B55C61220 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nfc-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 3FF09100EC1E3; Mon, 31 May 2021 00:39:27 -0700 (PDT) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=91.189.89.112; helo=youngberry.canonical.com; envelope-from=krzysztof.kozlowski@canonical.com; receiver= Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0A424100EC1D7 for ; Mon, 31 May 2021 00:39:23 -0700 (PDT) Received: from mail-wr1-f72.google.com ([209.85.221.72]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lncWA-000394-Fz for linux-nfc@lists.01.org; Mon, 31 May 2021 07:39:22 +0000 Received: by mail-wr1-f72.google.com with SMTP id q15-20020adfc50f0000b0290111f48b865cso3643311wrf.4 for ; Mon, 31 May 2021 00:39:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4J89KlzzqThKgmZLnM37DvaB3SqI47fv9hR1FCtpA64=; b=pWtmQPCkeKgAzspkqfcIMAFUpZkEbAvBGY+JSB/hY9B1uTr++XSyD/avbgJE6pxwKg a4ijjfwIcQYEyQ3VHOTLWEeiZcesCP0jwAR41R5MIZ7KE8xEu0PgO1FQR0+VW8owBNE7 NLnuZY0tTulXY4CF9RUxxcZqfngglHHdel362tZdtPJEzk+pQA8qBo1swyZykbVnx1+N GgQ//mrir6tgKN1WcJ3uq+R4h43ZMlhIJObfmPgEuCEGUUIjftgY1R/ufLE2HmPY+/iE Zd6tftnZYoxc1AwJ1IQ8d5/AurAulw3ztbt2ord9DYj35pmQlFIpCgC3fum0W7RPyK/y tN6g== X-Gm-Message-State: AOAM531ffSwgr+gegXyqKdXimTZajYIUrkBHgErI2UsBb6qAOzKSpEWE 0E+5z/97MEvOYZYkucTRQZVRj0CqrCdZUqmGvyQ3+3krTT/eWOUTEwmzNwEkn4iIfwJ92CJ5VZR yXlkzK/RxiLPB2KViNfXXPakHV5fzLDWaUg== X-Received: by 2002:a05:600c:2948:: with SMTP id n8mr24706753wmd.95.1622446762302; Mon, 31 May 2021 00:39:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxoc0eYdm0Gad3jKfILWO0BlkrBHmb4+ihv28lP2KSvG+Az7qWFv7kizSOlAt+HwZQaPXWCeQ== X-Received: by 2002:a05:600c:2948:: with SMTP id n8mr24706734wmd.95.1622446762165; Mon, 31 May 2021 00:39:22 -0700 (PDT) Received: from localhost.localdomain (xdsl-188-155-185-9.adslplus.ch. [188.155.185.9]) by smtp.gmail.com with ESMTPSA id a1sm9168911wrg.92.2021.05.31.00.39.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 May 2021 00:39:21 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , "David S. Miller" , Jakub Kicinski , linux-nfc@lists.01.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 31 May 2021 09:39:00 +0200 Message-Id: <20210531073902.7111-5-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210531073522.6720-1-krzysztof.kozlowski@canonical.com> References: <20210531073522.6720-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Message-ID-Hash: ZVJNNBRD3R7YUGD26HHO7FZNUT5RX2T7 X-Message-ID-Hash: ZVJNNBRD3R7YUGD26HHO7FZNUT5RX2T7 X-MailFrom: krzysztof.kozlowski@canonical.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.1.1 Precedence: list Subject: [linux-nfc] [RESEND PATCH 09/11] nfc: st21nfca: drop ftrace-like debugging messages List-Id: NFC on Linux Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Now that the kernel has ftrace, any debugging calls that just do "made it to this function!" and "leaving this function!" can be removed. Better to use standard debugging tools. Signed-off-by: Krzysztof Kozlowski --- drivers/nfc/st21nfca/i2c.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/nfc/st21nfca/i2c.c b/drivers/nfc/st21nfca/i2c.c index cebc6c06a1b6..7a9f4d71707e 100644 --- a/drivers/nfc/st21nfca/i2c.c +++ b/drivers/nfc/st21nfca/i2c.c @@ -502,9 +502,6 @@ static int st21nfca_hci_i2c_probe(struct i2c_client *client, struct st21nfca_i2c_phy *phy; int r; - dev_dbg(&client->dev, "%s\n", __func__); - dev_dbg(&client->dev, "IRQ: %d\n", client->irq); - if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) { nfc_err(&client->dev, "Need I2C_FUNC_I2C\n"); return -ENODEV; @@ -568,8 +565,6 @@ static int st21nfca_hci_i2c_remove(struct i2c_client *client) { struct st21nfca_i2c_phy *phy = i2c_get_clientdata(client); - dev_dbg(&client->dev, "%s\n", __func__); - st21nfca_hci_remove(phy->hdev); if (phy->powered) -- 2.27.0 _______________________________________________ Linux-nfc mailing list -- linux-nfc@lists.01.org To unsubscribe send an email to linux-nfc-leave@lists.01.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============2933856378716565363==" MIME-Version: 1.0 From: Krzysztof Kozlowski To: linux-nfc@lists.01.org Subject: [RESEND PATCH 09/11] nfc: st21nfca: drop ftrace-like debugging messages Date: Mon, 31 May 2021 09:39:00 +0200 Message-ID: <20210531073902.7111-5-krzysztof.kozlowski@canonical.com> In-Reply-To: <20210531073522.6720-1-krzysztof.kozlowski@canonical.com> List-Id: --===============2933856378716565363== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Now that the kernel has ftrace, any debugging calls that just do "made it to this function!" and "leaving this function!" can be removed. Better to use standard debugging tools. Signed-off-by: Krzysztof Kozlowski --- drivers/nfc/st21nfca/i2c.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/nfc/st21nfca/i2c.c b/drivers/nfc/st21nfca/i2c.c index cebc6c06a1b6..7a9f4d71707e 100644 --- a/drivers/nfc/st21nfca/i2c.c +++ b/drivers/nfc/st21nfca/i2c.c @@ -502,9 +502,6 @@ static int st21nfca_hci_i2c_probe(struct i2c_client *cl= ient, struct st21nfca_i2c_phy *phy; int r; = - dev_dbg(&client->dev, "%s\n", __func__); - dev_dbg(&client->dev, "IRQ: %d\n", client->irq); - if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) { nfc_err(&client->dev, "Need I2C_FUNC_I2C\n"); return -ENODEV; @@ -568,8 +565,6 @@ static int st21nfca_hci_i2c_remove(struct i2c_client *c= lient) { struct st21nfca_i2c_phy *phy =3D i2c_get_clientdata(client); = - dev_dbg(&client->dev, "%s\n", __func__); - st21nfca_hci_remove(phy->hdev); = if (phy->powered) -- = 2.27.0 --===============2933856378716565363==--