* [PATCH] riscv: fix typo in init.c
@ 2021-05-30 13:22 Vitaly Wool
2021-05-31 0:11 ` Jisheng Zhang
0 siblings, 1 reply; 3+ messages in thread
From: Vitaly Wool @ 2021-05-30 13:22 UTC (permalink / raw)
To: linux-riscv; +Cc: Palmer Dabbelt, Jisheng Zhang, Vitaly Wool
Commit 010623568222 introduced a typo in "__initdata" spelling
which led to build breakage for XIP. Fix that.
Fixes: 010623568222bd144eb73aa9f3b46c79b63d7676
Signed-off-by: Vitaly Wool <vitaly.wool@konsulko.com>
---
arch/riscv/mm/init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
index ae32f78207f0..e7b136abf90c 100644
--- a/arch/riscv/mm/init.c
+++ b/arch/riscv/mm/init.c
@@ -451,7 +451,7 @@ static uintptr_t load_sz __initdata;
#endif
#ifdef CONFIG_XIP_KERNEL
-static uintptr_t xiprom __inidata;
+static uintptr_t xiprom __initdata;
static uintptr_t xiprom_sz __initdata;
#define xiprom_sz (*((uintptr_t *)XIP_FIXUP(&xiprom_sz)))
#define xiprom (*((uintptr_t *)XIP_FIXUP(&xiprom)))
--
2.29.2
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] riscv: fix typo in init.c
2021-05-30 13:22 [PATCH] riscv: fix typo in init.c Vitaly Wool
@ 2021-05-31 0:11 ` Jisheng Zhang
2021-06-08 7:56 ` Jisheng Zhang
0 siblings, 1 reply; 3+ messages in thread
From: Jisheng Zhang @ 2021-05-31 0:11 UTC (permalink / raw)
To: Vitaly Wool; +Cc: linux-riscv, Palmer Dabbelt, Jisheng Zhang
On Sun, 30 May 2021 16:22:17 +0300
Vitaly Wool <vitaly.wool@konsulko.com> wrote:
> Commit 010623568222 introduced a typo in "__initdata" spelling
> which led to build breakage for XIP. Fix that.
oops, nice catch! Sorry for that.
>
> Fixes: 010623568222bd144eb73aa9f3b46c79b63d7676
This "Fixes" tag seems not correct.Should be
Fixes: 010623568222 ("riscv: mm: init: Consolidate vars, functions")
After this change,
Reviewed-by: Jisheng Zhang <jszhang@kernel.org>
> Signed-off-by: Vitaly Wool <vitaly.wool@konsulko.com>
> ---
> arch/riscv/mm/init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
> index ae32f78207f0..e7b136abf90c 100644
> --- a/arch/riscv/mm/init.c
> +++ b/arch/riscv/mm/init.c
> @@ -451,7 +451,7 @@ static uintptr_t load_sz __initdata;
> #endif
>
> #ifdef CONFIG_XIP_KERNEL
> -static uintptr_t xiprom __inidata;
> +static uintptr_t xiprom __initdata;
> static uintptr_t xiprom_sz __initdata;
> #define xiprom_sz (*((uintptr_t *)XIP_FIXUP(&xiprom_sz)))
> #define xiprom (*((uintptr_t *)XIP_FIXUP(&xiprom)))
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] riscv: fix typo in init.c
2021-05-31 0:11 ` Jisheng Zhang
@ 2021-06-08 7:56 ` Jisheng Zhang
0 siblings, 0 replies; 3+ messages in thread
From: Jisheng Zhang @ 2021-06-08 7:56 UTC (permalink / raw)
To: Jisheng Zhang; +Cc: Vitaly Wool, linux-riscv, Palmer Dabbelt, Jisheng Zhang
On Mon, 31 May 2021 08:11:40 +0800
Jisheng Zhang <jszhang3@mail.ustc.edu.cn> wrote:
>
>
> On Sun, 30 May 2021 16:22:17 +0300
> Vitaly Wool <vitaly.wool@konsulko.com> wrote:
>
> > Commit 010623568222 introduced a typo in "__initdata" spelling
> > which led to build breakage for XIP. Fix that.
>
> oops, nice catch! Sorry for that.
>
> >
> > Fixes: 010623568222bd144eb73aa9f3b46c79b63d7676
>
> This "Fixes" tag seems not correct.Should be
> Fixes: 010623568222 ("riscv: mm: init: Consolidate vars, functions")
Hi Vitaly,
Could you plz send a v2 for this?
Regards
>
> After this change,
> Reviewed-by: Jisheng Zhang <jszhang@kernel.org>
>
> > Signed-off-by: Vitaly Wool <vitaly.wool@konsulko.com>
> > ---
> > arch/riscv/mm/init.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
> > index ae32f78207f0..e7b136abf90c 100644
> > --- a/arch/riscv/mm/init.c
> > +++ b/arch/riscv/mm/init.c
> > @@ -451,7 +451,7 @@ static uintptr_t load_sz __initdata;
> > #endif
> >
> > #ifdef CONFIG_XIP_KERNEL
> > -static uintptr_t xiprom __inidata;
> > +static uintptr_t xiprom __initdata;
> > static uintptr_t xiprom_sz __initdata;
> > #define xiprom_sz (*((uintptr_t *)XIP_FIXUP(&xiprom_sz)))
> > #define xiprom (*((uintptr_t *)XIP_FIXUP(&xiprom)))
>
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-08 7:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-30 13:22 [PATCH] riscv: fix typo in init.c Vitaly Wool
2021-05-31 0:11 ` Jisheng Zhang
2021-06-08 7:56 ` Jisheng Zhang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.