From: Jakub Kicinski <kuba@kernel.org>
To: Justin Iurman <justin.iurman@uliege.be>
Cc: netdev@vger.kernel.org, davem@davemloft.net, tom@herbertland.com
Subject: Re: [PATCH net-next v4 2/5] ipv6: ioam: Data plane support for Pre-allocated Trace
Date: Mon, 31 May 2021 21:21:45 -0700 [thread overview]
Message-ID: <20210531212145.359f1fed@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> (raw)
In-Reply-To: <915310398.35293280.1622461417600.JavaMail.zimbra@uliege.be>
On Mon, 31 May 2021 13:43:37 +0200 (CEST) Justin Iurman wrote:
> > BTW the ASCII art in patch 1 looks like node data is filled in in order
>
> I agree, this one could be quite confusing without the related
> paragraph in the draft that explains it. Two possibilities here: (a)
> add the paragraph in the patch description to remove ambiguity; or
> (b) revert indexes in the ASCII art (from n to 0). Thoughts?
Inverting the indexes in the ASCII art would make it clear enough
for me.
> > but:
> >
> > + data = trace->data + trace->remlen * 4 - trace->nodelen *
> > 4 - sclen * 4;
> >
> > Looks like we'd start from the last node data?
>
> Correct, it works as a stack from bottom (end of the pre-allocated
> space) to top (start of the pre-allocated space).
next prev parent reply other threads:[~2021-06-01 4:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 15:16 [PATCH net-next v4 0/5] Support for the IOAM Pre-allocated Trace with IPv6 Justin Iurman
2021-05-27 15:16 ` [PATCH net-next v4 1/5] uapi: IPv6 IOAM headers definition Justin Iurman
2021-05-27 15:16 ` [PATCH net-next v4 2/5] ipv6: ioam: Data plane support for Pre-allocated Trace Justin Iurman
2021-05-29 21:05 ` Jakub Kicinski
2021-05-30 10:36 ` Justin Iurman
2021-05-30 14:50 ` Justin Iurman
2021-05-30 20:05 ` Jakub Kicinski
2021-05-31 11:50 ` Justin Iurman
2021-06-01 4:20 ` Jakub Kicinski
2021-05-30 20:02 ` Jakub Kicinski
2021-05-31 11:43 ` Justin Iurman
2021-06-01 4:21 ` Jakub Kicinski [this message]
2021-05-27 15:16 ` [PATCH net-next v4 3/5] ipv6: ioam: IOAM Generic Netlink API Justin Iurman
2021-05-29 21:06 ` Jakub Kicinski
2021-05-30 11:18 ` Justin Iurman
2021-05-30 20:13 ` Jakub Kicinski
2021-05-27 15:16 ` [PATCH net-next v4 4/5] ipv6: ioam: Support for IOAM injection with lwtunnels Justin Iurman
2021-05-29 21:06 ` Jakub Kicinski
2021-05-30 10:48 ` Justin Iurman
2021-05-27 15:16 ` [PATCH net-next v4 5/5] ipv6: ioam: Documentation for new IOAM sysctls Justin Iurman
2021-05-29 15:58 ` [PATCH net-next v4 0/5] Support for the IOAM Pre-allocated Trace with IPv6 David Ahern
2021-05-29 16:24 ` Justin Iurman
2021-05-31 1:24 ` David Ahern
2021-05-31 12:04 ` Justin Iurman
2021-06-03 3:31 ` David Ahern
2021-05-29 21:10 ` Jakub Kicinski
2021-05-30 10:49 ` Justin Iurman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210531212145.359f1fed@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=justin.iurman@uliege.be \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.