From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC45DC4708F for ; Tue, 1 Jun 2021 14:31:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 875C3610C9 for ; Tue, 1 Jun 2021 14:31:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234196AbhFAOdO (ORCPT ); Tue, 1 Jun 2021 10:33:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233924AbhFAOdN (ORCPT ); Tue, 1 Jun 2021 10:33:13 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E59A5C061574 for ; Tue, 1 Jun 2021 07:31:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=gEtXdDu9+lsKZpSpI0/uAo+3rlyBLyfsQkhGtLtsn78=; b=IFamQIF3iLk8EIixhE2reGtgZ z9q2OS6QUH8dvO+XprikEl92iTvBIjJNNcA1tsARxVbrPE7q6EYZ5UOFdcXq6M8+iB2HKDa9SGFsb CoOSnpCPPfwjUsIk/+9awLO0rKoTX72q7iwxAer5vWowFOoQtkchKn4/CUyyPS6JN5DgHl0hKeSSw r7Yu9jbnNJyLFqvLQvOdFDyiSOED4j7DGgnn5YeHwIaKpqw8QVRvq+gLBMCD+J2uQZsTHL67e3L5r ZsJDy+yKmDH5yotV+/LtXDZMAS71Wjap3l2BIzy0khU5XsXbaYDX4GaMcPgUCdzj1Oz1O3qRwrtqI DzVF/8zUQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44582) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lo5QV-0004DG-2d; Tue, 01 Jun 2021 15:31:28 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lo5QU-0000CY-34; Tue, 01 Jun 2021 15:31:26 +0100 Date: Tue, 1 Jun 2021 15:31:26 +0100 From: "Russell King (Oracle)" To: Kefeng Wang Cc: linux-arm-kernel@lists.infradead.org, Catalin Marinas , linux-kernel@vger.kernel.org, Andrew Morton , Jungseung Lee Subject: Re: [PATCH 1/2] ARM: mm: Refactor __do_page_fault() Message-ID: <20210601143125.GB30436@shell.armlinux.org.uk> References: <20210529034138.83384-1-wangkefeng.wang@huawei.com> <20210529034138.83384-2-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210529034138.83384-2-wangkefeng.wang@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 29, 2021 at 11:41:37AM +0800, Kefeng Wang wrote: > 1. cleanup access_error(), make vma flags set and check into > __do_page_fault() and do_page_fault() directly. > > 2. drop fsr and task argument, instead, using vm_flags in > __do_page_fault(). > > 3. cleans up the multiple goto statements in __do_page_fault(). > > 4. use current->mm directly in do_page_fault(). > > Signed-off-by: Kefeng Wang This patch is a really good example of something that is very difficult to review and see that there are no unintended changes. Many people have complained about my patches, where I create a series of many patches where each patch does exactly _one_ simple transformation to the code. This is a good example _why_ I do that - a step by step single transformation approach is way easier to review. Sorry, but I'm not able to sensibly review this patch, and therefore I won't apply it. Please split it into smaller changes. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D493DC4708F for ; Tue, 1 Jun 2021 14:33:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B0A96124B for ; Tue, 1 Jun 2021 14:33:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B0A96124B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8uCdAAYMUzNyYwBUskh+RGr4YhOulH29MdE9r0+sGc8=; b=2A8bEteciRLgoU eVfJUrajUGhaa9iblGdO4FnKGVw/cOO4QhZJZxnHmmicrPDgx1csq67blh6INiT2UOhV+pwmKP8fZ JohRsLH/CpkRILM/PHaD7IlGyG1eLUW8Khf99puoJzNDkMqFGJryNMnx7vGPgBPmO32A7CQ+sS1Tb K0YGQJB5wrdJVO8za2VeSX7j3sOz5YdTMQdBvl3vzZq30+8O8wIL6Lwzn+meK+hTDNS0ExqI0Z54o BBNZv2yYHfzsNgAr04ZqB1SKlDzk+0j7kr8vcTOW4rvbisGo3UAUlGCSruvJkn2jYtJNvo7JR8H20 EiOety+XeHlRrTuoc5EQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lo5Qd-00GyxH-8b; Tue, 01 Jun 2021 14:31:35 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lo5QZ-00Gywo-3m for linux-arm-kernel@lists.infradead.org; Tue, 01 Jun 2021 14:31:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=gEtXdDu9+lsKZpSpI0/uAo+3rlyBLyfsQkhGtLtsn78=; b=IFamQIF3iLk8EIixhE2reGtgZ z9q2OS6QUH8dvO+XprikEl92iTvBIjJNNcA1tsARxVbrPE7q6EYZ5UOFdcXq6M8+iB2HKDa9SGFsb CoOSnpCPPfwjUsIk/+9awLO0rKoTX72q7iwxAer5vWowFOoQtkchKn4/CUyyPS6JN5DgHl0hKeSSw r7Yu9jbnNJyLFqvLQvOdFDyiSOED4j7DGgnn5YeHwIaKpqw8QVRvq+gLBMCD+J2uQZsTHL67e3L5r ZsJDy+yKmDH5yotV+/LtXDZMAS71Wjap3l2BIzy0khU5XsXbaYDX4GaMcPgUCdzj1Oz1O3qRwrtqI DzVF/8zUQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44582) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lo5QV-0004DG-2d; Tue, 01 Jun 2021 15:31:28 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lo5QU-0000CY-34; Tue, 01 Jun 2021 15:31:26 +0100 Date: Tue, 1 Jun 2021 15:31:26 +0100 From: "Russell King (Oracle)" To: Kefeng Wang Cc: linux-arm-kernel@lists.infradead.org, Catalin Marinas , linux-kernel@vger.kernel.org, Andrew Morton , Jungseung Lee Subject: Re: [PATCH 1/2] ARM: mm: Refactor __do_page_fault() Message-ID: <20210601143125.GB30436@shell.armlinux.org.uk> References: <20210529034138.83384-1-wangkefeng.wang@huawei.com> <20210529034138.83384-2-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210529034138.83384-2-wangkefeng.wang@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210601_073131_183021_55D080E9 X-CRM114-Status: GOOD ( 13.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, May 29, 2021 at 11:41:37AM +0800, Kefeng Wang wrote: > 1. cleanup access_error(), make vma flags set and check into > __do_page_fault() and do_page_fault() directly. > > 2. drop fsr and task argument, instead, using vm_flags in > __do_page_fault(). > > 3. cleans up the multiple goto statements in __do_page_fault(). > > 4. use current->mm directly in do_page_fault(). > > Signed-off-by: Kefeng Wang This patch is a really good example of something that is very difficult to review and see that there are no unintended changes. Many people have complained about my patches, where I create a series of many patches where each patch does exactly _one_ simple transformation to the code. This is a good example _why_ I do that - a step by step single transformation approach is way easier to review. Sorry, but I'm not able to sensibly review this patch, and therefore I won't apply it. Please split it into smaller changes. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel