From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8816C47080 for ; Tue, 1 Jun 2021 23:14:15 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6D607613AD for ; Tue, 1 Jun 2021 23:14:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6D607613AD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F245282EA5; Wed, 2 Jun 2021 01:14:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="l3bNcbJL"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9AE2082E8D; Wed, 2 Jun 2021 01:14:08 +0200 (CEST) Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CAF1F82AC4 for ; Wed, 2 Jun 2021 01:14:05 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x733.google.com with SMTP id u30so574701qke.7 for ; Tue, 01 Jun 2021 16:14:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=WmA/hIfKtRQRPrr+5D7+0ubxf9WPVKm6Y5p2SdAgcWo=; b=l3bNcbJL6GyxksqukjrryTmOF3kqIxBS/l4X9VH7lWdQ1XeCjARpRib//AE4t2xve5 5ex9mO7fqAPH4bW1w0SVE+DZG5e6Q0I6dylgdsmwksDCZSFsKqzRlFYpkvLV3BnepPle u+KPyadN7y8A2mBU0kypdSige51iOqN9j7HrM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=WmA/hIfKtRQRPrr+5D7+0ubxf9WPVKm6Y5p2SdAgcWo=; b=gW6KaQG3HNf9vt9erjwCmsXAX4ZYuaDRU0twcLXrLuPyIYjN8+R8kT81CW4y2v07B8 ND9kgpwJhbta32r9rOqjmpmKVejd3gpQusMaSD4uT+PnpSLO9647OgkCCw746uC6lcgf /RmKEtCCmKNmIm8hZYKQgCzSJXnf5JUpwxGlngtyVFee6DTYLYwsCTCVsNc8GM3stY69 FaeDi1BJNxNfur9vB0EvMbwPJ0HKtgKloaamunJHnyGaO0F1wG3/OvUa4VtW6rkXLxlK rIwAGV2s9lmBTX0dMrERpnRCA7/g+iLvTnO9rHUg9y7hfUKkS2rYqsSO78qPM0LTrpC1 V2eQ== X-Gm-Message-State: AOAM532EjHJRNz/cysVeOjfavBv28xSDxD7hGkKnl2uT0yxYyWV25OpN X2trowJJF6ET6gygx1xjOJatIA== X-Google-Smtp-Source: ABdhPJwaxjx632/5Pyz7Yw86eL+WI9tTLY6jNHgcZQksbA9GbP/SQsjidmagfQCMaW+SYuaFj3ETyw== X-Received: by 2002:a05:620a:22f2:: with SMTP id p18mr24667858qki.410.1622589244620; Tue, 01 Jun 2021 16:14:04 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-98df-de31-e21d-e1a1.res6.spectrum.com. [2603:6081:7b01:cbda:98df:de31:e21d:e1a1]) by smtp.gmail.com with ESMTPSA id b5sm8579065qkn.129.2021.06.01.16.14.03 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 01 Jun 2021 16:14:03 -0700 (PDT) Date: Tue, 1 Jun 2021 19:14:01 -0400 From: Tom Rini To: Sean Anderson Cc: u-boot@lists.denx.de, Simon Glass , Lukasz Majewski , Heiko Schocher , Patrick Delaunay , Roman Kovalivskyi , Gary Bisson Subject: Re: [PATCH v2] fastboot: Fix overflow when calculating chunk size Message-ID: <20210601231401.GJ14385@bill-the-cat> References: <20210527160234.121378-1-sean.anderson@seco.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dgjlcl3Tl+kb3YDk" Content-Disposition: inline In-Reply-To: <20210527160234.121378-1-sean.anderson@seco.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean --dgjlcl3Tl+kb3YDk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 27, 2021 at 12:02:34PM -0400, Sean Anderson wrote: > If a chunk was larger than 4GiB, then chunk_data_sz would overflow and > blkcnt would not be calculated correctly. Upgrade it to a u64 and cast > its multiplicands as well. Also fix bytes_written while we're at it. >=20 > Signed-off-by: Sean Anderson > Reviewed-by: Heiko Schocher Applied to u-boot/master, thanks! --=20 Tom --dgjlcl3Tl+kb3YDk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmC2vzIACgkQFHw5/5Y0 tyyXOAwArE76NvOGCckjXpGuoEY4M14i/9+lnvhcGPlClr9FQf+oD3HIFmfpBgnH Hu1jOk+wKpZ9cPv8fGf9fG6y5TKmyvLH0eUy/JVUYocV1AgmsrSQU4Oy+61rum9B AxtcqPPJFoBncVP88zeHagYBL2LEU4UrH76HLssZJScWp8Lk747HXQDNHYAF2Juu X7ZBXMH9TMQBUUeQnTYAZCrJt7Y2UD3gaOmJH+kd6Q4In9P4jU+xbNDZfbqA5Nbd 42luASPPcZT1p8iHG/zW3sEcXJ13DbbrkJ8iP2Tf4z1WLCTwWNOVH1aUAvjVfvF7 Qotiw0vtV7ILXaSI0mqGYDHO/AREL7p4S7AmrxK0NjmhbjOhDvlXtYZMSNF167MC nbCH0yhf3xd86TW3My+mMHdpgsnFVtrv5lUT4xYmbj6IvWnkFaruleI3gAjyWJx7 hsVfRyeFaUmqgMOQzH+Nlxe7jWEW+dM0FBpZaALmCVq+sWLPk6nNmNB4bXGmWmIQ VBJO/hAp =3EaF -----END PGP SIGNATURE----- --dgjlcl3Tl+kb3YDk--