From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B22B6C4708F for ; Wed, 2 Jun 2021 01:26:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 94BA46023F for ; Wed, 2 Jun 2021 01:26:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229947AbhFBB2R (ORCPT ); Tue, 1 Jun 2021 21:28:17 -0400 Received: from mail106.syd.optusnet.com.au ([211.29.132.42]:40432 "EHLO mail106.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229989AbhFBB2Q (ORCPT ); Tue, 1 Jun 2021 21:28:16 -0400 Received: from dread.disaster.area (pa49-179-138-183.pa.nsw.optusnet.com.au [49.179.138.183]) by mail106.syd.optusnet.com.au (Postfix) with ESMTPS id 6C48080AFB7; Wed, 2 Jun 2021 11:26:32 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1loFeR-007vHh-HT; Wed, 02 Jun 2021 11:26:31 +1000 Date: Wed, 2 Jun 2021 11:26:31 +1000 From: Dave Chinner To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org, hch@infradead.org Subject: Re: [PATCH 03/14] xfs: move the inode walk functions further down Message-ID: <20210602012631.GK664593@dread.disaster.area> References: <162259515220.662681.6750744293005850812.stgit@locust> <162259516919.662681.15253025725321641773.stgit@locust> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <162259516919.662681.15253025725321641773.stgit@locust> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=F8MpiZpN c=1 sm=1 tr=0 a=MnllW2CieawZLw/OcHE/Ng==:117 a=MnllW2CieawZLw/OcHE/Ng==:17 a=kj9zAlcOel0A:10 a=r6YtysWOX24A:10 a=VwQbUJbxAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=iXdkKqfwb4FNKhcCeFQA:9 a=CjuIK1q_8ugA:10 a=AjGcO6oz07-iQ99wixmX:22 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Tue, Jun 01, 2021 at 05:52:49PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > Move the inode walk functions further down in the file to limit the > forward declarations to the two walk functions as we add new code that > uses the inode walks. We'll clean them out later. Might be worth qualifying "later" here. The forward decl's are not removed in this patch set, but by the future inode inactivation patchset. Otherwise looks ok. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com