From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8AD0C47083 for ; Wed, 2 Jun 2021 08:09:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 94CDD613D2 for ; Wed, 2 Jun 2021 08:09:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 94CDD613D2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9lAjPe13lH/pX05x44bUHzMJeRw+cIWIphLFNZOTqXc=; b=Eo1vXQ4tcZUB2R OoCFS1ZbHZwXQdyiKosxWXwiWi3KKwSf0Zyb8bqqtu4SifiNgOCztqn2GIDYIR+j0b6NxxBV8xsf8 5k3Q1gI3QAHIL+RrN+1k4I1PIvJiLOGS+5jnLaYDkXxsLK/p46ySjgNCz9DOgqRtoGzeYi+nZyfmQ QLGFn7c2WSNti0TtAJr6QQlZ7FRlMg0zeBQDBqQvps+pVrjopI5yBuunWKXn1ZA7VW67JCbzRzpe3 AL+gOYYSJCtiQScLFq5fHtYljdcOgV+JcqQv4PRTuhyg8qBzbdZL6W0Bw3rf6sx1biJpLKMUyQEVf wgFA9tHzxkIGyfREf0rg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1loLv3-002VFx-Rk; Wed, 02 Jun 2021 08:08:06 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1loLJd-002InC-Ap for linux-arm-kernel@lists.infradead.org; Wed, 02 Jun 2021 07:29:26 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 49BD36D; Wed, 2 Jun 2021 00:29:24 -0700 (PDT) Received: from bogus (unknown [10.57.72.241]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3A0B53F73D; Wed, 2 Jun 2021 00:29:22 -0700 (PDT) Date: Wed, 2 Jun 2021 08:29:07 +0100 From: Sudeep Holla To: linux-arm-kernel@lists.infradead.org Cc: Cristian Marussi , Kevin Hilman , Neil Armstrong , Jerome Brunet , Florian Fainelli , Jim Quinlan , Etienne Carriere Subject: Re: [PATCH 2/2] firmware: arm_scmi: Add compatibility checks for shmem node Message-ID: <20210602072844.rnjytsa32puj5kon@bogus> References: <20210601225125.918225-1-sudeep.holla@arm.com> <20210601225125.918225-2-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210601225125.918225-2-sudeep.holla@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210602_002925_467783_004E41D6 X-CRM114-Status: GOOD ( 18.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 01, 2021 at 11:51:25PM +0100, Sudeep Holla wrote: > The shared memory node used for communication between the firmware and > the OS should be compatible with "arm,scmi-shmem". Add the check for the > same while parsing the node before fetching the memory regions. > Ignore this patch, sent a wrong version. This breaks build... > Cc: Cristian Marussi > Cc: Florian Fainelli > Cc: Jim Quinlan > Cc: Etienne Carriere > Signed-off-by: Sudeep Holla > --- > drivers/firmware/arm_scmi/mailbox.c | 3 +++ > drivers/firmware/arm_scmi/smc.c | 3 +++ > 2 files changed, 6 insertions(+) > > diff --git a/drivers/firmware/arm_scmi/mailbox.c b/drivers/firmware/arm_scmi/mailbox.c > index 4626404be541..e3dcb58314ae 100644 > --- a/drivers/firmware/arm_scmi/mailbox.c > +++ b/drivers/firmware/arm_scmi/mailbox.c > @@ -69,6 +69,9 @@ static int mailbox_chan_setup(struct scmi_chan_info *cinfo, struct device *dev, > return -ENOMEM; > > shmem = of_parse_phandle(cdev->of_node, "shmem", idx); > + if (!of_device_is_compatible(shmem, "arm,scmi-shmem")) > + return -ENXIO; > + > ret = of_address_to_resource(shmem, 0, &res); > of_node_put(shmem); > if (ret) { > diff --git a/drivers/firmware/arm_scmi/smc.c b/drivers/firmware/arm_scmi/smc.c > index fcbe2677f84b..78198ef94438 100644 > --- a/drivers/firmware/arm_scmi/smc.c > +++ b/drivers/firmware/arm_scmi/smc.c > @@ -76,6 +76,9 @@ static int smc_chan_setup(struct scmi_chan_info *cinfo, struct device *dev, > return -ENOMEM; > > np = of_parse_phandle(cdev->of_node, "shmem", 0); > + if (!of_device_is_compatible(shmem, "arm,scmi-shmem")) s/shmem/np/ > + return -ENXIO; > + > ret = of_address_to_resource(np, 0, &res); > of_node_put(np); > if (ret) { > -- > 2.25.1 > -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel