From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 800E8C47083 for ; Wed, 2 Jun 2021 10:29:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5D12B613D6 for ; Wed, 2 Jun 2021 10:29:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231165AbhFBKbS (ORCPT ); Wed, 2 Jun 2021 06:31:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229695AbhFBKbQ (ORCPT ); Wed, 2 Jun 2021 06:31:16 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 626F4C061574 for ; Wed, 2 Jun 2021 03:29:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=+9K0ZBY+cfWGtXy7iN7+32ZXUN6yO9gDst2tILKfNoQ=; b=V2c4PKbHUqXuQifwKnhHoE9Up RWm9TSqtCo4RaoK69ZNTIpW7ACz2ZxD2Iqm0SsouGhPHhWpregK4bJMbfHwIn6P0ltlHm9n+GDOZ1 BCHmpyw429bpvlFfIRXuhFlW028ZkbhmeqLgQGmFoTapN/74Jos1btVmzb2q4Nq5cG/VenX4Ats5K Yr6Naagv1cerHLzf4i2QeGQzFSGXhXSRMdq5zSl8FY3wxXaUeycntI+gW2A2AXIRha9DIqVA9Zds6 1EpGRaL2e4EBBc95xedLikzIlrna3hV66O49YFe1EHXzCWsFMvYtKZlEQ6i66b65MxRJ200i77ylj l2ZOUftbg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44610) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1loO7t-0000yx-RU; Wed, 02 Jun 2021 11:29:29 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1loO7t-00012M-4x; Wed, 02 Jun 2021 11:29:29 +0100 Date: Wed, 2 Jun 2021 11:29:29 +0100 From: "Russell King (Oracle)" To: Kefeng Wang Cc: linux-arm-kernel@lists.infradead.org, Catalin Marinas , linux-kernel@vger.kernel.org, Andrew Morton , Jungseung Lee Subject: Re: [PATCH v2 1/7] ARM: mm: Rafactor the __do_page_fault() Message-ID: <20210602102929.GE30436@shell.armlinux.org.uk> References: <20210602070246.83990-1-wangkefeng.wang@huawei.com> <20210602070246.83990-2-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210602070246.83990-2-wangkefeng.wang@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, Jun 02, 2021 at 03:02:40PM +0800, Kefeng Wang wrote: > Clean up the multiple goto statements and drops local variable > vm_fault_t fault, which will make the __do_page_fault() much > more readability. > > No functional change. > > Signed-off-by: Kefeng Wang This looks fine to me. Please send it to the patch system (details in my email signature.) Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F4CCC4708F for ; Wed, 2 Jun 2021 10:31:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 53E93613B4 for ; Wed, 2 Jun 2021 10:31:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 53E93613B4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XLBZ0rsP5TGBgX3H0g07lgqzogtO7pddJizeVQ2tl4I=; b=th079lznsqrpHQ BtTFMw+YRCTAMYIa5phxuv2I8FHVd/nVJZfvqa0r7VgTD2DPbop722DNGNR6QiVXsZqBKKodOqFwp mHzOjAa6Dn4EBydxelUPRV/1C5xzMqSp0Vh2F1ltvE91QQ8rnM+HRSMes+chLhgNmui+mB4UDM/UR 0BgtdsxmRQ4kRomcSbukF1ZvPyb0tL4UrbYXuVLWMwSmpirXwtnGyg7jELEOENRqpcgugctwihgPS DvnNTH50a56WBofReZyeC1LpYaUOH6okLwP6WCw4v8zjj/44p5OX28KlUkc6gO6Qe1AwMXI0zmtY+ hiqi4acGa4In5xhE4frQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1loO82-003Kkf-89; Wed, 02 Jun 2021 10:29:38 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1loO7v-003Ki3-Ok for linux-arm-kernel@lists.infradead.org; Wed, 02 Jun 2021 10:29:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=+9K0ZBY+cfWGtXy7iN7+32ZXUN6yO9gDst2tILKfNoQ=; b=V2c4PKbHUqXuQifwKnhHoE9Up RWm9TSqtCo4RaoK69ZNTIpW7ACz2ZxD2Iqm0SsouGhPHhWpregK4bJMbfHwIn6P0ltlHm9n+GDOZ1 BCHmpyw429bpvlFfIRXuhFlW028ZkbhmeqLgQGmFoTapN/74Jos1btVmzb2q4Nq5cG/VenX4Ats5K Yr6Naagv1cerHLzf4i2QeGQzFSGXhXSRMdq5zSl8FY3wxXaUeycntI+gW2A2AXIRha9DIqVA9Zds6 1EpGRaL2e4EBBc95xedLikzIlrna3hV66O49YFe1EHXzCWsFMvYtKZlEQ6i66b65MxRJ200i77ylj l2ZOUftbg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44610) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1loO7t-0000yx-RU; Wed, 02 Jun 2021 11:29:29 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1loO7t-00012M-4x; Wed, 02 Jun 2021 11:29:29 +0100 Date: Wed, 2 Jun 2021 11:29:29 +0100 From: "Russell King (Oracle)" To: Kefeng Wang Cc: linux-arm-kernel@lists.infradead.org, Catalin Marinas , linux-kernel@vger.kernel.org, Andrew Morton , Jungseung Lee Subject: Re: [PATCH v2 1/7] ARM: mm: Rafactor the __do_page_fault() Message-ID: <20210602102929.GE30436@shell.armlinux.org.uk> References: <20210602070246.83990-1-wangkefeng.wang@huawei.com> <20210602070246.83990-2-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210602070246.83990-2-wangkefeng.wang@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210602_032931_825658_8465CFB3 X-CRM114-Status: GOOD ( 10.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Wed, Jun 02, 2021 at 03:02:40PM +0800, Kefeng Wang wrote: > Clean up the multiple goto statements and drops local variable > vm_fault_t fault, which will make the __do_page_fault() much > more readability. > > No functional change. > > Signed-off-by: Kefeng Wang This looks fine to me. Please send it to the patch system (details in my email signature.) Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel