From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0885C4708F for ; Wed, 2 Jun 2021 13:53:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6411A613D6 for ; Wed, 2 Jun 2021 13:53:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6411A613D6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Q/RS5oeitndslwb88wH+nQY3BdGEB7kZr7uT3TEyxe0=; b=2OVXqpLY7kkPxG 3tORli03e5gvz+RV1GpiNdr9R/UcohCmFNeDJelTDDC3sZqpBkIcl6ELI6Hg+/elOiutCJ0LT0BA0 fT3OgAKqeb74iBZfx3/2QprKZaXkGJUIFHua3Ae4CzyoTP/+zJMiAEIzTF5mqDFhk/TsCNDCjfk2P ektVZ43rkjEf8VcSe6bxTPl39UYWkV/KE6IYKua/gDkN9hyAeibCbMiCLbKK1YConFAnSUlJZGWVT R5/pPDdMjSWI0GY9yxvd5vAV8oIXLN3ux1XWHJSNpsO1ctlSMUKRP93wg8c8GPS5E0I4l6hHxAxA8 OQSaLCBZhwsoG0z0E0Pg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1loRHX-004Pyb-Cp; Wed, 02 Jun 2021 13:51:39 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1loRHR-004Py5-CV for linux-arm-kernel@lists.infradead.org; Wed, 02 Jun 2021 13:51:37 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1949D6D; Wed, 2 Jun 2021 06:51:28 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.31.212]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1EF6B3F73D; Wed, 2 Jun 2021 06:51:25 -0700 (PDT) Date: Wed, 2 Jun 2021 14:51:23 +0100 From: Mark Rutland To: Marek Szyprowski Cc: Will Deacon , linux-arm-kernel@lists.infradead.org, kernel-team@android.com, Catalin Marinas , Ard Biesheuvel , Arnd Bergmann , Vincent Whitchurch , Bartlomiej Zolnierkiewicz Subject: Re: [PATCH] arm64: cache: Lower ARCH_DMA_MINALIGN to 64 (L1_CACHE_BYTES) Message-ID: <20210602135123.GD12753@C02TD0UTHF1T.local> References: <20210527124356.22367-1-will@kernel.org> <4d0c8318-bad8-2be7-e292-fc8f70c198de@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4d0c8318-bad8-2be7-e292-fc8f70c198de@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210602_065133_495584_EFCD28BB X-CRM114-Status: GOOD ( 22.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marek, On Wed, Jun 02, 2021 at 03:25:41PM +0200, Marek Szyprowski wrote: > On 27.05.2021 14:43, Will Deacon wrote: > This patch landed in todays linux-next as commit 65688d2a05de ("arm64: > cache: Lower ARCH_DMA_MINALIGN to 64 (L1_CACHE_BYTES)"). It causes an > issue on Raspberry Pi 3b board. System boots to userspace fine, but then > it hangs somewhere during the init scripts after loading the modules. I > didn't manage to track where it hangs yet though. Ouch! I have a 3b in a drawer that I might be able to reproduce the issue with; can you tell me how you're booting that kernel? e.g. which FW and DT you're using? Is your filesystem on the SD card, or some USB storage? I'm guessing we'll need to stress DMA over one of those. Thanks, Mark. > > arch/arm64/include/asm/cache.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm64/include/asm/cache.h b/arch/arm64/include/asm/cache.h > > index a074459f8f2f..a9c0716e7440 100644 > > --- a/arch/arm64/include/asm/cache.h > > +++ b/arch/arm64/include/asm/cache.h > > @@ -47,7 +47,7 @@ > > * cache before the transfer is done, causing old data to be seen by > > * the CPU. > > */ > > -#define ARCH_DMA_MINALIGN (128) > > +#define ARCH_DMA_MINALIGN L1_CACHE_BYTES > > > > #ifdef CONFIG_KASAN_SW_TAGS > > #define ARCH_SLAB_MINALIGN (1ULL << KASAN_SHADOW_SCALE_SHIFT) > > Best regards > -- > Marek Szyprowski, PhD > Samsung R&D Institute Poland > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel