All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@iki.fi>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Martin Kepplinger <martin.kepplinger@puri.sm>,
	mchehab@kernel.org, devicetree@vger.kernel.org, kernel@puri.sm,
	krzysztof.kozlowski@canonical.com, linux-kernel@vger.kernel.org,
	linux-media@vger.kernel.org, paul.kocialkowski@bootlin.com,
	robh@kernel.org, shawnx.tu@intel.com
Subject: Re: [PATCH v2 2/5] dt-bindings: media: document SK Hynix Hi-846 MIPI CSI-2 8M pixel sensor
Date: Wed, 2 Jun 2021 16:52:27 +0300	[thread overview]
Message-ID: <20210602135226.GX3@valkosipuli.retiisi.eu> (raw)
In-Reply-To: <YLCrVzzvKoJOZAK3@pendragon.ideasonboard.com>

On Fri, May 28, 2021 at 11:35:35AM +0300, Laurent Pinchart wrote:
...
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    description: Reference to the mclk clock.
> > +    maxItems: 1
> 
> You could also write this
> 
>   clocks:
>     items:
>       - description: Reference to the mclk clock.
> 
> The maxItems will then be implicit. This is the preferred form when
> multiple clocks are used, and given that clocks it meant to contain a
> list of clocks, even if it has a single entry, placing the description
> in a list of items may be a bit better semantically speaking.
> 
> > +
> > +  clock-names:
> > +    const: mclk
> 
> Similarly,
> 
>   clock-names:
>     items:
>       - const: mclk
> 
> Rob, is standardizing this pattern a good idea, or do you prefer the
> shorter form
> 
>   clock-names:
>     const: mclk

As there's just one clock, isn't the clock-names redundant?

-- 
Sakari Ailus

  reply	other threads:[~2021-06-02 13:52 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-28  8:13 [PATCH v2 0/5] Add support for the Hynix Hi-846 camera Martin Kepplinger
2021-05-28  8:13 ` [PATCH v2 1/5] dt-bindings: vendor-prefixes: Add SK Hynix Inc Martin Kepplinger
2021-05-28  8:13 ` [PATCH v2 2/5] dt-bindings: media: document SK Hynix Hi-846 MIPI CSI-2 8M pixel sensor Martin Kepplinger
2021-05-28  8:35   ` Laurent Pinchart
2021-06-02 13:52     ` Sakari Ailus [this message]
2021-06-02 13:51   ` Sakari Ailus
2021-06-02 14:05     ` Laurent Pinchart
2021-06-02 14:12       ` Martin Kepplinger
2021-06-02 14:37       ` Sakari Ailus
2021-05-28  8:13 ` [PATCH v2 3/5] media: i2c: add driver for the SK Hynix Hi-846 8M pixel camera Martin Kepplinger
2021-05-28 18:20   ` kernel test robot
2021-05-28 18:20     ` kernel test robot
2021-05-28 19:08   ` kernel test robot
2021-05-28 19:08     ` kernel test robot
2021-06-02 14:36   ` Sakari Ailus
2021-05-28  8:13 ` [PATCH v2 4/5] arm64: defconfig: enable VIDEO_HI846 Martin Kepplinger
2021-05-28  8:13 ` [PATCH v2 5/5] Documentation: i2c-cardlist: add the Hynix hi846 sensor Martin Kepplinger
2021-05-30 21:23 ` [PATCH v2 0/5] Add support for the Hynix Hi-846 camera Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210602135226.GX3@valkosipuli.retiisi.eu \
    --to=sakari.ailus@iki.fi \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@puri.sm \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=martin.kepplinger@puri.sm \
    --cc=mchehab@kernel.org \
    --cc=paul.kocialkowski@bootlin.com \
    --cc=robh@kernel.org \
    --cc=shawnx.tu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.