From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,HK_RANDOM_FROM, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89911C4708F for ; Wed, 2 Jun 2021 14:10:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2EBD5613E4 for ; Wed, 2 Jun 2021 14:10:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2EBD5613E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bu.edu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46788 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loRa4-0001hC-7i for qemu-devel@archiver.kernel.org; Wed, 02 Jun 2021 10:10:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50596) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loRZD-0000zr-AZ for qemu-devel@nongnu.org; Wed, 02 Jun 2021 10:09:55 -0400 Received: from relay64.bu.edu ([128.197.228.104]:42842) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loRZB-0005es-6G for qemu-devel@nongnu.org; Wed, 02 Jun 2021 10:09:54 -0400 X-Envelope-From: alxndr@bu.edu X-BU-AUTH: mozz.bu.edu [128.197.127.33] Received: from BU-AUTH (localhost.localdomain [127.0.0.1]) (authenticated bits=0) by relay64.bu.edu (8.14.3/8.14.3) with ESMTP id 152E8N4M023280 (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256 verify=NO); Wed, 2 Jun 2021 10:08:29 -0400 Date: Wed, 2 Jun 2021 10:08:23 -0400 From: Alexander Bulekov To: Gerd Hoffmann Subject: Re: [PULL 15/23] virtio-gpu: Refactor virtio_gpu_set_scanout Message-ID: <20210602140823.mwtilnjt3un7ooy7@mozz.bu.edu> References: <20210527142340.1352791-1-kraxel@redhat.com> <20210527142340.1352791-16-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210527142340.1352791-16-kraxel@redhat.com> Received-SPF: pass client-ip=128.197.228.104; envelope-from=alxndr@bu.edu; helo=relay64.bu.edu X-Spam_score_int: -5 X-Spam_score: -0.6 X-Spam_bar: / X-Spam_report: (-0.6 / 5.0 requ) BAYES_00=-1.9, HK_RANDOM_ENVFROM=0.998, HK_RANDOM_FROM=0.998, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , Cornelia Huck , Vivek Kasireddy , qemu-devel@nongnu.org, =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 210527 1623, Gerd Hoffmann wrote: > From: Vivek Kasireddy > > Store the meta-data associated with a FB in a new object > (struct virtio_gpu_framebuffer) and pass the object to set_scanout. > Also move code in set_scanout into a do_set_scanout function. > This will be helpful when adding set_scanout_blob API. > > Based-on-patch-by: Gerd Hoffmann > Cc: Gerd Hoffmann > Signed-off-by: Vivek Kasireddy > Message-Id: <20210526231429.1045476-7-vivek.kasireddy@intel.com> > Signed-off-by: Gerd Hoffmann > --- Hi, Recently OSS-Fuzz found a heap-overflow in virtio_gpu_disable_scanout. I bisected it to this patch: https://gitlab.com/qemu-project/qemu/-/issues/383 -Alex