All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/7] mfd/power/rtc: Do not enforce (incorrect) interrupt trigger type
@ 2021-05-26 17:20 Krzysztof Kozlowski
  2021-05-26 17:20 ` [PATCH v2 1/7] mfd: sec-irq: " Krzysztof Kozlowski
                   ` (8 more replies)
  0 siblings, 9 replies; 15+ messages in thread
From: Krzysztof Kozlowski @ 2021-05-26 17:20 UTC (permalink / raw)
  To: Chanwoo Choi, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz,
	Michael Turquette, Stephen Boyd, Rob Herring, Lee Jones,
	Sebastian Reichel, Liam Girdwood, Mark Brown, Alessandro Zummo,
	Alexandre Belloni, linux-kernel, linux-clk, devicetree, linux-pm,
	linux-samsung-soc, linux-rtc

Hi,

This is a v2 with only minor changes:
1. Drop patches which landed in mainline.
2. Add acks.
3. Rebase max17040 power supply (dtschema conversion).

Patches are independent and there are no external dependencies, so
please pick up freely.

Best regards,
Krzysztof


Krzysztof Kozlowski (7):
  mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type
  mfd: max77686: Do not enforce (incorrect) interrupt trigger type
  mfd: max77693: Do not enforce (incorrect) interrupt trigger type
  mfd: max14577: Do not enforce (incorrect) interrupt trigger type
  rtc: max77686: Do not enforce (incorrect) interrupt trigger type
  power: supply: max17042: Do not enforce (incorrect) interrupt trigger
    type
  power: supply: max17040: Do not enforce (incorrect) interrupt trigger
    type

 .../devicetree/bindings/clock/maxim,max77686.txt     |  4 ++--
 Documentation/devicetree/bindings/mfd/max14577.txt   |  4 ++--
 Documentation/devicetree/bindings/mfd/max77686.txt   |  2 +-
 Documentation/devicetree/bindings/mfd/max77693.txt   |  2 +-
 .../bindings/power/supply/maxim,max17040.yaml        |  2 +-
 .../devicetree/bindings/regulator/max77686.txt       |  2 +-
 drivers/mfd/max14577.c                               |  6 +++---
 drivers/mfd/max77686.c                               |  3 +--
 drivers/mfd/max77693.c                               | 12 ++++--------
 drivers/mfd/sec-irq.c                                |  3 +--
 drivers/power/supply/max17040_battery.c              |  4 +---
 drivers/power/supply/max17042_battery.c              |  2 +-
 drivers/rtc/rtc-max77686.c                           |  4 ++--
 13 files changed, 21 insertions(+), 29 deletions(-)

-- 
2.27.0


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH v2 1/7] mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type
  2021-05-26 17:20 [PATCH v2 0/7] mfd/power/rtc: Do not enforce (incorrect) interrupt trigger type Krzysztof Kozlowski
@ 2021-05-26 17:20 ` Krzysztof Kozlowski
  2021-05-26 17:20 ` [PATCH v2 2/7] mfd: max77686: " Krzysztof Kozlowski
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 15+ messages in thread
From: Krzysztof Kozlowski @ 2021-05-26 17:20 UTC (permalink / raw)
  To: Chanwoo Choi, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz,
	Michael Turquette, Stephen Boyd, Rob Herring, Lee Jones,
	Sebastian Reichel, Liam Girdwood, Mark Brown, Alessandro Zummo,
	Alexandre Belloni, linux-kernel, linux-clk, devicetree, linux-pm,
	linux-samsung-soc, linux-rtc
  Cc: Krzysztof Kozlowski, Marek Szyprowski

From: Krzysztof Kozlowski <krzk@kernel.org>

Interrupt line can be configured on different hardware in different way,
even inverted.  Therefore driver should not enforce specific trigger
type - edge falling - but instead rely on Devicetree to configure it.

The Samsung PMIC drivers are used only on Devicetree boards.

Additionally, the PMIC datasheets describe the interrupt line as active
low with a requirement of acknowledge from the CPU therefore the edge
falling is not correct.

Marek Szyprowski reports that together with DTS change (proper level in
DTS) it fixes RTC alarm failure that he observed from time to time on
TM2e board.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>

---

Changes since v1:
1. Mention in commit msg that this fixes TM2e RTC alarm.
2. Add Marek's tested-by.
---
 drivers/mfd/sec-irq.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/mfd/sec-irq.c b/drivers/mfd/sec-irq.c
index a98c5d165039..760f88a865ab 100644
--- a/drivers/mfd/sec-irq.c
+++ b/drivers/mfd/sec-irq.c
@@ -480,8 +480,7 @@ int sec_irq_init(struct sec_pmic_dev *sec_pmic)
 	}
 
 	ret = devm_regmap_add_irq_chip(sec_pmic->dev, sec_pmic->regmap_pmic,
-				       sec_pmic->irq,
-				       IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
+				       sec_pmic->irq, IRQF_ONESHOT,
 				       sec_pmic->irq_base, sec_irq_chip,
 				       &sec_pmic->irq_data);
 	if (ret != 0) {
-- 
2.27.0


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH v2 2/7] mfd: max77686: Do not enforce (incorrect) interrupt trigger type
  2021-05-26 17:20 [PATCH v2 0/7] mfd/power/rtc: Do not enforce (incorrect) interrupt trigger type Krzysztof Kozlowski
  2021-05-26 17:20 ` [PATCH v2 1/7] mfd: sec-irq: " Krzysztof Kozlowski
@ 2021-05-26 17:20 ` Krzysztof Kozlowski
  2021-05-26 22:33   ` Stephen Boyd
  2021-05-26 17:20 ` [PATCH v2 3/7] mfd: max77693: " Krzysztof Kozlowski
                   ` (6 subsequent siblings)
  8 siblings, 1 reply; 15+ messages in thread
From: Krzysztof Kozlowski @ 2021-05-26 17:20 UTC (permalink / raw)
  To: Chanwoo Choi, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz,
	Michael Turquette, Stephen Boyd, Rob Herring, Lee Jones,
	Sebastian Reichel, Liam Girdwood, Mark Brown, Alessandro Zummo,
	Alexandre Belloni, linux-kernel, linux-clk, devicetree, linux-pm,
	linux-samsung-soc, linux-rtc
  Cc: Krzysztof Kozlowski, Rob Herring

From: Krzysztof Kozlowski <krzk@kernel.org>

Interrupt line can be configured on different hardware in different way,
even inverted.  Therefore driver should not enforce specific trigger
type - edge falling - but instead rely on Devicetree to configure it.

The Maxim 77686 datasheet describes the interrupt line as active low
with a requirement of acknowledge from the CPU therefore the edge
falling is not correct.

The interrupt line is shared between PMIC and RTC driver, so using level
sensitive interrupt is here especially important to avoid races.  With
an edge configuration in case if first PMIC signals interrupt followed
shortly after by the RTC, the interrupt might not be yet cleared/acked
thus the second one would not be noticed.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Rob Herring <robh@kernel.org>

---

Changes since v1:
1. Add ack.
---
 Documentation/devicetree/bindings/clock/maxim,max77686.txt | 4 ++--
 Documentation/devicetree/bindings/mfd/max77686.txt         | 2 +-
 Documentation/devicetree/bindings/regulator/max77686.txt   | 2 +-
 drivers/mfd/max77686.c                                     | 3 +--
 4 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/maxim,max77686.txt b/Documentation/devicetree/bindings/clock/maxim,max77686.txt
index 3472b461ca93..c10849efb444 100644
--- a/Documentation/devicetree/bindings/clock/maxim,max77686.txt
+++ b/Documentation/devicetree/bindings/clock/maxim,max77686.txt
@@ -49,7 +49,7 @@ Example:
 		max77686: max77686@9 {
 			compatible = "maxim,max77686";
 			interrupt-parent = <&wakeup_eint>;
-			interrupts = <26 0>;
+			interrupts = <26 IRQ_TYPE_LEVEL_LOW>;
 			reg = <0x09>;
 			#clock-cells = <1>;
 
@@ -74,7 +74,7 @@ Example:
 		max77802: max77802@9 {
 			compatible = "maxim,max77802";
 			interrupt-parent = <&wakeup_eint>;
-			interrupts = <26 0>;
+			interrupts = <26 IRQ_TYPE_LEVEL_LOW>;
 			reg = <0x09>;
 			#clock-cells = <1>;
 
diff --git a/Documentation/devicetree/bindings/mfd/max77686.txt b/Documentation/devicetree/bindings/mfd/max77686.txt
index 42968b7144e0..4447d074894a 100644
--- a/Documentation/devicetree/bindings/mfd/max77686.txt
+++ b/Documentation/devicetree/bindings/mfd/max77686.txt
@@ -21,6 +21,6 @@ Example:
 	max77686: pmic@9 {
 		compatible = "maxim,max77686";
 		interrupt-parent = <&wakeup_eint>;
-		interrupts = <26 0>;
+		interrupts = <26 IRQ_TYPE_LEVEL_LOW>;
 		reg = <0x09>;
 	};
diff --git a/Documentation/devicetree/bindings/regulator/max77686.txt b/Documentation/devicetree/bindings/regulator/max77686.txt
index e9f7578ca09a..ff3d2dec8c4b 100644
--- a/Documentation/devicetree/bindings/regulator/max77686.txt
+++ b/Documentation/devicetree/bindings/regulator/max77686.txt
@@ -43,7 +43,7 @@ Example:
 	max77686: pmic@9 {
 		compatible = "maxim,max77686";
 		interrupt-parent = <&wakeup_eint>;
-		interrupts = <26 IRQ_TYPE_NONE>;
+		interrupts = <26 IRQ_TYPE_LEVEL_LOW>;
 		reg = <0x09>;
 
 		voltage-regulators {
diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c
index 2ad554b921d9..f9e12ab2bc75 100644
--- a/drivers/mfd/max77686.c
+++ b/drivers/mfd/max77686.c
@@ -209,8 +209,7 @@ static int max77686_i2c_probe(struct i2c_client *i2c)
 
 	ret = devm_regmap_add_irq_chip(&i2c->dev, max77686->regmap,
 				       max77686->irq,
-				       IRQF_TRIGGER_FALLING | IRQF_ONESHOT |
-				       IRQF_SHARED, 0, irq_chip,
+				       IRQF_ONESHOT | IRQF_SHARED, 0, irq_chip,
 				       &max77686->irq_data);
 	if (ret < 0) {
 		dev_err(&i2c->dev, "failed to add PMIC irq chip: %d\n", ret);
-- 
2.27.0


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH v2 3/7] mfd: max77693: Do not enforce (incorrect) interrupt trigger type
  2021-05-26 17:20 [PATCH v2 0/7] mfd/power/rtc: Do not enforce (incorrect) interrupt trigger type Krzysztof Kozlowski
  2021-05-26 17:20 ` [PATCH v2 1/7] mfd: sec-irq: " Krzysztof Kozlowski
  2021-05-26 17:20 ` [PATCH v2 2/7] mfd: max77686: " Krzysztof Kozlowski
@ 2021-05-26 17:20 ` Krzysztof Kozlowski
  2021-05-26 17:20 ` [PATCH v2 4/7] mfd: max14577: " Krzysztof Kozlowski
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 15+ messages in thread
From: Krzysztof Kozlowski @ 2021-05-26 17:20 UTC (permalink / raw)
  To: Chanwoo Choi, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz,
	Michael Turquette, Stephen Boyd, Rob Herring, Lee Jones,
	Sebastian Reichel, Liam Girdwood, Mark Brown, Alessandro Zummo,
	Alexandre Belloni, linux-kernel, linux-clk, devicetree, linux-pm,
	linux-samsung-soc, linux-rtc
  Cc: Krzysztof Kozlowski, Rob Herring

From: Krzysztof Kozlowski <krzk@kernel.org>

Interrupt line can be configured on different hardware in different way,
even inverted.  Therefore driver should not enforce specific trigger
type - edge falling - but instead rely on Devicetree to configure it.

The Maxim 77693 datasheet describes the interrupt line as active low
with a requirement of acknowledge from the CPU therefore the edge
falling is not correct.

The interrupt line is shared between PMIC and RTC driver, so using level
sensitive interrupt is here especially important to avoid races.  With
an edge configuration in case if first PMIC signals interrupt followed
shortly after by the RTC, the interrupt might not be yet cleared/acked
thus the second one would not be noticed.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Rob Herring <robh@kernel.org>

---

Changes since v1:
1. Add ack.
---
 Documentation/devicetree/bindings/mfd/max77693.txt |  2 +-
 drivers/mfd/max77693.c                             | 12 ++++--------
 2 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/Documentation/devicetree/bindings/mfd/max77693.txt b/Documentation/devicetree/bindings/mfd/max77693.txt
index 0ced96e16c16..1032df14498b 100644
--- a/Documentation/devicetree/bindings/mfd/max77693.txt
+++ b/Documentation/devicetree/bindings/mfd/max77693.txt
@@ -139,7 +139,7 @@ Example:
 		compatible = "maxim,max77693";
 		reg = <0x66>;
 		interrupt-parent = <&gpx1>;
-		interrupts = <5 2>;
+		interrupts = <5 IRQ_TYPE_LEVEL_LOW>;
 
 		regulators {
 			esafeout@1 {
diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
index 596ed85cab3b..4e6244e17559 100644
--- a/drivers/mfd/max77693.c
+++ b/drivers/mfd/max77693.c
@@ -222,8 +222,7 @@ static int max77693_i2c_probe(struct i2c_client *i2c,
 	}
 
 	ret = regmap_add_irq_chip(max77693->regmap, max77693->irq,
-				IRQF_ONESHOT | IRQF_SHARED |
-				IRQF_TRIGGER_FALLING, 0,
+				IRQF_ONESHOT | IRQF_SHARED, 0,
 				&max77693_led_irq_chip,
 				&max77693->irq_data_led);
 	if (ret) {
@@ -232,8 +231,7 @@ static int max77693_i2c_probe(struct i2c_client *i2c,
 	}
 
 	ret = regmap_add_irq_chip(max77693->regmap, max77693->irq,
-				IRQF_ONESHOT | IRQF_SHARED |
-				IRQF_TRIGGER_FALLING, 0,
+				IRQF_ONESHOT | IRQF_SHARED, 0,
 				&max77693_topsys_irq_chip,
 				&max77693->irq_data_topsys);
 	if (ret) {
@@ -242,8 +240,7 @@ static int max77693_i2c_probe(struct i2c_client *i2c,
 	}
 
 	ret = regmap_add_irq_chip(max77693->regmap, max77693->irq,
-				IRQF_ONESHOT | IRQF_SHARED |
-				IRQF_TRIGGER_FALLING, 0,
+				IRQF_ONESHOT | IRQF_SHARED, 0,
 				&max77693_charger_irq_chip,
 				&max77693->irq_data_chg);
 	if (ret) {
@@ -252,8 +249,7 @@ static int max77693_i2c_probe(struct i2c_client *i2c,
 	}
 
 	ret = regmap_add_irq_chip(max77693->regmap_muic, max77693->irq,
-				IRQF_ONESHOT | IRQF_SHARED |
-				IRQF_TRIGGER_FALLING, 0,
+				IRQF_ONESHOT | IRQF_SHARED, 0,
 				&max77693_muic_irq_chip,
 				&max77693->irq_data_muic);
 	if (ret) {
-- 
2.27.0


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH v2 4/7] mfd: max14577: Do not enforce (incorrect) interrupt trigger type
  2021-05-26 17:20 [PATCH v2 0/7] mfd/power/rtc: Do not enforce (incorrect) interrupt trigger type Krzysztof Kozlowski
                   ` (2 preceding siblings ...)
  2021-05-26 17:20 ` [PATCH v2 3/7] mfd: max77693: " Krzysztof Kozlowski
@ 2021-05-26 17:20 ` Krzysztof Kozlowski
  2021-05-26 17:20 ` [PATCH v2 5/7] rtc: max77686: " Krzysztof Kozlowski
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 15+ messages in thread
From: Krzysztof Kozlowski @ 2021-05-26 17:20 UTC (permalink / raw)
  To: Chanwoo Choi, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz,
	Michael Turquette, Stephen Boyd, Rob Herring, Lee Jones,
	Sebastian Reichel, Liam Girdwood, Mark Brown, Alessandro Zummo,
	Alexandre Belloni, linux-kernel, linux-clk, devicetree, linux-pm,
	linux-samsung-soc, linux-rtc
  Cc: Krzysztof Kozlowski, Rob Herring

From: Krzysztof Kozlowski <krzk@kernel.org>

Interrupt line can be configured on different hardware in different way,
even inverted.  Therefore driver should not enforce specific trigger
type - edge falling - but instead rely on Devicetree to configure it.

The Maxim 14577/77836 datasheets describe the interrupt line as active
low with a requirement of acknowledge from the CPU therefore the edge
falling is not correct.

The interrupt line is shared between PMIC and charger driver, so using
level sensitive interrupt is here especially important to avoid races.
With an edge configuration in case if first PMIC signals interrupt
followed shortly after by the RTC, the interrupt might not be yet
cleared/acked thus the second one would not be noticed.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Rob Herring <robh@kernel.org>

---

Changes since v1:
1. Add Ack
---
 Documentation/devicetree/bindings/mfd/max14577.txt | 4 ++--
 drivers/mfd/max14577.c                             | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/mfd/max14577.txt b/Documentation/devicetree/bindings/mfd/max14577.txt
index 92070b346756..be11943a0560 100644
--- a/Documentation/devicetree/bindings/mfd/max14577.txt
+++ b/Documentation/devicetree/bindings/mfd/max14577.txt
@@ -71,7 +71,7 @@ max14577@25 {
 	compatible = "maxim,max14577";
 	reg = <0x25>;
 	interrupt-parent = <&gpx1>;
-	interrupts = <5 IRQ_TYPE_NONE>;
+	interrupts = <5 IRQ_TYPE_LEVEL_LOW>;
 
 	muic: max14577-muic {
 		compatible = "maxim,max14577-muic";
@@ -106,7 +106,7 @@ max77836@25 {
 	compatible = "maxim,max77836";
 	reg = <0x25>;
 	interrupt-parent = <&gpx1>;
-	interrupts = <5 IRQ_TYPE_NONE>;
+	interrupts = <5 IRQ_TYPE_LEVEL_LOW>;
 
 	muic: max77836-muic {
 		compatible = "maxim,max77836-muic";
diff --git a/drivers/mfd/max14577.c b/drivers/mfd/max14577.c
index be185e9d5f16..6c487fa14e9c 100644
--- a/drivers/mfd/max14577.c
+++ b/drivers/mfd/max14577.c
@@ -332,7 +332,7 @@ static int max77836_init(struct max14577 *max14577)
 	}
 
 	ret = regmap_add_irq_chip(max14577->regmap_pmic, max14577->irq,
-			IRQF_TRIGGER_FALLING | IRQF_ONESHOT | IRQF_SHARED,
+			IRQF_ONESHOT | IRQF_SHARED,
 			0, &max77836_pmic_irq_chip,
 			&max14577->irq_data_pmic);
 	if (ret != 0) {
@@ -418,14 +418,14 @@ static int max14577_i2c_probe(struct i2c_client *i2c,
 		irq_chip = &max77836_muic_irq_chip;
 		mfd_devs = max77836_devs;
 		mfd_devs_size = ARRAY_SIZE(max77836_devs);
-		irq_flags = IRQF_TRIGGER_FALLING | IRQF_ONESHOT | IRQF_SHARED;
+		irq_flags = IRQF_ONESHOT | IRQF_SHARED;
 		break;
 	case MAXIM_DEVICE_TYPE_MAX14577:
 	default:
 		irq_chip = &max14577_irq_chip;
 		mfd_devs = max14577_devs;
 		mfd_devs_size = ARRAY_SIZE(max14577_devs);
-		irq_flags = IRQF_TRIGGER_FALLING | IRQF_ONESHOT;
+		irq_flags = IRQF_ONESHOT;
 		break;
 	}
 
-- 
2.27.0


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH v2 5/7] rtc: max77686: Do not enforce (incorrect) interrupt trigger type
  2021-05-26 17:20 [PATCH v2 0/7] mfd/power/rtc: Do not enforce (incorrect) interrupt trigger type Krzysztof Kozlowski
                   ` (3 preceding siblings ...)
  2021-05-26 17:20 ` [PATCH v2 4/7] mfd: max14577: " Krzysztof Kozlowski
@ 2021-05-26 17:20 ` Krzysztof Kozlowski
  2021-05-26 17:20 ` [PATCH v2 6/7] power: supply: max17042: " Krzysztof Kozlowski
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 15+ messages in thread
From: Krzysztof Kozlowski @ 2021-05-26 17:20 UTC (permalink / raw)
  To: Chanwoo Choi, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz,
	Michael Turquette, Stephen Boyd, Rob Herring, Lee Jones,
	Sebastian Reichel, Liam Girdwood, Mark Brown, Alessandro Zummo,
	Alexandre Belloni, linux-kernel, linux-clk, devicetree, linux-pm,
	linux-samsung-soc, linux-rtc
  Cc: Krzysztof Kozlowski

From: Krzysztof Kozlowski <krzk@kernel.org>

Interrupt line can be configured on different hardware in different way,
even inverted.  Therefore driver should not enforce specific trigger
type - edge falling - but instead rely on Devicetree to configure it.

The Maxim 77686 datasheet describes the interrupt line as active low
with a requirement of acknowledge from the CPU therefore the edge
falling is not correct.

The interrupt line is shared between PMIC and RTC driver, so using level
sensitive interrupt is here especially important to avoid races.  With
an edge configuration in case if first PMIC signals interrupt followed
shortly after by the RTC, the interrupt might not be yet cleared/acked
thus the second one would not be noticed.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Changes since v1:
1. None
---
 drivers/rtc/rtc-max77686.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c
index d51cc12114cb..eae7cb9faf1e 100644
--- a/drivers/rtc/rtc-max77686.c
+++ b/drivers/rtc/rtc-max77686.c
@@ -717,8 +717,8 @@ static int max77686_init_rtc_regmap(struct max77686_rtc_info *info)
 
 add_rtc_irq:
 	ret = regmap_add_irq_chip(info->rtc_regmap, info->rtc_irq,
-				  IRQF_TRIGGER_FALLING | IRQF_ONESHOT |
-				  IRQF_SHARED, 0, info->drv_data->rtc_irq_chip,
+				  IRQF_ONESHOT | IRQF_SHARED,
+				  0, info->drv_data->rtc_irq_chip,
 				  &info->rtc_irq_data);
 	if (ret < 0) {
 		dev_err(info->dev, "Failed to add RTC irq chip: %d\n", ret);
-- 
2.27.0


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH v2 6/7] power: supply: max17042: Do not enforce (incorrect) interrupt trigger type
  2021-05-26 17:20 [PATCH v2 0/7] mfd/power/rtc: Do not enforce (incorrect) interrupt trigger type Krzysztof Kozlowski
                   ` (4 preceding siblings ...)
  2021-05-26 17:20 ` [PATCH v2 5/7] rtc: max77686: " Krzysztof Kozlowski
@ 2021-05-26 17:20 ` Krzysztof Kozlowski
  2021-06-04 10:00   ` Sebastian Reichel
  2021-05-26 17:20 ` [PATCH v2 7/7] power: supply: max17040: " Krzysztof Kozlowski
                   ` (2 subsequent siblings)
  8 siblings, 1 reply; 15+ messages in thread
From: Krzysztof Kozlowski @ 2021-05-26 17:20 UTC (permalink / raw)
  To: Chanwoo Choi, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz,
	Michael Turquette, Stephen Boyd, Rob Herring, Lee Jones,
	Sebastian Reichel, Liam Girdwood, Mark Brown, Alessandro Zummo,
	Alexandre Belloni, linux-kernel, linux-clk, devicetree, linux-pm,
	linux-samsung-soc, linux-rtc
  Cc: Krzysztof Kozlowski

From: Krzysztof Kozlowski <krzk@kernel.org>

Interrupt line can be configured on different hardware in different way,
even inverted.  Therefore driver should not enforce specific trigger
type - edge falling - but instead rely on Devicetree to configure it.

The Maxim 17047/77693 datasheets describe the interrupt line as active
low with a requirement of acknowledge from the CPU therefore the edge
falling is not correct.

The interrupt line is shared between PMIC and RTC driver, so using level
sensitive interrupt is here especially important to avoid races.  With
an edge configuration in case if first PMIC signals interrupt followed
shortly after by the RTC, the interrupt might not be yet cleared/acked
thus the second one would not be noticed.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Changes since v1:
1. None
---
 drivers/power/supply/max17042_battery.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/power/supply/max17042_battery.c b/drivers/power/supply/max17042_battery.c
index 1d7326cd8fc6..ce2041b30a06 100644
--- a/drivers/power/supply/max17042_battery.c
+++ b/drivers/power/supply/max17042_battery.c
@@ -1104,7 +1104,7 @@ static int max17042_probe(struct i2c_client *client,
 	}
 
 	if (client->irq) {
-		unsigned int flags = IRQF_TRIGGER_FALLING | IRQF_ONESHOT;
+		unsigned int flags = IRQF_ONESHOT;
 
 		/*
 		 * On ACPI systems the IRQ may be handled by ACPI-event code,
-- 
2.27.0


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH v2 7/7] power: supply: max17040: Do not enforce (incorrect) interrupt trigger type
  2021-05-26 17:20 [PATCH v2 0/7] mfd/power/rtc: Do not enforce (incorrect) interrupt trigger type Krzysztof Kozlowski
                   ` (5 preceding siblings ...)
  2021-05-26 17:20 ` [PATCH v2 6/7] power: supply: max17042: " Krzysztof Kozlowski
@ 2021-05-26 17:20 ` Krzysztof Kozlowski
  2021-06-02 20:06   ` Rob Herring
  2021-06-01 15:41 ` [PATCH v2 0/7] mfd/power/rtc: " Lee Jones
  2021-06-20 20:22 ` (subset) " Alexandre Belloni
  8 siblings, 1 reply; 15+ messages in thread
From: Krzysztof Kozlowski @ 2021-05-26 17:20 UTC (permalink / raw)
  To: Chanwoo Choi, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz,
	Michael Turquette, Stephen Boyd, Rob Herring, Lee Jones,
	Sebastian Reichel, Liam Girdwood, Mark Brown, Alessandro Zummo,
	Alexandre Belloni, linux-kernel, linux-clk, devicetree, linux-pm,
	linux-samsung-soc, linux-rtc
  Cc: Krzysztof Kozlowski, Iskren Chernev

From: Krzysztof Kozlowski <krzk@kernel.org>

Interrupt line can be configured on different hardware in different way,
even inverted.  Therefore driver should not enforce specific trigger
type - edge falling - but instead rely on Devicetree to configure it.

The Maxim 14577/77836 datasheets describe the interrupt line as active
low with a requirement of acknowledge from the CPU therefore the edge
falling is not correct.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Iskren Chernev <iskren.chernev@gmail.com>

---

Changes since v1:
1. Remove the 'flags' variable.
2. Added ack.
3. Rebase - the bindings were converted to dtschema.
---
 .../devicetree/bindings/power/supply/maxim,max17040.yaml      | 2 +-
 drivers/power/supply/max17040_battery.c                       | 4 +---
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max17040.yaml b/Documentation/devicetree/bindings/power/supply/maxim,max17040.yaml
index de91cf3f058c..f792d06db413 100644
--- a/Documentation/devicetree/bindings/power/supply/maxim,max17040.yaml
+++ b/Documentation/devicetree/bindings/power/supply/maxim,max17040.yaml
@@ -89,7 +89,7 @@ examples:
         reg = <0x36>;
         maxim,alert-low-soc-level = <10>;
         interrupt-parent = <&gpio7>;
-        interrupts = <2 IRQ_TYPE_EDGE_FALLING>;
+        interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
         wakeup-source;
       };
     };
diff --git a/drivers/power/supply/max17040_battery.c b/drivers/power/supply/max17040_battery.c
index 1aab868adabf..e80dd9141ae7 100644
--- a/drivers/power/supply/max17040_battery.c
+++ b/drivers/power/supply/max17040_battery.c
@@ -361,12 +361,10 @@ static irqreturn_t max17040_thread_handler(int id, void *dev)
 static int max17040_enable_alert_irq(struct max17040_chip *chip)
 {
 	struct i2c_client *client = chip->client;
-	unsigned int flags;
 	int ret;
 
-	flags = IRQF_TRIGGER_FALLING | IRQF_ONESHOT;
 	ret = devm_request_threaded_irq(&client->dev, client->irq, NULL,
-					max17040_thread_handler, flags,
+					max17040_thread_handler, IRQF_ONESHOT,
 					chip->battery->desc->name, chip);
 
 	return ret;
-- 
2.27.0


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2 2/7] mfd: max77686: Do not enforce (incorrect) interrupt trigger type
  2021-05-26 17:20 ` [PATCH v2 2/7] mfd: max77686: " Krzysztof Kozlowski
@ 2021-05-26 22:33   ` Stephen Boyd
  0 siblings, 0 replies; 15+ messages in thread
From: Stephen Boyd @ 2021-05-26 22:33 UTC (permalink / raw)
  To: Alessandro Zummo, Alexandre Belloni, Bartlomiej Zolnierkiewicz,
	Chanwoo Choi, Krzysztof Kozlowski, Lee Jones, Liam Girdwood,
	Mark Brown, Michael Turquette, Rob Herring, Sebastian Reichel,
	devicetree, linux-clk, linux-kernel, linux-pm, linux-rtc,
	linux-samsung-soc
  Cc: Krzysztof Kozlowski, Rob Herring

Quoting Krzysztof Kozlowski (2021-05-26 10:20:31)
> From: Krzysztof Kozlowski <krzk@kernel.org>
> 
> Interrupt line can be configured on different hardware in different way,
> even inverted.  Therefore driver should not enforce specific trigger
> type - edge falling - but instead rely on Devicetree to configure it.
> 
> The Maxim 77686 datasheet describes the interrupt line as active low
> with a requirement of acknowledge from the CPU therefore the edge
> falling is not correct.
> 
> The interrupt line is shared between PMIC and RTC driver, so using level
> sensitive interrupt is here especially important to avoid races.  With
> an edge configuration in case if first PMIC signals interrupt followed
> shortly after by the RTC, the interrupt might not be yet cleared/acked
> thus the second one would not be noticed.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Acked-by: Rob Herring <robh@kernel.org>
> 
> ---

Acked-by: Stephen Boyd <sboyd@kernel.org> # clock binding

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2 0/7] mfd/power/rtc: Do not enforce (incorrect) interrupt trigger type
  2021-05-26 17:20 [PATCH v2 0/7] mfd/power/rtc: Do not enforce (incorrect) interrupt trigger type Krzysztof Kozlowski
                   ` (6 preceding siblings ...)
  2021-05-26 17:20 ` [PATCH v2 7/7] power: supply: max17040: " Krzysztof Kozlowski
@ 2021-06-01 15:41 ` Lee Jones
  2021-06-01 16:13   ` Krzysztof Kozlowski
  2021-06-20 20:22 ` (subset) " Alexandre Belloni
  8 siblings, 1 reply; 15+ messages in thread
From: Lee Jones @ 2021-06-01 15:41 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Chanwoo Choi, Bartlomiej Zolnierkiewicz, Michael Turquette,
	Stephen Boyd, Rob Herring, Sebastian Reichel, Liam Girdwood,
	Mark Brown, Alessandro Zummo, Alexandre Belloni, linux-kernel,
	linux-clk, devicetree, linux-pm, linux-samsung-soc, linux-rtc

On Wed, 26 May 2021, Krzysztof Kozlowski wrote:

> Hi,
> 
> This is a v2 with only minor changes:
> 1. Drop patches which landed in mainline.
> 2. Add acks.
> 3. Rebase max17040 power supply (dtschema conversion).
> 
> Patches are independent and there are no external dependencies, so
> please pick up freely.
> 
> Best regards,
> Krzysztof
> 
> 
> Krzysztof Kozlowski (7):
>   mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type
>   mfd: max77686: Do not enforce (incorrect) interrupt trigger type
>   mfd: max77693: Do not enforce (incorrect) interrupt trigger type
>   mfd: max14577: Do not enforce (incorrect) interrupt trigger type
>   rtc: max77686: Do not enforce (incorrect) interrupt trigger type
>   power: supply: max17042: Do not enforce (incorrect) interrupt trigger
>     type
>   power: supply: max17040: Do not enforce (incorrect) interrupt trigger
>     type

MFD patches (at least) do not apply.

Please rebase and resubmit with my:

For my own reference (apply this as-is to your sign-off block):

  Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2 0/7] mfd/power/rtc: Do not enforce (incorrect) interrupt trigger type
  2021-06-01 15:41 ` [PATCH v2 0/7] mfd/power/rtc: " Lee Jones
@ 2021-06-01 16:13   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 15+ messages in thread
From: Krzysztof Kozlowski @ 2021-06-01 16:13 UTC (permalink / raw)
  To: Lee Jones
  Cc: Chanwoo Choi, Bartlomiej Zolnierkiewicz, Michael Turquette,
	Stephen Boyd, Rob Herring, Sebastian Reichel, Liam Girdwood,
	Mark Brown, Alessandro Zummo, Alexandre Belloni, linux-kernel,
	linux-clk, devicetree, linux-pm, linux-samsung-soc, linux-rtc

On 01/06/2021 17:41, Lee Jones wrote:
> On Wed, 26 May 2021, Krzysztof Kozlowski wrote:
> 
>> Hi,
>>
>> This is a v2 with only minor changes:
>> 1. Drop patches which landed in mainline.
>> 2. Add acks.
>> 3. Rebase max17040 power supply (dtschema conversion).
>>
>> Patches are independent and there are no external dependencies, so
>> please pick up freely.
>>
>> Best regards,
>> Krzysztof
>>
>>
>> Krzysztof Kozlowski (7):
>>   mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type
>>   mfd: max77686: Do not enforce (incorrect) interrupt trigger type
>>   mfd: max77693: Do not enforce (incorrect) interrupt trigger type
>>   mfd: max14577: Do not enforce (incorrect) interrupt trigger type
>>   rtc: max77686: Do not enforce (incorrect) interrupt trigger type
>>   power: supply: max17042: Do not enforce (incorrect) interrupt trigger
>>     type
>>   power: supply: max17040: Do not enforce (incorrect) interrupt trigger
>>     type
> 
> MFD patches (at least) do not apply.
> 
> Please rebase and resubmit with my:
> 
> For my own reference (apply this as-is to your sign-off block):
> 
>   Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>

I'll resend the MFD part.

For the RTC and power, I hope these apply still cleanly.


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2 7/7] power: supply: max17040: Do not enforce (incorrect) interrupt trigger type
  2021-05-26 17:20 ` [PATCH v2 7/7] power: supply: max17040: " Krzysztof Kozlowski
@ 2021-06-02 20:06   ` Rob Herring
  2021-06-04 10:01     ` Sebastian Reichel
  0 siblings, 1 reply; 15+ messages in thread
From: Rob Herring @ 2021-06-02 20:06 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Lee Jones, Rob Herring, Chanwoo Choi, Alessandro Zummo,
	Mark Brown, linux-samsung-soc, Liam Girdwood, Sebastian Reichel,
	linux-kernel, linux-clk, Bartlomiej Zolnierkiewicz, devicetree,
	Iskren Chernev, Krzysztof Kozlowski, Alexandre Belloni,
	Stephen Boyd, Michael Turquette, linux-rtc, linux-pm

On Wed, 26 May 2021 13:20:36 -0400, Krzysztof Kozlowski wrote:
> From: Krzysztof Kozlowski <krzk@kernel.org>
> 
> Interrupt line can be configured on different hardware in different way,
> even inverted.  Therefore driver should not enforce specific trigger
> type - edge falling - but instead rely on Devicetree to configure it.
> 
> The Maxim 14577/77836 datasheets describe the interrupt line as active
> low with a requirement of acknowledge from the CPU therefore the edge
> falling is not correct.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Acked-by: Iskren Chernev <iskren.chernev@gmail.com>
> 
> ---
> 
> Changes since v1:
> 1. Remove the 'flags' variable.
> 2. Added ack.
> 3. Rebase - the bindings were converted to dtschema.
> ---
>  .../devicetree/bindings/power/supply/maxim,max17040.yaml      | 2 +-
>  drivers/power/supply/max17040_battery.c                       | 4 +---
>  2 files changed, 2 insertions(+), 4 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2 6/7] power: supply: max17042: Do not enforce (incorrect) interrupt trigger type
  2021-05-26 17:20 ` [PATCH v2 6/7] power: supply: max17042: " Krzysztof Kozlowski
@ 2021-06-04 10:00   ` Sebastian Reichel
  0 siblings, 0 replies; 15+ messages in thread
From: Sebastian Reichel @ 2021-06-04 10:00 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Chanwoo Choi, Bartlomiej Zolnierkiewicz, Michael Turquette,
	Stephen Boyd, Rob Herring, Lee Jones, Liam Girdwood, Mark Brown,
	Alessandro Zummo, Alexandre Belloni, linux-kernel, linux-clk,
	devicetree, linux-pm, linux-samsung-soc, linux-rtc,
	Krzysztof Kozlowski

[-- Attachment #1: Type: text/plain, Size: 1691 bytes --]

Hi,

On Wed, May 26, 2021 at 01:20:35PM -0400, Krzysztof Kozlowski wrote:
> From: Krzysztof Kozlowski <krzk@kernel.org>
> 
> Interrupt line can be configured on different hardware in different way,
> even inverted.  Therefore driver should not enforce specific trigger
> type - edge falling - but instead rely on Devicetree to configure it.
> 
> The Maxim 17047/77693 datasheets describe the interrupt line as active
> low with a requirement of acknowledge from the CPU therefore the edge
> falling is not correct.
> 
> The interrupt line is shared between PMIC and RTC driver, so using level
> sensitive interrupt is here especially important to avoid races.  With
> an edge configuration in case if first PMIC signals interrupt followed
> shortly after by the RTC, the interrupt might not be yet cleared/acked
> thus the second one would not be noticed.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> 
> ---
> 
> Changes since v1:
> 1. None
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/supply/max17042_battery.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/supply/max17042_battery.c b/drivers/power/supply/max17042_battery.c
> index 1d7326cd8fc6..ce2041b30a06 100644
> --- a/drivers/power/supply/max17042_battery.c
> +++ b/drivers/power/supply/max17042_battery.c
> @@ -1104,7 +1104,7 @@ static int max17042_probe(struct i2c_client *client,
>  	}
>  
>  	if (client->irq) {
> -		unsigned int flags = IRQF_TRIGGER_FALLING | IRQF_ONESHOT;
> +		unsigned int flags = IRQF_ONESHOT;
>  
>  		/*
>  		 * On ACPI systems the IRQ may be handled by ACPI-event code,
> -- 
> 2.27.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2 7/7] power: supply: max17040: Do not enforce (incorrect) interrupt trigger type
  2021-06-02 20:06   ` Rob Herring
@ 2021-06-04 10:01     ` Sebastian Reichel
  0 siblings, 0 replies; 15+ messages in thread
From: Sebastian Reichel @ 2021-06-04 10:01 UTC (permalink / raw)
  To: Rob Herring
  Cc: Krzysztof Kozlowski, Lee Jones, Rob Herring, Chanwoo Choi,
	Alessandro Zummo, Mark Brown, linux-samsung-soc, Liam Girdwood,
	linux-kernel, linux-clk, Bartlomiej Zolnierkiewicz, devicetree,
	Iskren Chernev, Krzysztof Kozlowski, Alexandre Belloni,
	Stephen Boyd, Michael Turquette, linux-rtc, linux-pm

[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]

Hi,

On Wed, Jun 02, 2021 at 03:06:09PM -0500, Rob Herring wrote:
> On Wed, 26 May 2021 13:20:36 -0400, Krzysztof Kozlowski wrote:
> > From: Krzysztof Kozlowski <krzk@kernel.org>
> > 
> > Interrupt line can be configured on different hardware in different way,
> > even inverted.  Therefore driver should not enforce specific trigger
> > type - edge falling - but instead rely on Devicetree to configure it.
> > 
> > The Maxim 14577/77836 datasheets describe the interrupt line as active
> > low with a requirement of acknowledge from the CPU therefore the edge
> > falling is not correct.
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > Acked-by: Iskren Chernev <iskren.chernev@gmail.com>
> > 
> > ---
> > 
> > Changes since v1:
> > 1. Remove the 'flags' variable.
> > 2. Added ack.
> > 3. Rebase - the bindings were converted to dtschema.
> > ---
> >  .../devicetree/bindings/power/supply/maxim,max17040.yaml      | 2 +-
> >  drivers/power/supply/max17040_battery.c                       | 4 +---
> >  2 files changed, 2 insertions(+), 4 deletions(-)
> > 
> 
> Acked-by: Rob Herring <robh@kernel.org>

Thanks, queued.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: (subset) [PATCH v2 0/7] mfd/power/rtc: Do not enforce (incorrect) interrupt trigger type
  2021-05-26 17:20 [PATCH v2 0/7] mfd/power/rtc: Do not enforce (incorrect) interrupt trigger type Krzysztof Kozlowski
                   ` (7 preceding siblings ...)
  2021-06-01 15:41 ` [PATCH v2 0/7] mfd/power/rtc: " Lee Jones
@ 2021-06-20 20:22 ` Alexandre Belloni
  8 siblings, 0 replies; 15+ messages in thread
From: Alexandre Belloni @ 2021-06-20 20:22 UTC (permalink / raw)
  To: linux-clk, linux-rtc, linux-samsung-soc, Mark Brown,
	Liam Girdwood, Sebastian Reichel, Michael Turquette,
	Stephen Boyd, linux-pm, Rob Herring, linux-kernel,
	Krzysztof Kozlowski, Chanwoo Choi, Lee Jones, Alessandro Zummo,
	Bartlomiej Zolnierkiewicz, devicetree
  Cc: Alexandre Belloni

On Wed, 26 May 2021 13:20:29 -0400, Krzysztof Kozlowski wrote:
> This is a v2 with only minor changes:
> 1. Drop patches which landed in mainline.
> 2. Add acks.
> 3. Rebase max17040 power supply (dtschema conversion).
> 
> Patches are independent and there are no external dependencies, so
> please pick up freely.
> 
> [...]

Applied, thanks!

[5/7] rtc: max77686: Do not enforce (incorrect) interrupt trigger type
      commit: 742b0d7e15c333303daad4856de0764f4bc83601

Best regards,
-- 
Alexandre Belloni <alexandre.belloni@bootlin.com>

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2021-06-20 20:22 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-26 17:20 [PATCH v2 0/7] mfd/power/rtc: Do not enforce (incorrect) interrupt trigger type Krzysztof Kozlowski
2021-05-26 17:20 ` [PATCH v2 1/7] mfd: sec-irq: " Krzysztof Kozlowski
2021-05-26 17:20 ` [PATCH v2 2/7] mfd: max77686: " Krzysztof Kozlowski
2021-05-26 22:33   ` Stephen Boyd
2021-05-26 17:20 ` [PATCH v2 3/7] mfd: max77693: " Krzysztof Kozlowski
2021-05-26 17:20 ` [PATCH v2 4/7] mfd: max14577: " Krzysztof Kozlowski
2021-05-26 17:20 ` [PATCH v2 5/7] rtc: max77686: " Krzysztof Kozlowski
2021-05-26 17:20 ` [PATCH v2 6/7] power: supply: max17042: " Krzysztof Kozlowski
2021-06-04 10:00   ` Sebastian Reichel
2021-05-26 17:20 ` [PATCH v2 7/7] power: supply: max17040: " Krzysztof Kozlowski
2021-06-02 20:06   ` Rob Herring
2021-06-04 10:01     ` Sebastian Reichel
2021-06-01 15:41 ` [PATCH v2 0/7] mfd/power/rtc: " Lee Jones
2021-06-01 16:13   ` Krzysztof Kozlowski
2021-06-20 20:22 ` (subset) " Alexandre Belloni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.