From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A510EC4708F for ; Wed, 2 Jun 2021 20:51:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 88732613DC for ; Wed, 2 Jun 2021 20:51:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229604AbhFBUwz (ORCPT ); Wed, 2 Jun 2021 16:52:55 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:44632 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229552AbhFBUwv (ORCPT ); Wed, 2 Jun 2021 16:52:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622667067; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YBa8+PXTDwcq19n3IVtQxJ5sM4F8l1dhPEHZRkOdih4=; b=jLunE66IFsfETxitTT3EzfjF61qqRc/FVDAQc5E0XoNlKF/3+ZcJufFfo3fANRNcSBmMj5 6SyqKs8arVmvhYxuvCMYoxlFfJjf+uM4r4Ngc6+J9ooGr3JMc1SUNpxkkvziP8b74ZCle1 r0wBc/oxEK9zlVRSdhg6vOGqqB3i+X8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-13-DI4OmT3zO8aGQzLRPw8dUg-1; Wed, 02 Jun 2021 16:51:06 -0400 X-MC-Unique: DI4OmT3zO8aGQzLRPw8dUg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BB8FA100A240; Wed, 2 Jun 2021 20:51:04 +0000 (UTC) Received: from redhat.com (ovpn-113-154.phx2.redhat.com [10.3.113.154]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CD176687F6; Wed, 2 Jun 2021 20:51:03 +0000 (UTC) Date: Wed, 2 Jun 2021 15:51:02 -0500 From: Eric Blake To: Valeriy Vdovin Cc: qemu-devel@nongnu.org, Eduardo Habkost , Marcel Apfelbaum , Markus Armbruster , Paolo Bonzini , Marcelo Tosatti , Richard Henderson , Thomas Huth , Laurent Vivier , kvm@vger.kernel.org, Denis Lunev , Vladimir Sementsov-Ogievskiy Subject: Re: [PATCH v8] qapi: introduce 'query-kvm-cpuid' action Message-ID: <20210602205102.icdqspki66rwvc3n@redhat.com> References: <20210531123806.23030-1-valeriy.vdovin@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210531123806.23030-1-valeriy.vdovin@virtuozzo.com> User-Agent: NeoMutt/20210205 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, May 31, 2021 at 03:38:06PM +0300, Valeriy Vdovin wrote: > Introducing new qapi method 'query-kvm-cpuid'. This method can be used to > get virtualized cpu model info generated by QEMU during VM initialization in > the form of cpuid representation. > > > Use example: > qmp_request: { > "execute": "query-kvm-cpuid" > } > > qmp_response: [ > { > "eax": 1073741825, > "edx": 77, > "in_eax": 1073741824, > "ecx": 1447775574, > "ebx": 1263359563, > }, JSON does not permit a trailing ',' before '}'; which means you did not actually paste an actual QMP response here. > --- > qapi/machine-target.json | 43 ++++++++++++++++++++++++++++++++++++++ > target/i386/kvm/kvm.c | 37 ++++++++++++++++++++++++++++++++ > tests/qtest/qmp-cmd-test.c | 1 + > 3 files changed, 81 insertions(+) > > diff --git a/qapi/machine-target.json b/qapi/machine-target.json > index e7811654b7..a83180dd24 100644 > --- a/qapi/machine-target.json > +++ b/qapi/machine-target.json > @@ -329,3 +329,46 @@ > ## > { 'command': 'query-cpu-definitions', 'returns': ['CpuDefinitionInfo'], > 'if': 'defined(TARGET_PPC) || defined(TARGET_ARM) || defined(TARGET_I386) || defined(TARGET_S390X) || defined(TARGET_MIPS)' } > + > +## > +# @CpuidEntry: > +# > +# A single entry of a CPUID response. > +# > +# One entry holds full set of information (leaf) returned to the guest in response > +# to it calling a CPUID instruction with eax, ecx used as the agruments to that arguments > +# instruction. ecx is an optional argument as not all of the leaves support it. Is there a default value of ecx for when it is not provided by the user but needed by the leaf? Or is it an error if ecx is omitted in that case? Similarly, is it an error if ecx is provided but not needed? > +# > +# @in_eax: CPUID argument in eax > +# @in_ecx: CPUID argument in ecx Should be in-eax, in-ecx. > +# @eax: eax > +# @ebx: ebx > +# @ecx: ecx > +# @edx: edx > +# > +# Since: 6.1 > +## > +{ 'struct': 'CpuidEntry', > + 'data': { 'in_eax' : 'uint32', > + '*in_ecx' : 'uint32', > + 'eax' : 'uint32', > + 'ebx' : 'uint32', > + 'ecx' : 'uint32', > + 'edx' : 'uint32' > + }, > + 'if': 'defined(TARGET_I386) && defined(CONFIG_KVM)' } > + > +## > +# @query-kvm-cpuid: > +# > +# Returns raw data from the KVM CPUID table for the first VCPU. > +# The KVM CPUID table defines the response to the CPUID > +# instruction when executed by the guest operating system. > +# > +# Returns: a list of CpuidEntry > +# > +# Since: 6.1 > +## > +{ 'command': 'query-kvm-cpuid', > + 'returns': ['CpuidEntry'], > + 'if': 'defined(TARGET_I386) && defined(CONFIG_KVM)' } -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3E33C47083 for ; Wed, 2 Jun 2021 20:52:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F0FA613DC for ; Wed, 2 Jun 2021 20:52:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F0FA613DC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46374 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loXqO-0006wJ-Ev for qemu-devel@archiver.kernel.org; Wed, 02 Jun 2021 16:52:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52234) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loXpW-0006GE-7r for qemu-devel@nongnu.org; Wed, 02 Jun 2021 16:51:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:60737) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loXpU-0006YA-I4 for qemu-devel@nongnu.org; Wed, 02 Jun 2021 16:51:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622667067; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YBa8+PXTDwcq19n3IVtQxJ5sM4F8l1dhPEHZRkOdih4=; b=jLunE66IFsfETxitTT3EzfjF61qqRc/FVDAQc5E0XoNlKF/3+ZcJufFfo3fANRNcSBmMj5 6SyqKs8arVmvhYxuvCMYoxlFfJjf+uM4r4Ngc6+J9ooGr3JMc1SUNpxkkvziP8b74ZCle1 r0wBc/oxEK9zlVRSdhg6vOGqqB3i+X8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-13-DI4OmT3zO8aGQzLRPw8dUg-1; Wed, 02 Jun 2021 16:51:06 -0400 X-MC-Unique: DI4OmT3zO8aGQzLRPw8dUg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BB8FA100A240; Wed, 2 Jun 2021 20:51:04 +0000 (UTC) Received: from redhat.com (ovpn-113-154.phx2.redhat.com [10.3.113.154]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CD176687F6; Wed, 2 Jun 2021 20:51:03 +0000 (UTC) Date: Wed, 2 Jun 2021 15:51:02 -0500 From: Eric Blake To: Valeriy Vdovin Subject: Re: [PATCH v8] qapi: introduce 'query-kvm-cpuid' action Message-ID: <20210602205102.icdqspki66rwvc3n@redhat.com> References: <20210531123806.23030-1-valeriy.vdovin@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210531123806.23030-1-valeriy.vdovin@virtuozzo.com> User-Agent: NeoMutt/20210205 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Received-SPF: pass client-ip=216.205.24.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.371, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , Vladimir Sementsov-Ogievskiy , Eduardo Habkost , kvm@vger.kernel.org, Marcelo Tosatti , Richard Henderson , Markus Armbruster , qemu-devel@nongnu.org, Denis Lunev , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, May 31, 2021 at 03:38:06PM +0300, Valeriy Vdovin wrote: > Introducing new qapi method 'query-kvm-cpuid'. This method can be used to > get virtualized cpu model info generated by QEMU during VM initialization in > the form of cpuid representation. > > > Use example: > qmp_request: { > "execute": "query-kvm-cpuid" > } > > qmp_response: [ > { > "eax": 1073741825, > "edx": 77, > "in_eax": 1073741824, > "ecx": 1447775574, > "ebx": 1263359563, > }, JSON does not permit a trailing ',' before '}'; which means you did not actually paste an actual QMP response here. > --- > qapi/machine-target.json | 43 ++++++++++++++++++++++++++++++++++++++ > target/i386/kvm/kvm.c | 37 ++++++++++++++++++++++++++++++++ > tests/qtest/qmp-cmd-test.c | 1 + > 3 files changed, 81 insertions(+) > > diff --git a/qapi/machine-target.json b/qapi/machine-target.json > index e7811654b7..a83180dd24 100644 > --- a/qapi/machine-target.json > +++ b/qapi/machine-target.json > @@ -329,3 +329,46 @@ > ## > { 'command': 'query-cpu-definitions', 'returns': ['CpuDefinitionInfo'], > 'if': 'defined(TARGET_PPC) || defined(TARGET_ARM) || defined(TARGET_I386) || defined(TARGET_S390X) || defined(TARGET_MIPS)' } > + > +## > +# @CpuidEntry: > +# > +# A single entry of a CPUID response. > +# > +# One entry holds full set of information (leaf) returned to the guest in response > +# to it calling a CPUID instruction with eax, ecx used as the agruments to that arguments > +# instruction. ecx is an optional argument as not all of the leaves support it. Is there a default value of ecx for when it is not provided by the user but needed by the leaf? Or is it an error if ecx is omitted in that case? Similarly, is it an error if ecx is provided but not needed? > +# > +# @in_eax: CPUID argument in eax > +# @in_ecx: CPUID argument in ecx Should be in-eax, in-ecx. > +# @eax: eax > +# @ebx: ebx > +# @ecx: ecx > +# @edx: edx > +# > +# Since: 6.1 > +## > +{ 'struct': 'CpuidEntry', > + 'data': { 'in_eax' : 'uint32', > + '*in_ecx' : 'uint32', > + 'eax' : 'uint32', > + 'ebx' : 'uint32', > + 'ecx' : 'uint32', > + 'edx' : 'uint32' > + }, > + 'if': 'defined(TARGET_I386) && defined(CONFIG_KVM)' } > + > +## > +# @query-kvm-cpuid: > +# > +# Returns raw data from the KVM CPUID table for the first VCPU. > +# The KVM CPUID table defines the response to the CPUID > +# instruction when executed by the guest operating system. > +# > +# Returns: a list of CpuidEntry > +# > +# Since: 6.1 > +## > +{ 'command': 'query-kvm-cpuid', > + 'returns': ['CpuidEntry'], > + 'if': 'defined(TARGET_I386) && defined(CONFIG_KVM)' } -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org