From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F968C4708F for ; Wed, 2 Jun 2021 21:01:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 70F7D613DC for ; Wed, 2 Jun 2021 21:01:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229611AbhFBVC4 (ORCPT ); Wed, 2 Jun 2021 17:02:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:23841 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229568AbhFBVCz (ORCPT ); Wed, 2 Jun 2021 17:02:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622667671; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=p7sg/IMBwTD2xBJjdgJTtT61hdFxda4nZcANb5K1ByQ=; b=F6r81dDTxXSGZjqaYnJfQbZUlF4xoF71reBcn5HcHbR0vYVpi1gxkq2ijbSzd/1UFuQPRw QzMgEKrm++tt9LmRUx1ChI3+IpGKAyi0MjO1KiVu5xtv3MJR4WKyZvOjvOSQ66C+6F/BJ8 8MljGmCpzkAK7sqyoAksHtyzryZWTKk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-162-4sAFZaa2MSiDWdsKFz2jPQ-1; Wed, 02 Jun 2021 17:01:08 -0400 X-MC-Unique: 4sAFZaa2MSiDWdsKFz2jPQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0512D1883526; Wed, 2 Jun 2021 21:01:07 +0000 (UTC) Received: from localhost (ovpn-119-154.rdu2.redhat.com [10.10.119.154]) by smtp.corp.redhat.com (Postfix) with ESMTP id A390119714; Wed, 2 Jun 2021 21:01:06 +0000 (UTC) Date: Wed, 2 Jun 2021 17:01:06 -0400 From: Eduardo Habkost To: Eric Blake Cc: Valeriy Vdovin , qemu-devel@nongnu.org, Marcel Apfelbaum , Markus Armbruster , Paolo Bonzini , Marcelo Tosatti , Richard Henderson , Thomas Huth , Laurent Vivier , kvm@vger.kernel.org, Denis Lunev , Vladimir Sementsov-Ogievskiy Subject: Re: [PATCH v8] qapi: introduce 'query-kvm-cpuid' action Message-ID: <20210602210106.aahfqxu7cvxr5otx@habkost.net> References: <20210531123806.23030-1-valeriy.vdovin@virtuozzo.com> <20210602205102.icdqspki66rwvc3n@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210602205102.icdqspki66rwvc3n@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Jun 02, 2021 at 03:51:02PM -0500, Eric Blake wrote: > On Mon, May 31, 2021 at 03:38:06PM +0300, Valeriy Vdovin wrote: [...] > > +## > > +# @CpuidEntry: > > +# > > +# A single entry of a CPUID response. > > +# > > +# One entry holds full set of information (leaf) returned to the guest in response > > +# to it calling a CPUID instruction with eax, ecx used as the agruments to that > > arguments > > > +# instruction. ecx is an optional argument as not all of the leaves support it. > > Is there a default value of ecx for when it is not provided by the > user but needed by the leaf? Or is it an error if ecx is omitted in > that case? Similarly, is it an error if ecx is provided but not > needed? What does "not provided by the user" mean here? This is not describing the input to a QMP command, but the input to the CPUID instruction. -- Eduardo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4C20C4708F for ; Wed, 2 Jun 2021 21:02:23 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A1C4613E9 for ; Wed, 2 Jun 2021 21:02:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A1C4613E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52824 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loY0M-0003Vl-7f for qemu-devel@archiver.kernel.org; Wed, 02 Jun 2021 17:02:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53662) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loXzE-0002UA-TO for qemu-devel@nongnu.org; Wed, 02 Jun 2021 17:01:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:25954) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loXzC-0004XI-I7 for qemu-devel@nongnu.org; Wed, 02 Jun 2021 17:01:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622667669; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=p7sg/IMBwTD2xBJjdgJTtT61hdFxda4nZcANb5K1ByQ=; b=C9tLtWD/gsn6OREAK4zaffqtb+2LihCaZELdN0LNUTvVYqVjPSHysr/K8aS+4HNda1rHA6 wRG30ocl+RS6hOxDx+Vn5nrKX7w2tOGtNzVn48kWQPgxG9j2HMT/QBSfSI8vYscd4UfB6t k+N4HQMAk4bBULKCCnFNR/36V8nWmnE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-162-4sAFZaa2MSiDWdsKFz2jPQ-1; Wed, 02 Jun 2021 17:01:08 -0400 X-MC-Unique: 4sAFZaa2MSiDWdsKFz2jPQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0512D1883526; Wed, 2 Jun 2021 21:01:07 +0000 (UTC) Received: from localhost (ovpn-119-154.rdu2.redhat.com [10.10.119.154]) by smtp.corp.redhat.com (Postfix) with ESMTP id A390119714; Wed, 2 Jun 2021 21:01:06 +0000 (UTC) Date: Wed, 2 Jun 2021 17:01:06 -0400 From: Eduardo Habkost To: Eric Blake Subject: Re: [PATCH v8] qapi: introduce 'query-kvm-cpuid' action Message-ID: <20210602210106.aahfqxu7cvxr5otx@habkost.net> References: <20210531123806.23030-1-valeriy.vdovin@virtuozzo.com> <20210602205102.icdqspki66rwvc3n@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210602205102.icdqspki66rwvc3n@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Received-SPF: pass client-ip=170.10.133.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.371, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , Vladimir Sementsov-Ogievskiy , kvm@vger.kernel.org, Marcelo Tosatti , Richard Henderson , Markus Armbruster , qemu-devel@nongnu.org, Valeriy Vdovin , Denis Lunev , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Jun 02, 2021 at 03:51:02PM -0500, Eric Blake wrote: > On Mon, May 31, 2021 at 03:38:06PM +0300, Valeriy Vdovin wrote: [...] > > +## > > +# @CpuidEntry: > > +# > > +# A single entry of a CPUID response. > > +# > > +# One entry holds full set of information (leaf) returned to the guest in response > > +# to it calling a CPUID instruction with eax, ecx used as the agruments to that > > arguments > > > +# instruction. ecx is an optional argument as not all of the leaves support it. > > Is there a default value of ecx for when it is not provided by the > user but needed by the leaf? Or is it an error if ecx is omitted in > that case? Similarly, is it an error if ecx is provided but not > needed? What does "not provided by the user" mean here? This is not describing the input to a QMP command, but the input to the CPUID instruction. -- Eduardo